Skip to contentSkip to conversation

net/bnx2x: fix segfaults due to stale interrupt status

PATCH Applied Shahed Shaikh 2 participants 2 messages Feb 21, 2019 – Feb 25, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnx2x: fix segfaults due to stale interrupt status

Previous ungraceful exit may leave behind un-acked stale interrupts for slowpath and fastpath.

Interrupt status polling function is started before FLR is initiated, so we don't have a real way to protect this polling function invoking an interrupt handler caused due to stale interrupt status from previous ungraceful exit.

So, check uninitialized status block variables in interrupt handling path which may lead to sefault.

Fixes 540a211084a7 ("bnx2x: driver core")
---
 drivers/net/bnx2x/bnx2x.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/bnx2x/bnx2x.c +7 -0
index 4c775c1..26b3828 100644
@@ -4201,6 +4201,9 @@ static uint16_t bnx2x_update_dsb_idx(struct bnx2x_softc *sc)
 	struct host_sp_status_block *def_sb = sc->def_sb;
 	uint16_t rc = 0;
 
+	if (!def_sb)
+		return 0;
+
 	mb();			/* status block is written to by the chip */
 
 	if (sc->def_att_idx != def_sb->atten_status_block.attn_bits_index) {
@@ -4525,6 +4528,10 @@ static void bnx2x_handle_fp_tq(struct bnx2x_fastpath *fp, int scan_fp)
 	struct bnx2x_softc *sc = fp->sc;
 	uint8_t more_rx = FALSE;
 
+	/* Make sure FP is initialized */
+	if (!fp->sb_running_index)
+		return;
+
 	PMD_DEBUG_PERIODIC_LOG(DEBUG, sc,
 			       "---> FP TASK QUEUE (%d) <--", fp->index);
 
Signature · 1 line
2.7.4
Applied
#1 lore raw
Quoted 8 lines · Shahed Shaikh

Previous ungraceful exit may leave behind un-acked stale interrupts for slowpath and fastpath.

Interrupt status polling function is started before FLR is initiated, so we don't have a real way to protect this polling function invoking an interrupt handler caused due to stale interrupt status from previous ungraceful exit.

Quoted 7 lines

So, check uninitialized status block variables in interrupt handling path which may lead to sefault.

Fixes 540a211084a7 ("bnx2x: driver core")

Applied to dpdk-next-net/master, thanks.