soc: qcom: qmi: Change txn wait to non-interruptible
Subsystems (2)
PATCH 1/1 soc: qcom: qmi: Change txn wait to non-interruptible
Current QMI clients are not userspace facing, if their threads are signaled, they do not do any signal checking or propagate the ERESTARTSYS return code up. Remove the interruptible option so clients can finish their QMI transactions even if the thread is signaled.
Signed-off-by Chris Lew <[email protected]>
--- drivers/soc/qcom/qmi_interface.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/soc/qcom/qmi_interface.c +2 -5
@@ -345,8 +345,7 @@ int qmi_txn_wait(struct qmi_txn *txn, unsigned long timeout)struct qmi_handle *qmi = txn->qmi;int ret; - ret =wait_for_completion_interruptible_timeout (&txn->completion, - timeout); + ret =wait_for_completion_timeout (&txn->completion, timeout);mutex_lock (&qmi->txn_lock);mutex_lock (&txn->lock);
@@ -354,9 +353,7 @@ int qmi_txn_wait(struct qmi_txn *txn, unsigned long timeout)mutex_unlock (&txn->lock);mutex_unlock (&qmi->txn_lock); -if (ret <0 ) -return ret; -else if (ret ==0 ) +if (ret ==0 )return -ETIMEDOUT ;else return txn->result;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 6 lines · Chris Lew
Current QMI clients are not userspace facing, if their threads are signaled, they do not do any signal checking or propagate the ERESTARTSYS return code up. Remove the interruptible option so clients can finish their QMI transactions even if the thread is signaled.
Signed-off-by Chris Lew <[email protected]>
Reviewed-by Bjorn Andersson <[email protected]>
Regards,
Bjorn
Quoted 33 lines
--- drivers/soc/qcom/qmi_interface.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/soc/qcom/qmi_interface.c +2
-5@@ -345,8 +345,7 @@ int qmi_txn_wait(struct qmi_txn *txn, unsigned long timeout)struct qmi_handle *qmi = txn->qmi;int ret; - ret =wait_for_completion_interruptible_timeout (&txn->completion, - timeout); + ret =wait_for_completion_timeout (&txn->completion, timeout);mutex_lock (&qmi->txn_lock);mutex_lock (&txn->lock);@@ -354,9 +353,7 @@ int qmi_txn_wait(struct qmi_txn *txn, unsigned long timeout)mutex_unlock (&txn->lock);mutex_unlock (&qmi->txn_lock); -if (ret <0 ) -return ret; -else if (ret ==0 ) +if (ret ==0 )return -ETIMEDOUT ;else return txn->result;Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project