Skip to contentSkip to conversation

ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC

PATCH In review Anand Moon 2 participants 3 messages Feb 22, 2019

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH 1/1 ARM: dts: exynos: Add pin configuration for read strobe for Odroid XU3/XU4 eMMC

Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write.

Signed-off-by Anand Moon <[email protected]>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi          | 6 ++++++
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +6 -0
index b82af7c89654..4fb3865e082a 100644
@@ -206,6 +206,12 @@
 		samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>;
 	};
 
+	sd0_rdqs: sd0-rdqs {
+		samsung,pins = "gpc0-7";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+	};
+
 	sd1_clk: sd1-clk {
 		samsung,pins = "gpc1-0";
 		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +1 -1
index b299e541cac0..d41397748ed2 100644
@@ -411,7 +411,7 @@
 	samsung,dw-mshc-hs400-timing = <0 2>;
 	samsung,read-strobe-delay = <90>;
 	pinctrl-names = "default";
-	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>;
+	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>;
 	bus-width = <8>;
 	cap-mmc-highspeed;
 	mmc-hs200-1_8v;
Signature · 1 line
2.20.1
#1 lore raw

Hi Anand,

Quoted 13 lines · Anand Moon

Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write.

Signed-off-by Anand Moon <[email protected]>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi          | 6 ++++++
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +0 -0
index b82af7c89654..4fb3865e082a 100644

arch/arm/boot/dts/exynos5420-pinctrl.dtsi line 214

Quoted 9 lines
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +6 -0
@@ -206,6 +206,12 @@
 		samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>;
 	};
 
+	sd0_rdqs: sd0-rdqs {
+		samsung,pins = "gpc0-7";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+	};
+

The above lines are not needed. There is already a sd0_rclk node with exactly the same configuration just above your change.

Quoted 8 lines
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +0 -0
 	sd1_clk: sd1-clk {
 		samsung,pins = "gpc1-0";
 		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +0 -0
index b299e541cac0..d41397748ed2 100644

arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi line 417

Quoted 8 lines
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +1 -1
@@ -411,7 +411,7 @@
 	samsung,dw-mshc-hs400-timing = <0 2>;
 	samsung,read-strobe-delay = <90>;
 	pinctrl-names = "default";
-	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>;
+	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>;
 	bus-width = <8>;
 	cap-mmc-highspeed;
 	mmc-hs200-1_8v;

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
author
#2 lore raw

Hi Marek,

Quoted 20 lines · Marek Szyprowski

Hi Anand,

Quoted 16 lines · Anand Moon

Add Read Strobe RDQS pin configuration for eMMC to support higher data rate read/write.

Signed-off-by Anand Moon <[email protected]>
---
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi          | 6 ++++++
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +0 -0
index b82af7c89654..4fb3865e082a 100644
@@ -206,6 +206,12 @@
              samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV4>;
      };
Quoted 10 lines

arch/arm/boot/dts/exynos5420-pinctrl.dtsi line 214

Quoted 6 lines
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +6 -0
+     sd0_rdqs: sd0-rdqs {
+             samsung,pins = "gpc0-7";
+             samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+             samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+     };
+

The above lines are not needed. There is already a sd0_rclk node with exactly the same configuration just above your change.

Sorry once again, I failed to look closely., sorry for the noise.

Best Regards
-Anand

Quoted 22 lines
Quoted 8 lines
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +0 -0
      sd1_clk: sd1-clk {
              samsung,pins = "gpc1-0";
              samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +0 -0
index b299e541cac0..d41397748ed2 100644

arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi line 417

Quoted 8 lines
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +1 -1
@@ -411,7 +411,7 @@
      samsung,dw-mshc-hs400-timing = <0 2>;
      samsung,read-strobe-delay = <90>;
      pinctrl-names = "default";
-     pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>;
+     pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_rdqs &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd &sd0_rclk>;
      bus-width = <8>;
      cap-mmc-highspeed;
      mmc-hs200-1_8v;

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland