batman-adv: fix warning in function batadv_v_elp_get_throughput
Subsystems (3)
PATCH 1/1 batman-adv: fix warning in function batadv_v_elp_get_throughput
When CONFIG_CFG80211 isn't enabled the compiler correcly warns about 'sinfo.pertid' may be unused. It can also happen for other error conditions that it not warn about.
net/batman-adv/bat_v_elp.c: In function ‘batadv_v_elp_get_throughput.isra.0’:include/net/cfg80211.h:6370:13: warning: ‘sinfo.pertid’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
kfree(sinfo->pertid);
~~~~~^~~~~~~~Rework so that we only release '&sinfo' if cfg80211_get_station returns zero.
Signed-off-by Anders Roxell <[email protected]>
--- net/batman-adv/bat_v_elp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
net/batman-adv/bat_v_elp.c +4 -2
@@ -104,8 +104,10 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) ret =cfg80211_get_station (real_netdev, neigh->addr, &sinfo); -/* free the TID stats immediately */ -cfg80211_sinfo_release_content (&sinfo); +if (!ret) { +/* free the TID stats immediately */ +cfg80211_sinfo_release_content (&sinfo); + }dev_put (real_netdev);if (ret == -ENOENT ) {
Signature · 1 line
2.19.2