Skip to contentSkip to conversation

Staging: sm750fb: Fix missing a blank line after declarations

PATCH In review Madhumitha Prabakaran 2 participants 3 messages Feb 23, 2019 – Feb 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: sm750fb: Fix missing a blank line after declarations

This patch fix a warning
WARNING: Missing a blank line after declarations

---
 drivers/staging/sm750fb/sm750_accel.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/sm750fb/sm750_accel.h +1 -0
index c4f42002a50f..018adf3d82a1 100644
@@ -223,4 +223,5 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 		 u32 fColor,   /* Foreground color (corresponding to a 1 in the monochrome data */
 		 u32 bColor,   /* Background color (corresponding to a 0 in the monochrome data */
 		 u32 rop2);
+
 #endif
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Madhumitha Prabakaran

This patch fix a warning
WARNING: Missing a blank line after declarations

---
 drivers/staging/sm750fb/sm750_accel.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/sm750fb/sm750_accel.h +0 -0
index c4f42002a50f..018adf3d82a1 100644

drivers/staging/sm750fb/sm750_accel.h int sm750_hw_imageblit(struct lynx_accel *accel, · line 226

Quoted 4 lines
drivers/staging/sm750fb/sm750_accel.h +1 -0
@@ -223,4 +223,5 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 		 u32 fColor,   /* Foreground color (corresponding to a 1 in the monochrome data */
 		 u32 bColor,   /* Background color (corresponding to a 0 in the monochrome data */
 		 u32 rop2);
+

This doesn't look useful. Actually checkpatch is just based on regular expressions, so it doesn't have a global view of the code. The blank line is to separate local variables in a block, ie { ... } from the main code in the block. That is not the case here.

julia

Quoted 11 lines
drivers/staging/sm750fb/sm750_accel.h +0 -1
 #endif
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223032632.18892-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
In reply to Madhumitha Prabakaran
Quoted 21 lines · Madhumitha Prabakaran

This patch fix a warning
WARNING: Missing a blank line after declarations

---
 drivers/staging/sm750fb/sm750_accel.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/sm750fb/sm750_accel.h +1 -0
index c4f42002a50f..018adf3d82a1 100644
@@ -223,4 +223,5 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 		 u32 fColor,   /* Foreground color (corresponding to a 1 in the monochrome data */
 		 u32 bColor,   /* Background color (corresponding to a 0 in the monochrome data */
 		 u32 rop2);
+
 #endif
Signature · 1 line
2.17.1

I will leave this patch alone and work on another one