Skip to contentSkip to conversation

Staging: sm750fb: Fix missing blank line

PATCH In review Madhumitha Prabakaran 2 participants 3 messages Feb 23, 2019 – Feb 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: sm750fb: Fix missing blank line

This patch fix a warning
WARNING: Missing a blank line after declarations.

---
 drivers/staging/sm750fb/sm750_accel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/sm750_accel.c +1 -1
index 242fc29e5738..67f1d9cd566e 100644
@@ -302,7 +302,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 		 u32 fColor,   /* Foreground color (corresponding to a 1 in the monochrome data */
 		 u32 bColor,   /* Background color (corresponding to a 0 in the monochrome data */
 		 u32 rop2)     /* ROP value */
-		 
+
 {
 	unsigned int ulBytesPerScan;
 	unsigned int ul4BytesPerScan;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 13 lines · Madhumitha Prabakaran

This patch fix a warning
WARNING: Missing a blank line after declarations.

---
 drivers/staging/sm750fb/sm750_accel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/sm750_accel.c +0 -0
index 242fc29e5738..67f1d9cd566e 100644

drivers/staging/sm750fb/sm750_accel.c int sm750_hw_imageblit(struct lynx_accel *accel, · line 305

Quoted 5 lines
drivers/staging/sm750fb/sm750_accel.c +1 -1
@@ -302,7 +302,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 		 u32 fColor,   /* Foreground color (corresponding to a 1 in the monochrome data */
 		 u32 bColor,   /* Background color (corresponding to a 0 in the monochrome data */
 		 u32 rop2)     /* ROP value */
-		 
+

Shouldn't you just delete this line entirely?

#2 lore raw
Quoted 9 lines · Greg KH
Quoted 8 lines · Madhumitha Prabakaran

This patch fix a warning
WARNING: Missing a blank line after declarations.

---
 drivers/staging/sm750fb/sm750_accel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

drivers/staging/sm750fb/sm750_accel.c int sm750_hw_imageblit(struct lynx_accel *accel, · line 305

Quoted 10 lines
drivers/staging/sm750fb/sm750_accel.c +1 -1
index 242fc29e5738..67f1d9cd566e 100644
@@ -302,7 +302,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
 		 u32 fColor,   /* Foreground color (corresponding to a 1 in the monochrome data */
 		 u32 bColor,   /* Background color (corresponding to a 0 in the monochrome data */
 		 u32 rop2)     /* ROP value */
-		 
+

Shouldn't you just delete this line entirely?

There is no necessity for blank line, as it doesn't serve any purpose. So, I leave this patch alone and work on another one.