Skip to contentSkip to conversation

Staging: vt6655: Fix check-Lines should not end with a '('

PATCH Superseded Madhumitha Prabakaran 2 participants 2 messages Feb 24, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: vt6655: Fix check-Lines should not end with a '('

Improves readibility

---
 drivers/staging/vt6655/baseband.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vt6655/baseband.c +2 -2
index 9d4af51b6ba1..1f1f82ebbbc2 100644
@@ -1705,8 +1705,8 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  *
  */
 unsigned int BBuGetFrameTime(unsigned char byPreambleType,
-	                     unsigned char byPktType,unsigned int cbFrameLength,
-	                     unsigned short wRate)
+	unsigned char byPktType, unsigned int cbFrameLength,
+	unsigned short wRate)
 {
 	unsigned int uFrameTime;
 	unsigned int uPreamble;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Madhumitha Prabakaran

Improves readibility

Log messages should be in the imperative, which typicalls means no s at the end of the verb.

Quoted 11 lines
---
 drivers/staging/vt6655/baseband.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vt6655/baseband.c +0 -0
index 9d4af51b6ba1..1f1f82ebbbc2 100644

drivers/staging/vt6655/baseband.c static const unsigned short awcFrameTime[MAX_RATE] = { · line 1709

Quoted 7 lines
drivers/staging/vt6655/baseband.c +2 -2
@@ -1705,8 +1705,8 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  *
  */
 unsigned int BBuGetFrameTime(unsigned char byPreambleType,
-	                     unsigned char byPktType,unsigned int cbFrameLength,
-	                     unsigned short wRate)
+	unsigned char byPktType, unsigned int cbFrameLength,
+	unsigned short wRate)

There is no need for this large unindent. If it is not possible to put multiple parameters on one line, you can use multiple lines.

julia

Quoted 13 lines
drivers/staging/vt6655/baseband.c +0 -1
 {
 	unsigned int uFrameTime;
 	unsigned int uPreamble;
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190224041926.10019-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.