Skip to contentSkip to conversation

gtk+3: Fix build failure with gold linker

PATCH In review Khem Raj 3 participants 4 messages Feb 21, 2019 – Feb 25, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 gtk+3: Fix build failure with gold linker

Explicitly link in libfribidi

---
 .../gtk+/gtk+3/link_fribidi.patch             | 19 +++++++++++++++++++
 meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb       |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch new file +19 -0
new file mode 100644
index 0000000000..e4bbd799f1
@@ -0,0 +1,19 @@
+Link with libfribidi, this is to avoid under linking where these functions are
+used but the library is not linked in, and they are marked undefined by BFD linker
+but gold linker refuses to link
+
+| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
+
+Signed-off-by: Khem Raj <[email protected]>
+Upstream-Status: Pending
+
+--- a/gdk/Makefile.am
++++ b/gdk/Makefile.am
+@@ -55,6 +55,7 @@ LDADD = 					\
+ 	-version-info $(LT_VERSION_INFO)	\
+ 	-export-dynamic 			\
+ 	-rpath $(libdir) 			\
++	-lfribidi	 			\
+ 	$(no_undefined)
+ 
+ #
meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb +1 -0
index 799cbd4707..92c9a3ebfb 100644
@@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
            file://0001-Hardcoded-libtool.patch \
            file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
            file://0003-Add-disable-opengl-configure-option.patch \
+           file://link_fribidi.patch \
           "
 SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
 SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"
Signature · 1 line
2.20.1
Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines · Khem Raj

Explicitly link in libfribidi

---
 .../gtk+/gtk+3/link_fribidi.patch             | 19 +++++++++++++++++++
 meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb       |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch

+1

#2 lore raw
In reply to Khem Raj

Have you sent this upstream?

Ross

Quoted 55 lines · Khem Raj

Explicitly link in libfribidi

---
 .../gtk+/gtk+3/link_fribidi.patch             | 19 +++++++++++++++++++
 meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb       |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch new file +19 -0
new file mode 100644
index 0000000000..e4bbd799f1
@@ -0,0 +1,19 @@
+Link with libfribidi, this is to avoid under linking where these functions are
+used but the library is not linked in, and they are marked undefined by BFD linker
+but gold linker refuses to link
+
+| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
+
+Signed-off-by: Khem Raj <[email protected]>
+Upstream-Status: Pending
+
+--- a/gdk/Makefile.am
++++ b/gdk/Makefile.am
+@@ -55,6 +55,7 @@ LDADD =                                      \
+       -version-info $(LT_VERSION_INFO)        \
+       -export-dynamic                         \
+       -rpath $(libdir)                        \
++      -lfribidi                               \
+       $(no_undefined)
+
+ #
meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb +1 -1
index 799cbd4707..92c9a3ebfb 100644
@@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
            file://0001-Hardcoded-libtool.patch \
            file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
            file://0003-Add-disable-opengl-configure-option.patch \
+           file://link_fribidi.patch \
           "
 SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
 SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#3 lore raw
Quoted 3 lines · Ross

Have you sent this upstream?

No, I haven't

Quoted 58 lines

Ross

Quoted 55 lines · Khem Raj

Explicitly link in libfribidi

---
 .../gtk+/gtk+3/link_fribidi.patch             | 19 +++++++++++++++++++
 meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb       |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch new file +19 -0
new file mode 100644
index 0000000000..e4bbd799f1
@@ -0,0 +1,19 @@
+Link with libfribidi, this is to avoid under linking where these functions are
+used but the library is not linked in, and they are marked undefined by BFD linker
+but gold linker refuses to link
+
+| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
+
+Signed-off-by: Khem Raj <[email protected]>
+Upstream-Status: Pending
+
+--- a/gdk/Makefile.am
++++ b/gdk/Makefile.am
+@@ -55,6 +55,7 @@ LDADD =                                      \
+       -version-info $(LT_VERSION_INFO)        \
+       -export-dynamic                         \
+       -rpath $(libdir)                        \
++      -lfribidi                               \
+       $(no_undefined)
+
+ #
meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb +1 -1
index 799cbd4707..92c9a3ebfb 100644
@@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
            file://0001-Hardcoded-libtool.patch \
            file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
            file://0003-Add-disable-opengl-configure-option.patch \
+           file://link_fribidi.patch \
           "
 SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
 SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"
--

2.20.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core