Skip to contentSkip to conversation

package/clamav: link with libatomic when needed

PATCH New Bernd Kuhls 2 participants 2 messages Feb 16, 2019 – Feb 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/clamav: link with libatomic when needed

Configure check for OpenSSL fails:

/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-3/output/host/sparc-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(threads_pthread.o): In function `CRYPTO_atomic_add':
threads_pthread.c:(.text+0x1dc): undefined reference to `__atomic_is_lock_free'
threads_pthread.c:(.text+0x1f4): undefined reference to `__atomic_fetch_add_4'

Fixes
http://autobuild.buildroot.net/results/cae8da81adff3ba493154e0ba8b21d90367f82eb/

---
 package/clamav/clamav.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/clamav/clamav.mk +4 -0
index b5a184a67c..8900b4819a 100644
@@ -22,6 +22,10 @@ CLAMAV_CONF_ENV = \
 	ac_cv_c_mmap_private=yes \
 	have_cv_ipv6=yes
 
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+CLAMAV_CONF_ENV += LIBS=-latomic
+endif
+
 # UCLIBC_HAS_FTS is disabled, therefore disable fanotify (missing fts.h)
 CLAMAV_CONF_OPTS = \
 	--with-dbdir=/var/lib/clamav \
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/clamav: link with libatomic when needed

Hello,

Quoted 6 lines · On Sat, 16 Feb 2019 09:19:05 +0100 Bernd Kuhls <[email protected]> wrote:

Configure check for OpenSSL fails:

/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-3/output/host/sparc-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(threads_pthread.o): In function `CRYPTO_atomic_add':
threads_pthread.c:(.text+0x1dc): undefined reference to `__atomic_is_lock_free'
threads_pthread.c:(.text+0x1f4): undefined reference to `__atomic_fetch_add_4'

Quoted 7 lines

Fixes
http://autobuild.buildroot.net/results/cae8da81adff3ba493154e0ba8b21d90367f82eb/

---
 package/clamav/clamav.mk | 4 ++++
 1 file changed, 4 insertions(+)

I would still prefer a solution based on pkg-config for such problems (especially since clamav is already using pkg-config to find some other libraries), but OK, let's do this for now, it's the least invasive solution.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com