net/mlx5: call generic strlcpy
PATCH 1/1 net/mlx5: call generic strlcpy
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy. No need to call the DPDK flavor explictly.
--- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5.c +1 -1
@@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, }/* Build device name. */ if (!switch_info->representor) -rte_strlcpy (name, dpdk_dev->name,sizeof (name)); +strlcpy (name, dpdk_dev->name,sizeof (name));else snprintf (name,sizeof (name),"%s_representor_%u" , dpdk_dev->name, switch_info->port_name);
Signature · 1 line
2.20.1
Checked on Fedora 28
Quoted 25 lines · Thomas Monjalon
The call to strlcpy uses either libc, libbsd or internal
rte_strlcpy. No need to call the DPDK flavor explictly.Signed-off-by Thomas Monjalon <[email protected]>--- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/mlx5/mlx5.c +1
-2@@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, }/* Build device name. */ if (!switch_info->representor) -rte_strlcpy (name, dpdk_dev->name,sizeof (name)); +strlcpy (name, dpdk_dev->name,sizeof (name));else snprintf (name,sizeof (name),"%s_representor_%u" , dpdk_dev->name, switch_info->port_name); --2.20.1
Signature · 2 lines
regards, Rami Rosen
Applied to next-net-mlx, thanks.
From: Rami Rosen <[email protected]>
Sent: Monday, February 25, 2019 8:26 AM
To: Thomas Monjalon <[email protected]>
Cc: Shahaf Shuler <[email protected]>; Yongseok Koh <[email protected]>; dev <[email protected]>; Ophir Munk <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
Checked on Fedora 28
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <[email protected]<mailto:[email protected]>> wrote:
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
No need to call the DPDK flavor explictly.
--- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5.c +1 -1
@@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, }/* Build device name. */ if (!switch_info->representor) -rte_strlcpy (name, dpdk_dev->name,sizeof (name)); +strlcpy (name, dpdk_dev->name,sizeof (name));else snprintf (name,sizeof (name),"%s_representor_%u" , dpdk_dev->name, switch_info->port_name);
--
2.20.1
--
regards,
Rami Rosen