Skip to contentSkip to conversation

dma: axi-dmac: don't check the number of frames for alignment

PATCH New Vinod Koul 1 participant 1 message Feb 25, 2019 dmaengine

lore
Share & tools
lore

Vinod Koul

author maintainer
#0 lore raw

PATCH 1/2 dma: axi-dmac: don't check the number of frames for alignment

Quoted 2 lines · Alexandru Ardelean

Fixes commit 0e3b67b348b8 ("dmaengine: Add support for the Analog Devices AXI-DMAC DMA controller")

Do you mean to add a Fixes tag?

Quoted 5 lines

For 2D transfers, there is no requirement for Y_LENGTH to be aligned to the bus-width (or anything). X_LENGTH is required to be aligned though.

So, we shouldn't check that the number of frames is aligned.

Does this fix a bug as indicated by Fixes tag?

Lastly, it is dmaengine: xxx not dma: xxx Please fix that.

Quoted 21 lines
---
 drivers/dma/dma-axi-dmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/dma-axi-dmac.c +1 -1
index ffc0adc2f6ce..2c999113b989 100644
@@ -485,7 +485,7 @@ static struct dma_async_tx_descriptor *axi_dmac_prep_interleaved(
 
 	if (chan->hw_2d) {
 		if (!axi_dmac_check_len(chan, xt->sgl[0].size) ||
-		    !axi_dmac_check_len(chan, xt->numf))
+		    xt->numf == 0)
 			return NULL;
 		if (xt->sgl[0].size + dst_icg > chan->max_length ||
 		    xt->sgl[0].size + src_icg > chan->max_length)
Signature · 1 line
2.17.1