Skip to contentSkip to conversation

drm & vgaarb: handle vgacon removal in vgaarb.

PATCH Superseded Gerd Hoffmann 5 participants 15 messages Feb 25, 2019 – Mar 1, 2019 1 message not in the archive

Subsystems (5)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Gerd Hoffmann

author maintainer
#0 lore raw

v6 cover drm & vgaarb: handle vgacon removal in vgaarb.

v6: buildfix.

Gerd Hoffmann (3):
drm: move i915_kick_out_vgacon to vgaarb drm/fb-helper: call vga_remove_vgacon automatically. drm/qxl: remove conflicting framebuffers earlier

 include/drm/drm_fb_helper.h     | 14 +++++++++---
 include/linux/vgaarb.h          |  2 ++
 drivers/gpu/drm/i915/i915_drv.c | 35 +-----------------------------
 drivers/gpu/drm/qxl/qxl_drv.c   |  5 ++++-
 drivers/gpu/vga/vgaarb.c        | 48 +++++++++++++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+), 38 deletions(-)
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author maintainer
#1 lore raw

PATCH v6 1/3 drm: move i915_kick_out_vgacon to vgaarb

Also rename it to vga_remove_vgacon and add kerneldoc text.

---
 include/linux/vgaarb.h          |  2 ++
 drivers/gpu/drm/i915/i915_drv.c | 35 +-----------------------------
 drivers/gpu/vga/vgaarb.c        | 48 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 51 insertions(+), 34 deletions(-)
include/linux/vgaarb.h +2 -0
index ee162e3e879b..553b34c8b5f7 100644
@@ -125,9 +125,11 @@ extern void vga_put(struct pci_dev *pdev, unsigned int rsrc);
 #ifdef CONFIG_VGA_ARB
 extern struct pci_dev *vga_default_device(void);
 extern void vga_set_default_device(struct pci_dev *pdev);
+extern int vga_remove_vgacon(struct pci_dev *pdev);
 #else
 static inline struct pci_dev *vga_default_device(void) { return NULL; };
 static inline void vga_set_default_device(struct pci_dev *pdev) { };
+static inline int vga_remove_vgacon(struct pci_dev *pdev) { return 0; };
 #endif
 
 /*
drivers/gpu/drm/i915/i915_drv.c +1 -34
index 6630212f2faf..9df65d386d11 100644
@@ -757,39 +757,6 @@ static int i915_kick_out_firmware_fb(struct drm_i915_private *dev_priv)
 	return ret;
 }
 
-#if !defined(CONFIG_VGA_CONSOLE)
-static int i915_kick_out_vgacon(struct drm_i915_private *dev_priv)
-{
-	return 0;
-}
-#elif !defined(CONFIG_DUMMY_CONSOLE)
-static int i915_kick_out_vgacon(struct drm_i915_private *dev_priv)
-{
-	return -ENODEV;
-}
-#else
-static int i915_kick_out_vgacon(struct drm_i915_private *dev_priv)
-{
-	int ret = 0;
-
-	DRM_INFO("Replacing VGA console driver\n");
-
-	console_lock();
-	if (con_is_bound(&vga_con))
-		ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);
-	if (ret == 0) {
-		ret = do_unregister_con_driver(&vga_con);
-
-		/* Ignore "already unregistered". */
-		if (ret == -ENODEV)
-			ret = 0;
-	}
-	console_unlock();
-
-	return ret;
-}
-#endif
-
 static void intel_init_dpio(struct drm_i915_private *dev_priv)
 {
 	/*
@@ -1420,7 +1387,7 @@ static int i915_driver_init_hw(struct drm_i915_private *dev_priv)
 		goto err_ggtt;
 	}
 
-	ret = i915_kick_out_vgacon(dev_priv);
+	ret = vga_remove_vgacon(pdev);
 	if (ret) {
 		DRM_ERROR("failed to remove conflicting VGA console\n");
 		goto err_ggtt;
drivers/gpu/vga/vgaarb.c +48 -0

60 lines not on this page · raw message

Signature · 1 line
2.9.3
author maintainer
#2 lore raw

PATCH v6 2/3 drm/fb-helper: call vga_remove_vgacon automatically.

In reply to Gerd Hoffmann

Add vga_remove_vgacon() call to drm_fb_helper_remove_conflicting_pci_framebuffers().

---
 include/drm/drm_fb_helper.h | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
include/drm/drm_fb_helper.h +11 -3
index bb9acea61369..286d58efed5d 100644
@@ -36,6 +36,7 @@ struct drm_fb_helper;
 #include <drm/drm_crtc.h>
 #include <drm/drm_device.h>
 #include <linux/kgdb.h>
+#include <linux/vgaarb.h>
 
 enum mode_set_atomic {
 	LEAVE_ATOMIC_MODE_SET,
@@ -642,11 +643,18 @@ drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev,
 						  int resource_id,
 						  const char *name)
 {
+	int ret = 0;
+
+	/*
+	 * WARNING: Apparently we must kick fbdev drivers before vgacon,
+	 * otherwise the vga fbdev driver falls over.
+	 */
 #if IS_REACHABLE(CONFIG_FB)
-	return remove_conflicting_pci_framebuffers(pdev, resource_id, name);
-#else
-	return 0;
+	ret = remove_conflicting_pci_framebuffers(pdev, resource_id, name);
 #endif
+	if (ret == 0)
+		ret = vga_remove_vgacon(pdev);
+	return ret;
 }
 
 #endif
Signature · 1 line
2.9.3
author maintainer
#3 lore raw

PATCH v6 3/3 drm/qxl: remove conflicting framebuffers earlier

In reply to Gerd Hoffmann

Add error checking while being at it.

---
 drivers/gpu/drm/qxl/qxl_drv.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_drv.c +4 -1
index bb81e310eb6d..578d867a81d5 100644
@@ -79,6 +79,10 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (ret)
 		goto free_dev;
 
+	ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl");
+	if (ret)
+		goto disable_pci;
+
 	ret = qxl_device_init(qdev, &qxl_driver, pdev);
 	if (ret)
 		goto disable_pci;
@@ -94,7 +98,6 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (ret)
 		goto modeset_cleanup;
 
-	drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl");
 	drm_fbdev_generic_setup(&qdev->ddev, 32);
 	return 0;
 
Signature · 1 line
2.9.3
author maintainer
#4 lore raw

PATCH v6 3/3 drm/qxl: remove conflicting framebuffers earlier

In reply to Gerd Hoffmann

Add error checking while being at it.

---
 drivers/gpu/drm/qxl/qxl_drv.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_drv.c +4 -1
index bb81e310eb6d..578d867a81d5 100644
@@ -79,6 +79,10 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (ret)
 		goto free_dev;
 
+	ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl");
+	if (ret)
+		goto disable_pci;
+
 	ret = qxl_device_init(qdev, &qxl_driver, pdev);
 	if (ret)
 		goto disable_pci;
@@ -94,7 +98,6 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (ret)
 		goto modeset_cleanup;
 
-	drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "qxl");
 	drm_fbdev_generic_setup(&qdev->ddev, 32);
 	return 0;
 
Signature · 1 line
2.9.3
#5 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm & vgaarb: handle vgacon removal in vgaarb. (rev2)

In reply to Gerd Hoffmann
== Series Details ==

== Series Details ==

Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev2)
URL : https://patchwork.freedesktop.org/series/57086/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bfa4e81d85e2 drm: move i915_kick_out_vgacon to vgaarb
-:94: ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: drivers/gpu/vga/vgaarb.c:186:
+        return 0;$

-:94: WARNING:LEADING_SPACE: please, no spaces at the start of a line #94: FILE: drivers/gpu/vga/vgaarb.c:186:
+ return 0;$

-:99: ERROR:CODE_INDENT: code indent should use tabs where possible #99: FILE: drivers/gpu/vga/vgaarb.c:191:
+ return -ENODEV;$

-:99: WARNING:LEADING_SPACE: please, no spaces at the start of a line #99: FILE: drivers/gpu/vga/vgaarb.c:191:
+ return -ENODEV;$

-:104: ERROR:CODE_INDENT: code indent should use tabs where possible #104: FILE: drivers/gpu/vga/vgaarb.c:196:
+ int ret = 0;$

-:104: WARNING:LEADING_SPACE: please, no spaces at the start of a line #104: FILE: drivers/gpu/vga/vgaarb.c:196:
+ int ret = 0;$

-:110: ERROR:CODE_INDENT: code indent should use tabs where possible #110: FILE: drivers/gpu/vga/vgaarb.c:202:
+ console_lock();$

-:110: WARNING:LEADING_SPACE: please, no spaces at the start of a line #110: FILE: drivers/gpu/vga/vgaarb.c:202:
+ console_lock();$

-:111: ERROR:CODE_INDENT: code indent should use tabs where possible #111: FILE: drivers/gpu/vga/vgaarb.c:203:
+ if (con_is_bound(&vga_con))$

-:111: WARNING:LEADING_SPACE: please, no spaces at the start of a line #111: FILE: drivers/gpu/vga/vgaarb.c:203:
+ if (con_is_bound(&vga_con))$

-:112: ERROR:CODE_INDENT: code indent should use tabs where possible #112: FILE: drivers/gpu/vga/vgaarb.c:204:
+ ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);$

-:112: WARNING:LEADING_SPACE: please, no spaces at the start of a line #112: FILE: drivers/gpu/vga/vgaarb.c:204:
+ ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);$

-:113: ERROR:CODE_INDENT: code indent should use tabs where possible #113: FILE: drivers/gpu/vga/vgaarb.c:205:
+ if (ret == 0) {$

-:113: WARNING:LEADING_SPACE: please, no spaces at the start of a line #113: FILE: drivers/gpu/vga/vgaarb.c:205:
+ if (ret == 0) {$

-:114: ERROR:CODE_INDENT: code indent should use tabs where possible #114: FILE: drivers/gpu/vga/vgaarb.c:206:
+ ret = do_unregister_con_driver(&vga_con);$

-:114: WARNING:LEADING_SPACE: please, no spaces at the start of a line #114: FILE: drivers/gpu/vga/vgaarb.c:206:
+ ret = do_unregister_con_driver(&vga_con);$

-:116: ERROR:CODE_INDENT: code indent should use tabs where possible #116: FILE: drivers/gpu/vga/vgaarb.c:208:
+ /* Ignore "already unregistered". */$

-:117: ERROR:CODE_INDENT: code indent should use tabs where possible #117: FILE: drivers/gpu/vga/vgaarb.c:209:
+ if (ret == -ENODEV)$

-:117: WARNING:LEADING_SPACE: please, no spaces at the start of a line #117: FILE: drivers/gpu/vga/vgaarb.c:209:
+ if (ret == -ENODEV)$

-:118: ERROR:CODE_INDENT: code indent should use tabs where possible #118: FILE: drivers/gpu/vga/vgaarb.c:210:
+ ret = 0;$

-:118: WARNING:LEADING_SPACE: please, no spaces at the start of a line #118: FILE: drivers/gpu/vga/vgaarb.c:210:
+ ret = 0;$

-:119: ERROR:CODE_INDENT: code indent should use tabs where possible #119: FILE: drivers/gpu/vga/vgaarb.c:211:
+ }$

-:119: WARNING:LEADING_SPACE: please, no spaces at the start of a line #119: FILE: drivers/gpu/vga/vgaarb.c:211:
+ }$

-:120: ERROR:CODE_INDENT: code indent should use tabs where possible #120: FILE: drivers/gpu/vga/vgaarb.c:212:
+ console_unlock();$

-:120: WARNING:LEADING_SPACE: please, no spaces at the start of a line #120: FILE: drivers/gpu/vga/vgaarb.c:212:
+ console_unlock();$

-:122: ERROR:CODE_INDENT: code indent should use tabs where possible #122: FILE: drivers/gpu/vga/vgaarb.c:214:
+ return ret;$

-:122: WARNING:LEADING_SPACE: please, no spaces at the start of a line #122: FILE: drivers/gpu/vga/vgaarb.c:214:
+ return ret;$

-:138: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #138: FILE: include/linux/vgaarb.h:128:
+extern int vga_remove_vgacon(struct pci_dev *pdev);

total: 14 errors, 13 warnings, 1 checks, 118 lines checked c0c659536670 drm/fb-helper: call vga_remove_vgacon automatically. 555ec02d6c8f drm/qxl: remove conflicting framebuffers earlier

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

✓ Fi.CI.BAT: success for drm & vgaarb: handle vgacon removal in vgaarb. (rev2)

In reply to Gerd Hoffmann
== Series Details ==

== Series Details ==

Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev2)
URL : https://patchwork.freedesktop.org/series/57086/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5657 -> Patchwork_12294
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/57086/revisions/2/mbox/

Known issues
------------

Here are the changes found in Patchwork_12294 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76

* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720]

* igt@kms_busy@basic-flip-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48

* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: WARN [fdo#109380] -> PASS

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#109485] -> PASS

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: SKIP [fdo#109271] -> PASS +33

* igt@prime_vgem@basic-fence-flip:
- fi-kbl-7500u: SKIP [fdo#109271] -> PASS +33

[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720

Participating hosts (40 -> 37)
------------------------------

Additional (1): fi-pnv-d510
Missing (4): fi-icl-y fi-ilk-m540 fi-byt-squawks fi-bsw-cyan

Build changes
-------------

* Linux: CI_DRM_5657 -> Patchwork_12294

CI_DRM_5657: 3dd976663b985375368c6229903a1c47971c2a71 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4853: 8afdfd8fa9ce17043d9105dedca46ad4555fdcdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12294: 555ec02d6c8f7e3780d5a190e5ec68a3e80cf3c4 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

555ec02d6c8f drm/qxl: remove conflicting framebuffers earlier c0c659536670 drm/fb-helper: call vga_remove_vgacon automatically. bfa4e81d85e2 drm: move i915_kick_out_vgacon to vgaarb

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12294/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.IGT: success for drm & vgaarb: handle vgacon removal in vgaarb. (rev2)

In reply to Gerd Hoffmann
== Series Details ==

== Series Details ==

Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev2)
URL : https://patchwork.freedesktop.org/series/57086/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5657_full -> Patchwork_12294_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_12294_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@extended-semaphore-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109275] / [fdo#109276]

* igt@gem_exec_big:
- shard-hsw: PASS -> TIMEOUT [fdo#107937]

* igt@gem_mocs_settings@mocs-settings-vebox:
- shard-iclb: NOTRUN -> SKIP [fdo#109287] +1

* igt@gem_pwrite@stolen-normal:
- shard-iclb: NOTRUN -> SKIP [fdo#109277]

* igt@i915_pm_rpm@basic-rte:
- shard-iclb: PASS -> INCOMPLETE [fdo#108840] / [fdo#108990]

* igt@i915_pm_rpm@dpms-lpsp:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724]

* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- shard-iclb: PASS -> INCOMPLETE [fdo#107713] / [fdo#108840]

* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_busy@extended-pageflip-hang-oldfb-render-d:
- shard-iclb: NOTRUN -> SKIP [fdo#109278]

* igt@kms_chamelium@hdmi-hpd:
- shard-iclb: NOTRUN -> SKIP [fdo#109284]

* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-iclb: NOTRUN -> FAIL [fdo#103232]

* igt@kms_fbcon_fbt@fbc:
- shard-iclb: PASS -> FAIL [fdo#103833] / [fdo#105681]

* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +1

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +7

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff:
- shard-iclb: PASS -> FAIL [fdo#103167]

* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-iclb: PASS -> FAIL [fdo#103166]

* igt@kms_psr@sprite_render:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +5

* igt@kms_sysfs_edid_timing:
- shard-iclb: PASS -> FAIL [fdo#100047]

* igt@perf@unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> SKIP [fdo#109289]

* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +3

* igt@prime_nv_pcopy@test2:
- shard-iclb: NOTRUN -> SKIP [fdo#109291]

#### Possible fixes ####

* igt@i915_pm_rpm@gem-execbuf-stress:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +6

* igt@i915_pm_rpm@sysfs-read:
- shard-iclb: INCOMPLETE [fdo#107713] / [fdo#108840] -> PASS

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS

* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS +1

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +3

* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-apl: FAIL [fdo#103166] -> PASS

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-iclb: INCOMPLETE [fdo#107713] -> PASS

* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-iclb: FAIL [fdo#103166] -> PASS

* igt@perf_pmu@rc6:
- shard-kbl: SKIP [fdo#109271] -> PASS

#### Warnings ####

* igt@i915_pm_backlight@fade_with_suspend:
- shard-iclb: FAIL [fdo#107847] -> DMESG-FAIL [fdo#107724] / [fdo#107847]

[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105681]: https://bugs.freedesktop.org/show_bug.cgi?id=105681
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#107937]: https://bugs.freedesktop.org/show_bug.cgi?id=107937
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108990]: https://bugs.freedesktop.org/show_bug.cgi?id=108990
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109275]: https://bugs.freedesktop.org/show_bug.cgi?id=109275
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109287]: https://bugs.freedesktop.org/show_bug.cgi?id=109287
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291

Participating hosts (7 -> 6)
------------------------------

Missing (1): shard-skl

Build changes
-------------

* Linux: CI_DRM_5657 -> Patchwork_12294

CI_DRM_5657: 3dd976663b985375368c6229903a1c47971c2a71 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4853: 8afdfd8fa9ce17043d9105dedca46ad4555fdcdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12294: 555ec02d6c8f7e3780d5a190e5ec68a3e80cf3c4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12294/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw

Adding intel-gfx and CI folks.

Quoted 4 lines · Gerd Hoffmann

Quick question on the Intel CI: How does it work? I've seen it sending mails. Does it report failures only, i.e. no news is good news? How long does it usually take to run the tests? Is waiting a day enough? Is there a website where I can see the test results?

It always reports, and result links also get dumped onto patchwork (in the series view). There's 2 main runs: BAT and IGT (first with more machines, 2nd with more tests). BAT should be there within a few hours at most, IGT sometimes takes 1 day when there's a big backlog.

-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw
Quoted 8 lines · Daniel Vetter

Adding intel-gfx and CI folks.

Quoted 4 lines · Gerd Hoffmann

Quick question on the Intel CI: How does it work? I've seen it sending mails. Does it report failures only, i.e. no news is good news? How long does it usually take to run the tests? Is waiting a day enough? Is there a website where I can see the test results?

Quoted 6 lines

It always reports, and result links also get dumped onto patchwork (in the series view). There's 2 main runs: BAT and IGT (first with more machines, 2nd with more tests). BAT should be there within a few hours at most, IGT sometimes takes 1 day when there's a big backlog.

-Daniel

Hey,

We try to explain our CI here: https://intel-gfx-ci.01.org/

By the questions you have asked I already see that we should add information on the results being sent out for successes too and give some time estimations.

If you see anything elase missing and/or have suggestions on how to improve what is already there it would be greatly appreciated :-)

Signature · 6 lines
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author maintainer
#11 lore raw
Quoted 16 lines · Arkadiusz Hiler
Quoted 8 lines · Daniel Vetter

Adding intel-gfx and CI folks.

Quoted 4 lines · Gerd Hoffmann

Quick question on the Intel CI: How does it work? I've seen it sending mails. Does it report failures only, i.e. no news is good news? How long does it usually take to run the tests? Is waiting a day enough? Is there a website where I can see the test results?

Quoted 6 lines

It always reports, and result links also get dumped onto patchwork (in the series view). There's 2 main runs: BAT and IGT (first with more machines, 2nd with more tests). BAT should be there within a few hours at most, IGT sometimes takes 1 day when there's a big backlog.

-Daniel

Quoted 7 lines

Hey,

We try to explain our CI here: https://intel-gfx-ci.01.org/

By the questions you have asked I already see that we should add information on the results being sent out for successes too and give some time estimations.

Hmm, I see the test results in patchwork, but I can't remember having seen a mail. So the next question: where the results are sent to?

cheers,
Gerd

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

HI,

Quoted 29 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Gerd Hoffmann
Sent: torstai 28. helmikuuta 2019 15.28
To: Hiler, Arkadiusz <[email protected]>
Cc: Sarvela, Tomi P <[email protected]>; intel-gfx <intel- [email protected]>
Subject: Re: [Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in vgaarb.

Quoted 18 lines · Arkadiusz Hiler
Quoted 8 lines · Daniel Vetter

Adding intel-gfx and CI folks.

Quoted 4 lines · Gerd Hoffmann

Quick question on the Intel CI: How does it work? I've seen it sending mails. Does it report failures only, i.e. no news is good news? How long does it usually take to run the tests? Is waiting a day enough? Is there a website where I can see the test results?

Quoted 6 lines

It always reports, and result links also get dumped onto patchwork (in the series view). There's 2 main runs: BAT and IGT (first with more machines, 2nd with more tests). BAT should be there within a few hours at most, IGT sometimes takes 1 day when there's a big backlog.

-Daniel

Hey,

Quoted 8 lines
Quoted 5 lines

We try to explain our CI here: https://intel-gfx-ci.01.org/

By the questions you have asked I already see that we should add information on the results being sent out for successes too and give some time estimations.

Hmm, I see the test results in patchwork, but I can't remember having seen a mail. So the next question: where the results are sent to?

From page above sent by Arek:
" Since we accept patches through mailing lists, this is where you can find the results - they are sent out as a replies to the original mail. Here are the mailing lists we currently support:"

Quoted 3 lines

cheers,
Gerd

Br,
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Quoted 5 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#13 lore raw

Hi,

Quoted 6 lines
Quoted 2 lines

Hmm, I see the test results in patchwork, but I can't remember having seen a mail. So the next question: where the results are sent to?

From page above sent by Arek:
" Since we accept patches through mailing lists, this is where you can find the results - they are sent out as a replies to the original mail. Here are the mailing lists we currently support:"

Hmm, I'm not subscribed to intel-gfx, so that explains why I havn't seen the result mails. Any chance to sent the results also to the patch submitter?

thanks,
Gerd

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw

Hi,

Quoted 13 lines

-----Original Message-----
From: Gerd Hoffmann [mailto:[email protected]]
Sent: perjantai 1. maaliskuuta 2019 8.12
To: Saarinen, Jani <[email protected]>
Cc: Hiler, Arkadiusz <[email protected]>; Sarvela, Tomi P <[email protected]>; intel-gfx <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in vgaarb.

Hi,

Quoted 1 line
Quoted 1 line

Hmm, I see the test results in patchwork, but I can't remember having seen a

mail.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

So the next question: where the results are sent to?

From page above sent by Arek:
" Since we accept patches through mailing lists, this is where you can find the results - they are sent out as a replies to the original mail. Here are the mailing lists we currently support:"

Hmm, I'm not subscribed to intel-gfx, so that explains why I havn't seen the result mails. Any chance to sent the results also to the patch submitter?

It patches are sent to mailing list(s) (intel-gfx, trybot or igt-dev) and patches apply or not cleanly to latest drm-tip then results are sent both to developer and list as cc. Arek, Tomi, any other comments?

Quoted 3 lines

thanks,
Gerd

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw
In reply to Gerd Hoffmann
Quoted 4 lines · Gerd Hoffmann

Hi,

Quoted 2 lines
Quoted 2 lines

Hmm, I see the test results in patchwork, but I can't remember having seen a mail. So the next question: where the results are sent to?

Quoted 8 lines
Quoted 4 lines

From page above sent by Arek:
" Since we accept patches through mailing lists, this is where you can find the results - they are sent out as a replies to the original mail. Here are the mailing lists we currently support:"

Hmm, I'm not subscribed to intel-gfx, so that explains why I havn't seen the result mails. Any chance to sent the results also to the patch submitter?

Yes, this is the case now. I re-enabled sending the result emails to the authors just yesterday.

We had it like that since forever, but recently there was an change to fdo mailing lists which was overwritting "From" headers to workaround some delivery issues, so this feature had to be temporaily disabled.

Sorry for the incovenience.

Signature · 6 lines
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx