phy: tegra: xusb: t210: add XUSB device mode support

Quoted 10 lines · Nagarjuna Kristam

Quoted 10 lines

Review

Quoted 8 lines

EXPORT_SYMBOL_GPL(tegra_xusb_padctl_usb3_set_lfps_detect);

(quoted diff) +6 -0

+int tegra_xusb_padctl_set_vbus_override(struct tegra_xusb_padctl *padctl)
+{
+	if (padctl->soc->ops->vbus_override)
+		return padctl->soc->ops->vbus_override(padctl, true);
+
+	return -EINVAL;

It'd be best to stick to the -ENOSYS error code here.

Quoted 2 lines

will do

Using ENOSYS is marked as checkpatch warning
WARNING: ENOSYS means 'invalid syscall nr' and nothing else

I suggest to use ENOTSUP instead of EINVAL/ENOSYS.