Skip to contentSkip to conversation

python-idna: Avoid removing '+x' from `.egg-info/` directory

PATCH In review Otavio Salvador 5 participants 11 messages Feb 25, 2019 – Mar 6, 2019 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 python-idna: Avoid removing '+x' from `.egg-info/` directory

The chmod was removing the executing bit from the directory and then the native version was failing to build.

---

 meta-python/recipes-devtools/python/python-idna.inc | 4 ----
 1 file changed, 4 deletions(-)
meta-python/recipes-devtools/python/python-idna.inc +0 -4
index 436b58606..519812ddc 100644
@@ -16,7 +16,3 @@ do_compile_prepend() {
 }
 
 BBCLASSEXTEND = "native nativesdk"
-
-do_install_append() {
-    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
-}
\ No newline at end of file
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 python-idna: Upgrade 2.7 -> 2.8

---

 meta-python/recipes-devtools/python/python-idna.inc           | 4 ++--
 .../python/{python-idna_2.7.bb => python-idna_2.8.bb}         | 0
 .../python/{python3-idna_2.7.bb => python3-idna_2.8.bb}       | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename meta-python/recipes-devtools/python/{python-idna_2.7.bb => python-idna_2.8.bb} (100%)
 rename meta-python/recipes-devtools/python/{python3-idna_2.7.bb => python3-idna_2.8.bb} (100%)
meta-python/recipes-devtools/python/python-idna.inc +2 -2
index 519812ddc..13b0cdb62 100644
@@ -3,8 +3,8 @@ HOMEPAGE = "https://github.com/kjd/idna"
 LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
 LIC_FILES_CHKSUM = "file://LICENSE.rst;md5=782775b32f96098512e283fb5d4546cd"
 
-SRC_URI[md5sum] = "0e5bb69018ddef1b9d95f681182be82c"
-SRC_URI[sha256sum] = "684a38a6f903c1d71d6d5fac066b58d7768af4de2b832e426ec79c30daa94a16"
+SRC_URI[md5sum] = "2e9ae0b4a0b26d1747c6127cdb060bc1"
+SRC_URI[sha256sum] = "c357b3f628cf53ae2c4c05627ecc484553142ca23264e593d327bcde5e9c3407"
 
 RDEPENDS_${PN}_class-target = "\
     ${PYTHON_PN}-codecs \
meta-python/recipes-devtools/python/python-idna_2.8.bb renamed from meta-python/recipes-devtools/python/python-idna_2.7.bb +0 -0
similarity index 100%
rename from meta-python/recipes-devtools/python/python-idna_2.7.bb
rename to meta-python/recipes-devtools/python/python-idna_2.8.bb
meta-python/recipes-devtools/python/python3-idna_2.8.bb renamed from meta-python/recipes-devtools/python/python3-idna_2.7.bb +0 -0
similarity index 100%
rename from meta-python/recipes-devtools/python/python3-idna_2.7.bb
rename to meta-python/recipes-devtools/python/python3-idna_2.8.bb
Signature · 1 line
2.20.1
#2 lore raw
In reply to Otavio Salvador
Quoted 15 lines · Otavio Salvador

The chmod was removing the executing bit from the directory and then the native version was failing to build.

---

 meta-python/recipes-devtools/python/python-idna.inc | 4 ----
 1 file changed, 4 deletions(-)
meta-python/recipes-devtools/python/python-idna.inc +0 -0
index 436b58606..519812ddc 100644

meta-python/recipes-devtools/python/python-idna.inc do_compile_prepend() { · line 22

Quoted 7 lines
meta-python/recipes-devtools/python/python-idna.inc +0 -4
@@ -16,7 +16,3 @@ do_compile_prepend() {
 }
 
 BBCLASSEXTEND = "native nativesdk"
-
-do_install_append() {
-    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
-}

this overturns a prior fix
https://git.openembedded.org/meta-openembedded/commit/?id=79bb01985260800f80b393e73b387543f86f9e62

I think it would be better to resolve the original issue before reverting it or maybe just appy this for target recipe alone

Quoted 9 lines

\ No newline at end of file
--
2.20.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw

The original patch doesn't explain what it's doing and is clearly going to remove executable bits from directories, which clearly isn't right.

I'd say remove it, and *then* if it breaks again fix properly.

Ross

Quoted 45 lines · Khem Raj
Quoted 15 lines · Otavio Salvador

The chmod was removing the executing bit from the directory and then the native version was failing to build.

---

 meta-python/recipes-devtools/python/python-idna.inc | 4 ----
 1 file changed, 4 deletions(-)
meta-python/recipes-devtools/python/python-idna.inc +0 -0
index 436b58606..519812ddc 100644

meta-python/recipes-devtools/python/python-idna.inc do_compile_prepend() { · line 22

Quoted 7 lines
meta-python/recipes-devtools/python/python-idna.inc +0 -4
@@ -16,7 +16,3 @@ do_compile_prepend() {
 }
 
 BBCLASSEXTEND = "native nativesdk"
-
-do_install_append() {
-    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
-}

this overturns a prior fix
https://git.openembedded.org/meta-openembedded/commit/?id=79bb01985260800f80b393e73b387543f86f9e62

I think it would be better to resolve the original issue before reverting it or maybe just appy this for target recipe alone

Quoted 9 lines

\ No newline at end of file
--
2.20.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 6 lines · Ross

The original patch doesn't explain what it's doing and is clearly going to remove executable bits from directories, which clearly isn't right.

I'd say remove it, and *then* if it breaks again fix properly.

I am with Ross here. It is a really ugly patch and if need, we need a comment on the code and a proper reason to add it back.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#5 lore raw
Quoted 12 lines · Otavio Salvador
Quoted 6 lines · Ross

The original patch doesn't explain what it's doing and is clearly going to remove executable bits from directories, which clearly isn't right.

I'd say remove it, and *then* if it breaks again fix properly.

I am with Ross here. It is a really ugly patch and if need, we need a comment on the code and a proper reason to add it back.

+Maxime for information on the original patch

#6 lore raw

Otavio

Can you resend this patch series, its missing in patchwork, so hopefully, it will catch it this time.

Quoted 17 lines · Khem Raj
Quoted 12 lines · Otavio Salvador
Quoted 6 lines · Ross

The original patch doesn't explain what it's doing and is clearly going to remove executable bits from directories, which clearly isn't right.

I'd say remove it, and *then* if it breaks again fix properly.

I am with Ross here. It is a really ugly patch and if need, we need a comment on the code and a proper reason to add it back.

+Maxime for information on the original patch

#7 lore raw
Quoted 2 lines · Khem Raj

Can you resend this patch series, its missing in patchwork, so hopefully, it will catch it this time.

Resent.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#8 lore raw
Quoted 7 lines · Otavio Salvador
Quoted 2 lines · Khem Raj

Can you resend this patch series, its missing in patchwork, so hopefully, it will catch it this time.

It might be the ‘+x’ in the subject line. I’ve seen other patches with “non-standard” characters be missed...

Quoted 12 lines

Resent.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#9 lore raw
Quoted 5 lines · Tim Orling
Quoted 1 line · Otavio Salvador
Quoted 9 lines
Quoted 6 lines · Khem Raj
Quoted 2 lines

Can you resend this patch series, its missing in patchwork, so hopefully, it will catch it this time.

It might be the ‘+x’ in the subject line. I’ve seen other patches with “non-standard” characters be missed...

it still is missing. Maybe just send a github pull.

Quoted 12 lines
Quoted 12 lines

Resent.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

A message that is not in the archive (sent off-list or not yet received): [email protected]

#11 lore raw

Hi Maxime,

I think we need to understand it a bit better, eg. should we need to change the mode for directories or just files. I Think it deserves a new patch, I am going to apply Otavio's patch and then you can try if that does not work then lets fix it by changing perms for files.

Quoted 33 lines · Maxime BORGES

For reference:

https://github.com/openembedded/meta-openembedded/pull/92#issue-216348464

------------------------------------------------------------------------
*De :* Khem Raj <[email protected]>
*Envoyé :* vendredi 1 mars 2019 16:56:31
*À :* Otavio Salvador; Maxime BORGES
*Cc :* Burton, Ross; Otavio Salvador; Meta-OpenEmbedded Mailing listing
*Objet :* Re: [oe] [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from .egg-info/ directory Otavio

Can you resend this patch series, its missing in patchwork, so hopefully, it will catch it this time.

Quoted 17 lines · Khem Raj
Quoted 12 lines · Otavio Salvador
Quoted 6 lines · Ross

The original patch doesn't explain what it's doing and is clearly going to remove executable bits from directories, which clearly isn't right.

I'd say remove it, and *then* if it breaks again fix properly.

I am with Ross here. It is a really ugly patch and if need, we need a comment on the code and a proper reason to add it back.

+Maxime for information on the original patch