iotests: use -M accel=qtest in 238
PATCH v3 1/1 iotests: use -M accel=qtest in 238
Test 238 does not require the kvm accelerator. tcg and qtest work too.
Use qtest since it's always built in while kvm and tcg are not.
--- tests/qemu-iotests/238 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qemu-iotests/238 +1 -1
@@ -33,7 +33,7 @@ else: virtio_scsi_device = 'virtio-scsi-pci' vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm') +vm.add_args('-machine', 'accel=qtest') vm.launch() log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
Signature · 1 line
2.20.1
Quoted 16 lines · Stefan Hajnoczi
Test 238 does not require the kvm accelerator. tcg and qtest work too.
Use qtest since it's always built in while kvm and tcg are not.
Suggested-by Thomas Huth <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>--- tests/qemu-iotests/238 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qemu-iotests/238 +0
-0
tests/qemu-iotests/238 else: · line 39
Quoted 8 lines
tests/qemu-iotests/238 +1
-1@@ -33,7 +33,7 @@ else: virtio_scsi_device = 'virtio-scsi-pci' vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm') +vm.add_args('-machine', 'accel=qtest') vm.launch() log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
Am 25.02.2019 um 17:18 hat Stefan Hajnoczi geschrieben:
Quoted 15 lines
Test 238 does not require the kvm accelerator. tcg and qtest work too.
Use qtest since it's always built in while kvm and tcg are not.
Suggested-by Thomas Huth <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>--- tests/qemu-iotests/238 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qemu-iotests/238 +0
-0
tests/qemu-iotests/238 else: · line 37
Quoted 6 lines
tests/qemu-iotests/238 +1
-1@@ -33,7 +33,7 @@ else: virtio_scsi_device = 'virtio-scsi-pci' vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm') +vm.add_args('-machine', 'accel=qtest') vm.launch()
Why not use iotests.VM? This would be a qtest machine automatically.
Kevin
Quoted 18 lines · Kevin Wolf
Am 25.02.2019 um 17:18 hat Stefan Hajnoczi geschrieben:
Quoted 17 lines
Test 238 does not require the kvm accelerator. tcg and qtest work too.
Use qtest since it's always built in while kvm and tcg are not.
Suggested-by Thomas Huth <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>--- tests/qemu-iotests/238 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/qemu-iotests/238 +0
-0@@ -33,7 +33,7 @@ else: virtio_scsi_device = 'virtio-scsi-pci'
Quoted 6 lines
tests/qemu-iotests/238 else: · line 37
Quoted 4 lines
tests/qemu-iotests/238 +1
-1vm = QEMUMachine(iotests.qemu_prog) -vm.add_args('-machine', 'accel=kvm') +vm.add_args('-machine', 'accel=qtest') vm.launch()Why not use iotests.VM? This would be a qtest machine automatically.
Good idea, will fix in v4.
Stefan