Staging: vt6655: Fix check - Lines should not end with a '('
PATCH 1/1 Staging: vt6655: Fix check - Lines should not end with a '('
Improve readibility
--- drivers/staging/vt6655/card.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/staging/vt6655/card.c +5 -6
@@ -62,12 +62,11 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {static void -s_vCalculateOFDMRParameter ( -unsigned char byRate, -u8 bb_type, -unsigned char *pbyTxRate, -unsigned char *pbyRsvTime -); +s_vCalculateOFDMRParameter + (unsigned char byRate, +u8 bb_type, +unsigned char *pbyTxRate, +unsigned char *pbyRsvTime);/*--------------------- Export Functions --------------------------*/
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 16 lines · Madhumitha Prabakaran
Improve readibility
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vt6655/card.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)drivers/staging/vt6655/card.c +0
-1@@ -62,12 +62,11 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {static void -s_vCalculateOFDMRParameter(
drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 69
Quoted 10 lines
drivers/staging/vt6655/card.c +5
-5-unsigned char byRate, - u8 bb_type, - unsigned char *pbyTxRate, - unsigned char *pbyRsvTime -); +s_vCalculateOFDMRParameter + (unsigned char byRate, + u8 bb_type, + unsigned char *pbyTxRate, + unsigned char *pbyRsvTime);
There's so much wrong with these few lines to start with, you can make this look a lot better all at once.
How about this change instead:
static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
unsigned char *pbyTxRate, unsigned char *pbyRsvTime);
Isn't that much more readable over the initial, and even your change?
thanks,
greg k-h
Quoted 34 lines · Greg KH
Quoted 16 lines · Madhumitha Prabakaran
Improve readibility
Signed-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vt6655/card.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)drivers/staging/vt6655/card.c +0
-1@@ -62,12 +62,11 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {static void -s_vCalculateOFDMRParameter(drivers/staging/vt6655/card.c static const unsigned short cwRXBCNTSFOff[MAX_RATE] = { · line 69
Quoted 10 lines
drivers/staging/vt6655/card.c +5
-5-unsigned char byRate, - u8 bb_type, - unsigned char *pbyTxRate, - unsigned char *pbyRsvTime -); +s_vCalculateOFDMRParameter + (unsigned char byRate, + u8 bb_type, + unsigned char *pbyTxRate, + unsigned char *pbyRsvTime);There's so much wrong with these few lines to start with, you can make this look a lot better all at once.
How about this change instead:
static void s_vCalculateOFDMRParameter(unsigned char byRate, u8
bb_type,
Quoted 8 lines
unsigned char *pbyTxRate, unsigned char *pbyRsvTime);Isn't that much more readable over the initial, and even your change?
thanks,
greg k-h
I will update and send it
Madhumitha