misc fixes for 2019.02
cover misc fixes for 2019.02
From: Thomas De Schampheleire <[email protected]>
Hello,
These are two unrelated fixes for 2019.02.
Neither of them is really critical:
- the meson change is not a real problem for most people. It is a problem for me because of a custom change we have where HOST_DIR is made read-only after the first full build, so that subsequent makes can only touch TARGET_DIR.
- the iproute2 fix is only relevant if you have an old toolchain with glibc older than 2.18. I have this case with the Marvell/Cavium Octeon toolchain (glibc 2.16).
But, they do fix issues for me, hence the 'for-master' suffix. You are of course free to decide otherwise.
Best regards,
Thomas
Thomas De Schampheleire (2):
package/meson: don't install cross-compilation.conf during
target-finalize
package/iproute2: backport patch to fix compilation under glibc < 2.18
...-ss-fix-compilation-under-glibc-2.18.patch | 39 +++++++++++++++++++ package/meson/meson.mk | 3 +- 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 package/iproute2/0002-ss-fix-compilation-under-glibc-2.18.patch
Signature · 1 line
2.19.2
PATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
From: Thomas De Schampheleire <[email protected]>
package/meson installs a cross-compilation.conf file in $(HOST_DIR)/etc/meson, via TARGET_FINALIZE_HOOKS.
package/pkg-cmake.mk installs a toolchainfile.cmake in $(HOST_DIR)/share/buildroot, via TOOLCHAIN_POST_INSTALL_STAGING_HOOKS.
Both files have a similar concept, they describe some flags/paths needed for compilation using respective build systems. One difference is that the meson file is added for external compilation, from the SDK, while the cmake file is used internally in Buildroot.
The 'problem' of using TARGET_FINALIZE_HOOKS for the meson file, is that it installs a 'host' file from target-finalize, which is conceptually incorrect and breaks the invariant that only TARGET_DIR is changed on a subsequent 'make' when everything was already built (i.e. only target-finalize is run).
This can easily be fixed, by using the same hook as cmake uses, i.e. TOOLCHAIN_POST_INSTALL_STAGING_HOOKS.
Note that actually even for cmake, TOOLCHAIN_POST_INSTALL_STAGING_HOOKS is not the best hook to install a host file. A better hook would have been TOOLCHAIN_POST_INSTALL_HOOKS, but this triggers only for 'host' packages, and 'toolchain' is treated as a 'target' package.
--- package/meson/meson.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/meson/meson.mk +2 -1
@@ -65,6 +65,7 @@ define HOST_MESON_INSTALL_CROSS_CONF > $(HOST_DIR)/etc/meson/cross-compilation.conf endef -TARGET_FINALIZE_HOOKS += HOST_MESON_INSTALL_CROSS_CONF +TOOLCHAIN_POST_INSTALL_STAGING_HOOKS += HOST_MESON_INSTALL_CROSS_CONF +TOOLCHAIN_INSTALL_STAGING = YES $(eval $(host-python-package))
Signature · 1 line
2.19.2
PATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
Quoted 40 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> package/meson installs a cross-compilation.conf file in $(HOST_DIR)/etc/meson, via
TARGET_FINALIZE_HOOKS.
package/pkg-cmake.mkinstalls a toolchainfile.cmake in $(HOST_DIR)/share/buildroot, viaTOOLCHAIN_POST_INSTALL_STAGING_HOOKS.Both files have a similar concept, they describe some flags/paths needed for compilation using respective build systems. One difference is that the meson file is added for external compilation, from the SDK, while the cmake file is used internally in Buildroot.
The 'problem' of using
TARGET_FINALIZE_HOOKSfor the meson file, is that it installs a 'host' file from target-finalize, which is conceptually incorrect and breaks the invariant that onlyTARGET_DIRis changed on a subsequent 'make' when everything was already built (i.e. only target-finalize is run).This can easily be fixed, by using the same hook as cmake uses, i.e.
TOOLCHAIN_POST_INSTALL_STAGING_HOOKS.Note that actually even for cmake,
TOOLCHAIN_POST_INSTALL_STAGING_HOOKSis not the best hook to install a host file. A better hook would have beenTOOLCHAIN_POST_INSTALL_HOOKS, but this triggers only for 'host' packages, and 'toolchain' is treated as a 'target' package.Signed-off-by Thomas De Schampheleire <[email protected]>--- package/meson/meson.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/meson/meson.mk +0
-0@@ -65,6 +65,7 @@ define HOST_MESON_INSTALL_CROSS_CONFQuoted 1 line
$(HOST_DIR)/etc/meson/cross-compilation.conf
endef
package/meson/meson.mk define HOST_MESON_INSTALL_CROSS_CONF · line 68
Quoted 2 lines
package/meson/meson.mk +1
-1-TARGET_FINALIZE_HOOKS += HOST_MESON_INSTALL_CROSS_CONF +TOOLCHAIN_POST_INSTALL_STAGING_HOOKS += HOST_MESON_INSTALL_CROSS_CONF
Is this then going to use the correct (final) paths for per-package build directories?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
El mar., 26 feb. 2019 a las 19:52, Peter Korsgaard (<[email protected]>) escribi?:
Quoted 38 lines
Quoted 38 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> package/meson installs a cross-compilation.conf file in $(HOST_DIR)/etc/meson, via
TARGET_FINALIZE_HOOKS.
package/pkg-cmake.mkinstalls a toolchainfile.cmake in $(HOST_DIR)/share/buildroot, viaTOOLCHAIN_POST_INSTALL_STAGING_HOOKS.Both files have a similar concept, they describe some flags/paths needed for compilation using respective build systems. One difference is that the meson file is added for external compilation, from the SDK, while the cmake file is used internally in Buildroot.
The 'problem' of using
TARGET_FINALIZE_HOOKSfor the meson file, is that it installs a 'host' file from target-finalize, which is conceptually incorrect and breaks the invariant that onlyTARGET_DIRis changed on a subsequent 'make' when everything was already built (i.e. only target-finalize is run).This can easily be fixed, by using the same hook as cmake uses, i.e.
TOOLCHAIN_POST_INSTALL_STAGING_HOOKS.Note that actually even for cmake,
TOOLCHAIN_POST_INSTALL_STAGING_HOOKSis not the best hook to install a host file. A better hook would have beenTOOLCHAIN_POST_INSTALL_HOOKS, but this triggers only for 'host' packages, and 'toolchain' is treated as a 'target' package.Signed-off-by Thomas De Schampheleire <[email protected]>--- package/meson/meson.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/meson/meson.mk +0
-0@@ -65,6 +65,7 @@ define HOST_MESON_INSTALL_CROSS_CONF
Quoted 9 lines
package/meson/meson.mk define HOST_MESON_INSTALL_CROSS_CONF · line 68
Quoted 5 lines
Quoted 1 line
$(HOST_DIR)/etc/meson/cross-compilation.conf
endef
package/meson/meson.mk +1
-1-TARGET_FINALIZE_HOOKS += HOST_MESON_INSTALL_CROSS_CONF +TOOLCHAIN_POST_INSTALL_STAGING_HOOKS += HOST_MESON_INSTALL_CROSS_CONFIs this then going to use the correct (final) paths for per-package build directories?
I haven't played with / investigated the per-package feature yet, so I may miss some specifics.
Below is the content of the hook:
define HOST_MESON_INSTALL_CROSS_CONF
mkdir -p $(HOST_DIR)/etc/meson
sed -e "s%@TARGET_CROSS@%$(TARGET_CROSS)%g" \
-e "s%@TARGET_ARCH@%$(HOST_MESON_TARGET_CPU_FAMILY)%g" \
-e "s%@TARGET_CPU@%$(HOST_MESON_TARGET_CPU)%g" \
-e "s%@TARGET_ENDIAN@%$(HOST_MESON_TARGET_ENDIAN)%g" \
-e "s%@TARGET_CFLAGS@%$(HOST_MESON_SED_CFLAGS)%g" \
-e "s%@TARGET_LDFLAGS@%$(HOST_MESON_SED_LDFLAGS)%g" \
-e "s%@TARGET_CXXFLAGS@%$(HOST_MESON_SED_CXXFLAGS)%g" \
-e "s%@HOST_DIR@%$(HOST_DIR)%g" \
$(HOST_MESON_PKGDIR)/cross-compilation.conf.in \
> $(HOST_DIR)/etc/meson/cross-compilation.confendef
Are there any variables in there that would change value?
In sequential build, the file before and after this change is identical.
Best regards,
Thomas
PATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
Hello,
Quoted 5 lines · On Tue, 26 Feb 2019 20:48:49 +0100 Thomas De Schampheleire…
I haven't played with / investigated the per-package feature yet, so I may miss some specifics.
Below is the content of the hook:define
HOST_MESON_INSTALL_CROSS_CONF
Quoted 9 lines
mkdir -p $(HOST_DIR)/etc/meson
sed -e "s%@TARGET_CROSS@%$(TARGET_CROSS)%g" \
-e "s%@TARGET_ARCH@%$(HOST_MESON_TARGET_CPU_FAMILY)%g" \
-e "s%@TARGET_CPU@%$(HOST_MESON_TARGET_CPU)%g" \
-e "s%@TARGET_ENDIAN@%$(HOST_MESON_TARGET_ENDIAN)%g" \
-e "s%@TARGET_CFLAGS@%$(HOST_MESON_SED_CFLAGS)%g" \
-e "s%@TARGET_LDFLAGS@%$(HOST_MESON_SED_LDFLAGS)%g" \
-e "s%@TARGET_CXXFLAGS@%$(HOST_MESON_SED_CXXFLAGS)%g" \
-e "s%@HOST_DIR@%$(HOST_DIR)%g" \With per-package enabled, this $(HOST_DIR) here will point to the per-package host directory of host-meson instead of pointing to the global host directory.
Quoted 2 lines
$(HOST_MESON_PKGDIR)/cross-compilation.conf.in \
> $(HOST_DIR)/etc/meson/cross-compilation.conf Here as well, but this one is not an issue: the per-package host directory of host-meson will be rsync'ed into the global host directory at the end of the build.
Quoted 1 line
Are there any variables in there that would change value?
With per-package enabled, HOST_DIR, STAGING_DIR and TARGET_DIR have a different value when building each package (they point to the current package per-package directories) or when building stuff outside of a package (they point to the global directories).
Quoted 1 line
In sequential build, the file before and after this change is identical.
It's not so much sequential vs. parallel, but per-package directories or not. Per-package directory can be used while doing a sequential build.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
El mi?., 27 feb. 2019 a las 18:18, Thomas Petazzoni (<[email protected]>) escribi?:
Quoted 39 lines
Hello,
Quoted 5 lines · On Tue, 26 Feb 2019 20:48:49 +0100 Thomas De Schampheleire…
I haven't played with / investigated the per-package feature yet, so I may miss some specifics.
Below is the content of the hook:define
HOST_MESON_INSTALL_CROSS_CONFQuoted 9 lines
mkdir -p $(HOST_DIR)/etc/meson sed -e "s%@TARGET_CROSS@%$(TARGET_CROSS)%g" \ -e "s%@TARGET_ARCH@%$(HOST_MESON_TARGET_CPU_FAMILY)%g" \ -e "s%@TARGET_CPU@%$(HOST_MESON_TARGET_CPU)%g" \ -e "s%@TARGET_ENDIAN@%$(HOST_MESON_TARGET_ENDIAN)%g" \ -e "s%@TARGET_CFLAGS@%$(HOST_MESON_SED_CFLAGS)%g" \ -e "s%@TARGET_LDFLAGS@%$(HOST_MESON_SED_LDFLAGS)%g" \ -e "s%@TARGET_CXXFLAGS@%$(HOST_MESON_SED_CXXFLAGS)%g" \ -e "s%@HOST_DIR@%$(HOST_DIR)%g" \With per-package enabled, this $(HOST_DIR) here will point to the per-package host directory of host-meson instead of pointing to the global host directory.
Quoted 2 lines
$(HOST_MESON_PKGDIR)/cross-compilation.conf.in \ > $(HOST_DIR)/etc/meson/cross-compilation.confHere as well, but this one is not an issue: the per-package host directory of host-meson will be rsync'ed into the global host directory at the end of the build.
Quoted 1 line
Are there any variables in there that would change value?
With per-package enabled,
HOST_DIR,STAGING_DIRandTARGET_DIRhave a different value when building each package (they point to the current package per-package directories) or when building stuff outside of a package (they point to the global directories).
Quoted 6 lines
Quoted 1 line
In sequential build, the file before and after this change is identical.
It's not so much sequential vs. parallel, but per-package directories or not. Per-package directory can be used while doing a sequential build.
Thanks for explaining everything.
If I understand it correctly, since the patch is hooking into TOOLCHAIN_POST_INSTALL_STAGING_HOOKS, HOST_DIR will be the per-package directory of 'toolchain', not of 'host-meson', right?
To solve it, we could change:
- -e "s%@HOST_DIR@%$(HOST_DIR)%g" \
+ -e "s%@HOST_DIR@%$(call qstrip,$(BR2_HOST_DIR))%g" \
Is that correct?
And do you consider this acceptable?
Thanks,
Thomas
PATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
In reply to Thomas De SchampheleireHello,
Quoted 9 lines · On Mon, 25 Feb 2019 22:11:46 +0100 Thomas De Schampheleire…
Both files have a similar concept, they describe some flags/paths needed for compilation using respective build systems. One difference is that the meson file is added for external compilation, from the SDK, while the cmake file is used internally in Buildroot.
The 'problem' of using
TARGET_FINALIZE_HOOKSfor the meson file, is that it installs a 'host' file from target-finalize, which is conceptually incorrect and breaks the invariant that onlyTARGET_DIRis changed on a subsequent 'make' when everything was already built (i.e. only target-finalize is run).
In fact, I don't quite get what this commit is fixing. I don't really understand what you call the "invariant that only TARGET_DIR is changed on a subsequent make when everything was already built".
The current situation is not ideal because we create a file in $(HOST_DIR) from target-finalize, but the proposed situation is also not ideal because we create a file in $(HOST_DIR) from the staging installation of a package. So I'd need to understand why the second option has some advantages over the first, and that is currently unclear.
Is it just for consistency for how the corresponding cmake file is created ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
El dom., 17 mar. 2019 a las 16:23, Thomas Petazzoni (<[email protected]>) escribi?:
Quoted 19 lines
Hello,
Quoted 9 lines · On Mon, 25 Feb 2019 22:11:46 +0100 Thomas De Schampheleire…
Both files have a similar concept, they describe some flags/paths needed for compilation using respective build systems. One difference is that the meson file is added for external compilation, from the SDK, while the cmake file is used internally in Buildroot.
The 'problem' of using
TARGET_FINALIZE_HOOKSfor the meson file, is that it installs a 'host' file from target-finalize, which is conceptually incorrect and breaks the invariant that onlyTARGET_DIRis changed on a subsequent 'make' when everything was already built (i.e. only target-finalize is run).In fact, I don't quite get what this commit is fixing. I don't really understand what you call the "invariant that only
TARGET_DIRis changed on a subsequent make when everything was already built".
Quoted 6 lines
The current situation is not ideal because we create a file in $(HOST_DIR) from target-finalize, but the proposed situation is also not ideal because we create a file in $(HOST_DIR) from the staging installation of a package. So I'd need to understand why the second option has some advantages over the first, and that is currently unclear.
When Buildroot 'make' has completed successfully, and you run 'make' without changes a second time, the only thing currently happening again is target-finalize. As the name suggests, it should only touch the TARGET_DIR. This is a principle I think we should keep.
The generation of the toolchain file for meson violated this, by touching a host file from target-finalize, and thus also causing changes to something else than the TARGET_DIR after a 'make' without changes. In fact, there is totally no need to regenerate this 'static' file more than once.
The solution I proposed fixes the described problem, but indeed uses another apparent violation (present before in other places): touching a host file from a staging step. Strictly speaking STAGING_DIR is inside HOST_DIR, but conceptually they are different indeed. This is actually caused by the fact that the toolchain step does not actually have a 'host' installation step, currently (because it is not a 'host' package. Therefore, here and in other places, the 'staging' step is used instead.
Quoted 3 lines
Is it just for consistency for how the corresponding cmake file is created ?
I used the cmake thing as an example because it is very similar. It makes sense to align, but alignment itself is not the goal.
Thanks,
Thomas
Arnout Vandecappelle
AppliedPATCH 1/2 package/meson: don't install cross-compilation.conf during target-finalize
In reply to Thomas De SchampheleireQuoted 21 lines · Thomas De Schampheleire
From: Thomas De Schampheleire <[email protected]>
package/meson installs a cross-compilation.conf file in $(HOST_DIR)/etc/meson, via
TARGET_FINALIZE_HOOKS.
package/pkg-cmake.mkinstalls a toolchainfile.cmake in $(HOST_DIR)/share/buildroot, viaTOOLCHAIN_POST_INSTALL_STAGING_HOOKS.Both files have a similar concept, they describe some flags/paths needed for compilation using respective build systems. One difference is that the meson file is added for external compilation, from the SDK, while the cmake file is used internally in Buildroot.
The 'problem' of using
TARGET_FINALIZE_HOOKSfor the meson file, is that it installs a 'host' file from target-finalize, which is conceptually incorrect and breaks the invariant that onlyTARGET_DIRis changed on a subsequent 'make' when everything was already built (i.e. only target-finalize is run).This can easily be fixed, by using the same hook as cmake uses, i.e.
TOOLCHAIN_POST_INSTALL_STAGING_HOOKS.
Quoted 6 lines
Note that actually even for cmake,
TOOLCHAIN_POST_INSTALL_STAGING_HOOKSis not the best hook to install a host file. A better hook would have beenTOOLCHAIN_POST_INSTALL_HOOKS, but this triggers only for 'host' packages, and 'toolchain' is treated as a 'target' package.Signed-off-by Thomas De Schampheleire <[email protected]>
Applied to master (with a bit more text as proposed), thanks.
Quoted 9 lines
--- package/meson/meson.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/meson/meson.mk +0
-0
package/meson/meson.mk define HOST_MESON_INSTALL_CROSS_CONF · line 68
Quoted 5 lines
package/meson/meson.mk +1
-1@@ -65,6 +65,7 @@ define HOST_MESON_INSTALL_CROSS_CONF > $(HOST_DIR)/etc/meson/cross-compilation.conf endef -TARGET_FINALIZE_HOOKS += HOST_MESON_INSTALL_CROSS_CONF +TOOLCHAIN_POST_INSTALL_STAGING_HOOKS += HOST_MESON_INSTALL_CROSS_CONF
check-package now complains that you're setting a variable that doesn't start
with MESON_, so I moved this to pkg-meson.mk (like for cmake).
package/meson/meson.mk define HOST_MESON_INSTALL_CROSS_CONF · line 69
Quoted 1 line
package/meson/meson.mk +1
-0+TOOLCHAIN_INSTALL_STAGING = YES
It would make sense to move this to toolchain.mk. I'll send a patch for that.
Regards,
Arnout
PATCH 2/2 package/iproute2: backport patch to fix compilation under glibc < 2.18
In reply to Thomas De SchampheleireFrom: Thomas De Schampheleire <[email protected]>
When compiling iproute2 using a toolchain containing glibc 2.17 and older, it fails due to a missing definition of AF_VSOCK.
Add a submitted and accepted upstream patch to fix this issue.
--- ...-ss-fix-compilation-under-glibc-2.18.patch | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 package/iproute2/0002-ss-fix-compilation-under-glibc-2.18.patch
package/iproute2/0002-ss-fix-compilation-under-glibc-2.18.patch new file +39 -0
@@ -0,0 +1,39 @@ +From 9700927a008a803ac119bdf816bdc1baa69d705c Mon Sep 17 00:00:00 2001 +From: Thomas De Schampheleire <[email protected]> +Date: Wed, 20 Feb 2019 15:41:51 +0100 +Subject: [PATCH] ss: fix compilation under glibc < 2.18 + +Commit c759116a0b2b6da8df9687b0a40ac69050132c77 introduced support for +AF_VSOCK. This define is only provided since glibc version 2.18, so +compilation fails when using older toolchains. + +Provide the necessary definitions if needed. + +Signed-off-by: Thomas De Schampheleire <[email protected]> +Signed-off-by: Stephen Hemminger <[email protected]> +--- + misc/ss.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/misc/ss.c b/misc/ss.c +index 9e821faf..766fdc5f 100644 +--- a/misc/ss.c ++++ b/misc/ss.c +@@ -51,6 +51,14 @@ + #include <linux/tipc_netlink.h> + #include <linux/tipc_sockets_diag.h> + ++/* AF_VSOCK/PF_VSOCK is only provided since glibc 2.18 */ ++#ifndef PF_VSOCK ++#define PF_VSOCK 40 ++#endif ++#ifndef AF_VSOCK ++#define AF_VSOCK PF_VSOCK ++#endif ++ + #define MAGIC_SEQ 123456 + #define BUF_CHUNK (1024 * 1024) + #define LEN_ALIGN(x) (((x) + 1) & ~1) +-- +2.19.2 +
Signature · 1 line
2.19.2
PATCH 2/2 package/iproute2: backport patch to fix compilation under glibc < 2.18
Hi Thomas,
Quoted 7 lines
From: Thomas De Schampheleire <[email protected]>
When compiling iproute2 using a toolchain containing glibc 2.17 and older, it fails due to a missing definition of
AF_VSOCK.Add a submitted and accepted upstream patch to fix this issue.
Signed-off-by Thomas De Schampheleire <[email protected]>
Thanks for your fix!
Kind regards,
Petr
Thomas Petazzoni
AppliedPATCH 2/2 package/iproute2: backport patch to fix compilation under glibc < 2.18
In reply to Thomas De SchampheleireHello Thomas,
Quoted 3 lines · On Mon, 25 Feb 2019 22:11:47 +0100 Thomas De Schampheleire…
From: Thomas De Schampheleire <[email protected]>
When compiling iproute2 using a toolchain containing glibc 2.17 and older, it fails due to a missing definition of
AF_VSOCK.
So you're no longer wrapping your commit logs ? :-)
Quoted 8 lines
Add a submitted and accepted upstream patch to fix this issue.
Signed-off-by Thomas De Schampheleire <[email protected]>--- ...-ss-fix-compilation-under-glibc-2.18.patch | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 package/iproute2/0002-ss-fix-compilation-under-glibc-2.18.patch
Applied to master, thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 2/2 package/iproute2: backport patch to fix compilation under glibc < 2.18
In reply to Thomas De SchampheleireQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> When compiling iproute2 using a toolchain containing glibc 2.17 and older, it fails due to a missing definition of
AF_VSOCK.Add a submitted and accepted upstream patch to fix this issue.
Signed-off-by Thomas De Schampheleire <[email protected]>
Committed to 2018.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard