perf annotation of BPF programs
Subsystems (6)
v4 cover perf annotation of BPF programs
Changes v3 to v4:
1. Incorporate feedbacks from Jiri and Namhyung;
2. Fixed compilation error with different feature-disassembler-four-args;
3. Split some patches to smaller patches;
4. Improved error handleing in symbol__disassemble_bpf();
5. Made side band thread more generic;
6. Added comments as suggested.
Changes v2 to v3:
1. Remove unnecessary include in header files;
2. Improved error handling;
3. Better naming of functions, variables, etc.;
4. Enable bpf events by default for perf-top.
Changes v1 to v2:
1. Fix compilation error with different feature-disassembler-four-args;
2. Fix a segfault in perf-record;
3. Split patches 5/9 and 6/9 so that perf_env changes and perf.data changes are in separate patches.
This series enables annotation of BPF programs in perf.
perf tool gathers information via sys_bpf and (optionally) stores them in perf.data as headers.
Patch 1/15 fixes a minor issue in kernel;
Patch 2/15 to 4/15 introduce new helper functions and use them in perf and
bpftool;
Patch 5/15 to 9/15 saves information of bpf program in perf_env;
Patch 10/15 adds --bpf-event options to perf-top;
Patch 11/15 to 13/15 enables annotation of bpf progs based on information
gathered in 5/15 to 9/15;Patch 14/15 introduces side band polling thread that gathers information
for special kernel events during perf-record or perf-top.
Patch 15/15 handles information of short living BPF program using the new
side band polling thread.
Commands tested during developments are perf-top, perf-record, perf-report, and perf-annotate.
===================== Note on patch dependency ======================== This set has dependency in both bpf-next tree and tip/perf/core. Current version is developed on bpf-next tree with the following commits cherry-picked from tip/perf/core:
(from 1/10 to 10/10)
commit 76193a94522f ("perf, bpf: Introduce PERF_RECORD_KSYMBOL")
commit d764ac646491 ("tools headers uapi: Sync tools/include/uapi/linux/perf_event.h") commit 6ee52e2a3fe4 ("perf, bpf: Introduce PERF_RECORD_BPF_EVENT")
commit df063c83aa2c ("tools headers uapi: Sync tools/include/uapi/linux/perf_event.h") commit 9aa0bfa370b2 ("perf tools: Handle PERF_RECORD_KSYMBOL")
commit 45178a928a4b ("perf tools: Handle PERF_RECORD_BPF_EVENT")
commit 7b612e291a5a ("perf tools: Synthesize PERF_RECORD_* for loaded BPF programs") commit a40b95bcd30c ("perf top: Synthesize BPF events for pre-existing loaded BPF programs") commit 6934058d9fb6 ("bpf: Add module name [bpf] to ksymbols for bpf programs") commit 811184fb6977 ("perf bpf: Fix synthesized PERF_RECORD_KSYMBOL/BPF_EVENT")
========================================================================
This set is also available at:
https://github.com/liu-song-6/linux/tree/bpf-annotation
Thanks!!
Song Liu (15):
perf, bpf: consider events with attr.bpf_event as side-band events
bpf: libbpf: introduce bpf_program__get_prog_info_linear()
bpf: bpftool: use bpf_program__get_prog_info_linear() in
prog.c:do_dump()
perf, bpf: synthesize bpf events with
bpf_program__get_prog_info_linear()
perf: change prototype of perf_event__synthesize_bpf_events() perf, bpf: save bpf_prog_info in a rbtree in perf_env perf, bpf: save bpf_prog_info information as headers to perf.data perf, bpf: save btf in a rbtree in perf_env
perf, bpf: save btf information as headers to perf.data
perf-top: add option --no-bpf-event
perf: add -lopcodes to feature-libbfd
perf, bpf: enable annotation of bpf program
perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation
perf: introduce side band thread
perf, bpf: save information about short living bpf programs
kernel/events/core.c | 3 +- tools/bpf/bpftool/prog.c | 266 +++++++------------------------ tools/build/Makefile.feature | 6 +- tools/lib/bpf/libbpf.c | 251 +++++++++++++++++++++++++++++ tools/lib/bpf/libbpf.h | 63 ++++++++ tools/lib/bpf/libbpf.map | 3 + tools/perf/Makefile.config | 6 +- tools/perf/builtin-record.c | 12 +- tools/perf/builtin-top.c | 15 +- tools/perf/util/annotate.c | 149 ++++++++++++++++- tools/perf/util/bpf-event.c | 301 +++++++++++++++++++++++++---------- tools/perf/util/bpf-event.h | 36 ++++- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 33 ++-- tools/perf/util/env.c | 150 +++++++++++++++++ tools/perf/util/env.h | 21 +++ tools/perf/util/evlist.c | 105 ++++++++++++ tools/perf/util/evlist.h | 13 ++ tools/perf/util/header.c | 256 ++++++++++++++++++++++++++++- tools/perf/util/header.h | 2 + tools/perf/util/symbol.c | 1 + tools/perf/util/top.h | 1 + tools/perf/util/util.c | 10 ++ tools/perf/util/util.h | 2 + 24 files changed, 1389 insertions(+), 317 deletions(-)
--
2.17.1
PATCH v4 1/15 perf, bpf: consider events with attr.bpf_event as side-band events
Events with bpf_event should be considered as side-band event, as they carry information about BPF programs.
--- kernel/events/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/events/core.c +2 -1
@@ -4238,7 +4238,8 @@ static bool is_sb_event(struct perf_event *event)if (attr->mmap || attr->mmap_data || attr->mmap2 || attr->comm || attr->comm_exec || attr->task || attr->ksymbol || - attr->context_switch) + attr->context_switch || + attr->bpf_event)return true;return false; }
Signature · 1 line
2.17.1
tip-bot for Song Liu
merge bot[tip:perf/urgent] perf, bpf: Consider events with attr.bpf_event as side-band events
perf, bpf: Consider events with attr.bpf_event as side-band events
Commit-ID: 21038f2baa05a0550f56f010f609a5c871b6a274 Gitweb: https://git.kernel.org/tip/21038f2baa05a0550f56f010f609a5c871b6a274 Author: Song Liu <[email protected]> AuthorDate: Mon, 25 Feb 2019 16:20:05 -0800 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 28 Feb 2019 14:20:35 -0300
perf, bpf: Consider events with attr.bpf_event as side-band events
Events with attr.bpf_event set should be considered as side-band events, as they carry information about BPF programs.
--- kernel/events/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/events/core.c +2 -1
@@ -4238,7 +4238,8 @@ static bool is_sb_event(struct perf_event *event)if (attr->mmap || attr->mmap_data || attr->mmap2 || attr->comm || attr->comm_exec || attr->task || attr->ksymbol || - attr->context_switch) + attr->context_switch || + attr->bpf_event)return true;return false; }
PATCH v4 2/15 bpf: libbpf: introduce bpf_program__get_prog_info_linear()
In reply to Song LiuCurrently, bpf_prog_info includes 9 arrays. The user has the option to fetch any combination of these arrays. However, this requires a lot of handling of these arrays. This work becomes more tricky when we need to store bpf_prog_info to a file, because these arrays are allocated independently.
This patch introduces struct bpf_prog_info_linear, which stores arrays of bpf_prog_info in continues memory. Helper functions are introduced to unify the work to get different information of bpf_prog_info. Specifically, bpf_program__get_prog_info_linear() allows the user to select which arrays to fetch, and handles details for the user.
Plesae see the comments before enum bpf_prog_info_array for more details and examples.
--- tools/lib/bpf/libbpf.c | 251 +++++++++++++++++++++++++++++++++++++++ tools/lib/bpf/libbpf.h | 63 ++++++++++ tools/lib/bpf/libbpf.map | 3 + 3 files changed, 317 insertions(+)
tools/lib/bpf/libbpf.c +251 -0
@@ -112,6 +112,11 @@ void libbpf_print(enum libbpf_print_level level, const char *format, ...)# define LIBBPF_ELF_C_READ_MMAP ELF_C_READ#endif +static inline __u64 ptr_to_u64 (const void *ptr) +{ +return (__u64 ) (unsigned long ) ptr; +} +struct bpf_capabilities {/* v4.14: kernel support for program & map names. */ __u32 name:1 ;
@@ -2997,3 +3002,249 @@ bpf_perf_event_read_simple(void *mmap_mem, size_t mmap_size, size_t page_size,ring_buffer_write_tail (header, data_tail);return ret; } + +struct bpf_prog_info_array_desc { +int array_offset;/* e.g. offset of jited_prog_insns */ +int count_offset;/* e.g. offset of jited_prog_len */ +int size_offset;/* > 0: offset of rec size, +* < 0: fix size of -size_offset +*/ +}; + +static struct bpf_prog_info_array_desc bpf_prog_info_array_desc[] = { + [BPF_PROG_INFO_JITED_INSNS ] = { + offsetof(struct bpf_prog_info , jited_prog_insns), + offsetof(struct bpf_prog_info , jited_prog_len), +-1 , + }, + [BPF_PROG_INFO_XLATED_INSNS ] = { + offsetof(struct bpf_prog_info , xlated_prog_insns), + offsetof(struct bpf_prog_info , xlated_prog_len), +-1 , + }, + [BPF_PROG_INFO_MAP_IDS ] = { + offsetof(struct bpf_prog_info , map_ids), + offsetof(struct bpf_prog_info , nr_map_ids), + -(int )sizeof (__u32), + }, + [BPF_PROG_INFO_JITED_KSYMS ] = { + offsetof(struct bpf_prog_info , jited_ksyms), + offsetof(struct bpf_prog_info , nr_jited_ksyms), + -(int )sizeof (__u64), + }, + [BPF_PROG_INFO_JITED_FUNC_LENS ] = { + offsetof(struct bpf_prog_info , jited_func_lens), + offsetof(struct bpf_prog_info , nr_jited_func_lens), + -(int )sizeof (__u32), + }, + [BPF_PROG_INFO_FUNC_INFO ] = { + offsetof(struct bpf_prog_info , func_info), + offsetof(struct bpf_prog_info , nr_func_info), + offsetof(struct bpf_prog_info , func_info_rec_size), + }, + [BPF_PROG_INFO_LINE_INFO ] = { + offsetof(struct bpf_prog_info , line_info), + offsetof(struct bpf_prog_info , nr_line_info), + offsetof(struct bpf_prog_info , line_info_rec_size), + }, + [BPF_PROG_INFO_JITED_LINE_INFO ] = { + offsetof(struct bpf_prog_info , jited_line_info), + offsetof(struct bpf_prog_info , nr_jited_line_info), + offsetof(struct bpf_prog_info , jited_line_info_rec_size), + }, + [BPF_PROG_INFO_PROG_TAGS ] = { + offsetof(struct bpf_prog_info , prog_tags), + offsetof(struct bpf_prog_info , nr_prog_tags), + -(int )sizeof (__u8) *BPF_TAG_SIZE , + }, + +}; + +static __u32 bpf_prog_info_read_offset_u32 (struct bpf_prog_info *info,int offset) +{ +__u32 *array = (__u32 *)info; + +if (offset >=0 ) +return array[offset /sizeof (__u32)]; +return -(int )offset; +} + +static __u64 bpf_prog_info_read_offset_u64 (struct bpf_prog_info *info,int offset) +{ +__u64 *array = (__u64 *)info; + +if (offset >=0 ) +return array[offset /sizeof (__u64)]; +return -(int )offset; +} + +static void bpf_prog_info_set_offset_u32 (struct bpf_prog_info *info,int offset, +__u32 val) +{ +__u32 *array = (__u32 *)info; + +if (offset >=0 ) + array[offset /sizeof (__u32)] = val; +} + +static void bpf_prog_info_set_offset_u64 (struct bpf_prog_info *info,int offset, +__u64 val) +{ +__u64 *array = (__u64 *)info; + +if (offset >=0 ) + array[offset /sizeof (__u64)] = val; +} + +struct bpf_prog_info_linear * +bpf_program__get_prog_info_linear (int fd,__u64 arrays) +{ +struct bpf_prog_info_linear *info_linear; +struct bpf_prog_info info = {}; +__u32 info_len =sizeof (info); +__u32 data_len =0 ; +int i, err; +void *ptr; + +if (arrays >>BPF_PROG_INFO_LAST_ARRAY ) +return ERR_PTR (-EINVAL ); + +/* step 1: get array dimensions */ + err =bpf_obj_get_info_by_fd (fd, &info, &info_len); +if (err) { +pr_debug ("can't get prog info: %s" ,strerror (errno)); +return ERR_PTR (-EFAULT ); + } + +/* step 2: calculate total size of all arrays */ +for (i =BPF_PROG_INFO_FIRST_ARRAY ; i <BPF_PROG_INFO_LAST_ARRAY ; ++i) { +bool include_array = (arrays & (1UL << i)) >0 ; +struct bpf_prog_info_array_desc *desc; +__u32 count, size; + + desc = bpf_prog_info_array_desc + i; + +/* kernel is too old to support this field */ +if (info_len < desc->array_offset +sizeof (__u32) || + info_len < desc->count_offset +sizeof (__u32) || + (desc->size_offset >0 && info_len < desc->size_offset)) + include_array = false; + +if (!include_array) { + arrays &= ~(1UL << i);/* clear the bit */ +continue ; + } + + count =bpf_prog_info_read_offset_u32 (&info, desc->count_offset); + size =bpf_prog_info_read_offset_u32 (&info, desc->size_offset); + + data_len += count * size; + } + +/* step 3: allocate continuous memory */ + data_len =roundup (data_len,sizeof (__u64)); + info_linear =malloc (sizeof (struct bpf_prog_info_linear ) + data_len); +if (!info_linear) +return ERR_PTR (-ENOMEM ); + +/* step 4: fill data to info_linear->info */ + info_linear->arrays = arrays; +memset (&info_linear->info,0 ,sizeof (info)); + ptr = info_linear->data; + +for (i =BPF_PROG_INFO_FIRST_ARRAY ; i <BPF_PROG_INFO_LAST_ARRAY ; ++i) { +struct bpf_prog_info_array_desc *desc; +__u32 count, size; + +if ((arrays & (1UL << i)) ==0 ) +continue ; + + desc = bpf_prog_info_array_desc + i; + count =bpf_prog_info_read_offset_u32 (&info, desc->count_offset); + size =bpf_prog_info_read_offset_u32 (&info, desc->size_offset); +bpf_prog_info_set_offset_u32 (&info_linear->info, + desc->count_offset, count); +bpf_prog_info_set_offset_u32 (&info_linear->info, + desc->size_offset, size); +bpf_prog_info_set_offset_u64 (&info_linear->info, + desc->array_offset, +ptr_to_u64 (ptr)); + ptr += count * size; + } + +/* step 5: call syscall again to get required arrays */ + err =bpf_obj_get_info_by_fd (fd, &info_linear->info, &info_len); +if (err) { +pr_debug ("can't get prog info: %s" ,strerror (errno)); +free (info_linear); +return ERR_PTR (-EFAULT ); + } + +/* step 6: verify the data */ +for (i =BPF_PROG_INFO_FIRST_ARRAY ; i <BPF_PROG_INFO_LAST_ARRAY ; ++i) { +struct bpf_prog_info_array_desc *desc; +__u32 v1, v2; + +if ((arrays & (1UL << i)) ==0 ) +continue ; + + desc = bpf_prog_info_array_desc + i; + v1 =bpf_prog_info_read_offset_u32 (&info, desc->count_offset); + v2 =bpf_prog_info_read_offset_u32 (&info_linear->info, + desc->count_offset); +if (v1 != v2) +pr_warning ("%s: mismatch in element count\n" , __func__); + + v1 =bpf_prog_info_read_offset_u32 (&info, desc->size_offset); + v2 =bpf_prog_info_read_offset_u32 (&info_linear->info, + desc->size_offset); +if (v1 != v2) +pr_warning ("%s: mismatch in rec size\n" , __func__); + } + +/* step 7: update info_len and data_len */ + info_linear->info_len =sizeof (struct bpf_prog_info ); + info_linear->data_len = data_len; + +return info_linear; +} + +void bpf_program__bpil_addr_to_offs (struct bpf_prog_info_linear *info_linear) +{ +int i; + +for (i =BPF_PROG_INFO_FIRST_ARRAY ; i <BPF_PROG_INFO_LAST_ARRAY ; ++i) { +struct bpf_prog_info_array_desc *desc; +__u64 addr, offs; + +if ((info_linear->arrays & (1UL << i)) ==0 ) +continue ; + + desc = bpf_prog_info_array_desc + i; + addr =bpf_prog_info_read_offset_u64 (&info_linear->info, + desc->array_offset); + offs = addr -ptr_to_u64 (info_linear->data); +bpf_prog_info_set_offset_u64 (&info_linear->info, + desc->array_offset, offs); + } +} + +void bpf_program__bpil_offs_to_addr (struct bpf_prog_info_linear *info_linear) +{ +int i; + +for (i =BPF_PROG_INFO_FIRST_ARRAY ; i <BPF_PROG_INFO_LAST_ARRAY ; ++i) { +struct bpf_prog_info_array_desc *desc; +__u64 addr, offs; + +if ((info_linear->arrays & (1UL << i)) ==0 ) +continue ; + + desc = bpf_prog_info_array_desc + i; + offs =bpf_prog_info_read_offset_u64 (&info_linear->info, + desc->array_offset); + addr = offs +ptr_to_u64 (info_linear->data); +bpf_prog_info_set_offset_u64 (&info_linear->info, + desc->array_offset, addr); + } +}
tools/lib/bpf/libbpf.h +63 -0
69 lines not on this page · raw message
tools/lib/bpf/libbpf.map +3 -0
@@ -147,4 +147,7 @@ LIBBPF_0.0.2 { btf_ext__new; btf_ext__reloc_func_info; btf_ext__reloc_line_info; + bpf_program__get_prog_info_linear; + bpf_program__bpil_addr_to_offs; + bpf_program__bpil_offs_to_addr; } LIBBPF_0.0.1;
Signature · 1 line
2.17.1
PATCH v4 3/15 bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump()
In reply to Song LiuThis patches uses bpf_program__get_prog_info_linear() to simplify the logic in prog.c do_dump().
--- tools/bpf/bpftool/prog.c | 266 +++++++++------------------------------ 1 file changed, 59 insertions(+), 207 deletions(-)
tools/bpf/bpftool/prog.c +59 -207
@@ -393,41 +393,31 @@ static int do_show(int argc, char **argv)static int do_dump (int argc,char **argv) { -unsigned int finfo_rec_size, linfo_rec_size, jited_linfo_rec_size; -void *func_info =NULL , *linfo =NULL , *jited_linfo =NULL ; -unsigned int nr_finfo, nr_linfo =0 , nr_jited_linfo =0 ; +struct bpf_prog_info_linear *info_linear;struct bpf_prog_linfo *prog_linfo =NULL ; -unsigned long *func_ksyms =NULL ; -struct bpf_prog_info info = {}; -unsigned int *func_lens =NULL ; +enum {DUMP_JITED ,DUMP_XLATED } mode;const char *disasm_opt =NULL ; -unsigned int nr_func_ksyms; -unsigned int nr_func_lens; +struct bpf_prog_info *info;struct dump_data dd = {}; -__u32 len =sizeof (info); +void *func_info =NULL ;struct btf *btf =NULL ; -unsigned int buf_size;char *filepath =NULL ;bool opcodes = false;bool visual = false;char func_sig[1024 ];unsigned char *buf;bool linum = false; -__u32 *member_len; -__u64 *member_ptr; +__u32 member_len; +__u64 arrays;ssize_t n; -int err;int fd;if (is_prefix (*argv,"jited" )) {if (disasm_init ())return -1 ; - - member_len = &info.jited_prog_len; - member_ptr = &info.jited_prog_insns; + mode =DUMP_JITED ; }else if (is_prefix (*argv,"xlated" )) { - member_len = &info.xlated_prog_len; - member_ptr = &info.xlated_prog_insns; + mode =DUMP_XLATED ; }else {p_err ("expected 'xlated' or 'jited', got: %s" , *argv);return -1 ;
@@ -466,175 +456,50 @@ static int do_dump(int argc, char **argv)return -1 ; } - err =bpf_obj_get_info_by_fd (fd, &info, &len); -if (err) { -p_err ("can't get prog info: %s" ,strerror (errno)); -return -1 ; - } - -if (!*member_len) { -p_info ("no instructions returned" ); -close (fd); -return 0 ; - } +if (mode ==DUMP_JITED ) + arrays =1UL <<BPF_PROG_INFO_JITED_INSNS ; +else + arrays =1UL <<BPF_PROG_INFO_XLATED_INSNS ; - buf_size = *member_len; + arrays |=1UL <<BPF_PROG_INFO_JITED_KSYMS ; + arrays |=1UL <<BPF_PROG_INFO_JITED_FUNC_LENS ; + arrays |=1UL <<BPF_PROG_INFO_FUNC_INFO ; + arrays |=1UL <<BPF_PROG_INFO_LINE_INFO ; + arrays |=1UL <<BPF_PROG_INFO_JITED_LINE_INFO ; - buf =malloc (buf_size); -if (!buf) { -p_err ("mem alloc failed" ); -close (fd); + info_linear =bpf_program__get_prog_info_linear (fd, arrays); +close (fd); +if (IS_ERR_OR_NULL (info_linear)) { +p_err ("can't get prog info: %s" ,strerror (errno));return -1 ; } - nr_func_ksyms = info.nr_jited_ksyms; -if (nr_func_ksyms) { - func_ksyms =malloc (nr_func_ksyms *sizeof (__u64)); -if (!func_ksyms) { -p_err ("mem alloc failed" ); -close (fd); - goto err_free; - } - } - - nr_func_lens = info.nr_jited_func_lens; -if (nr_func_lens) { - func_lens =malloc (nr_func_lens *sizeof (__u32)); -if (!func_lens) { -p_err ("mem alloc failed" ); -close (fd); + info = &info_linear->info; +if (mode ==DUMP_JITED ) { +if (info->jited_prog_len ==0 ) { +p_info ("no instructions returned" ); goto err_free; } - } - - nr_finfo = info.nr_func_info; - finfo_rec_size = info.func_info_rec_size; -if (nr_finfo && finfo_rec_size) { - func_info =malloc (nr_finfo * finfo_rec_size); -if (!func_info) { -p_err ("mem alloc failed" ); -close (fd); + buf = (unsigned char *)(info->jited_prog_insns); + member_len = info->jited_prog_len; + }else {/* DUMP_XLATED */ +if (info->xlated_prog_len ==0 ) { +p_err ("error retrieving insn dump: kernel.kptr_restrict set?" ); goto err_free; } + buf = (unsigned char *)info->xlated_prog_insns; + member_len = info->xlated_prog_len; } - linfo_rec_size = info.line_info_rec_size; -if (info.nr_line_info && linfo_rec_size && info.btf_id) { - nr_linfo = info.nr_line_info; - linfo =malloc (nr_linfo * linfo_rec_size); -if (!linfo) { -p_err ("mem alloc failed" ); -close (fd); - goto err_free; - } - } - - jited_linfo_rec_size = info.jited_line_info_rec_size; -if (info.nr_jited_line_info && - jited_linfo_rec_size && - info.nr_jited_ksyms && - info.nr_jited_func_lens && - info.btf_id) { - nr_jited_linfo = info.nr_jited_line_info; - jited_linfo =malloc (nr_jited_linfo * jited_linfo_rec_size); -if (!jited_linfo) { -p_err ("mem alloc failed" ); -close (fd); - goto err_free; - } - } - -memset (&info,0 ,sizeof (info)); - - *member_ptr =ptr_to_u64 (buf); - *member_len = buf_size; - info.jited_ksyms =ptr_to_u64 (func_ksyms); - info.nr_jited_ksyms = nr_func_ksyms; - info.jited_func_lens =ptr_to_u64 (func_lens); - info.nr_jited_func_lens = nr_func_lens; - info.nr_func_info = nr_finfo; - info.func_info_rec_size = finfo_rec_size; - info.func_info =ptr_to_u64 (func_info); - info.nr_line_info = nr_linfo; - info.line_info_rec_size = linfo_rec_size; - info.line_info =ptr_to_u64 (linfo); - info.nr_jited_line_info = nr_jited_linfo; - info.jited_line_info_rec_size = jited_linfo_rec_size; - info.jited_line_info =ptr_to_u64 (jited_linfo); - - err =bpf_obj_get_info_by_fd (fd, &info, &len); -close (fd); -if (err) { -p_err ("can't get prog info: %s" ,strerror (errno)); - goto err_free; - } - -if (*member_len > buf_size) { -p_err ("too many instructions returned" ); - goto err_free; - } - -if (info.nr_jited_ksyms > nr_func_ksyms) { -p_err ("too many addresses returned" ); - goto err_free; - } - -if (info.nr_jited_func_lens > nr_func_lens) { -p_err ("too many values returned" ); - goto err_free; - } - -if (info.nr_func_info != nr_finfo) { -p_err ("incorrect nr_func_info %d vs. expected %d" , - info.nr_func_info, nr_finfo); - goto err_free; - } - -if (info.func_info_rec_size != finfo_rec_size) { -p_err ("incorrect func_info_rec_size %d vs. expected %d" , - info.func_info_rec_size, finfo_rec_size); - goto err_free; - } - -if (linfo && info.nr_line_info != nr_linfo) { -p_err ("incorrect nr_line_info %u vs. expected %u" , - info.nr_line_info, nr_linfo); - goto err_free; - } - -if (info.line_info_rec_size != linfo_rec_size) { -p_err ("incorrect line_info_rec_size %u vs. expected %u" , - info.line_info_rec_size, linfo_rec_size); - goto err_free; - } - -if (jited_linfo && info.nr_jited_line_info != nr_jited_linfo) { -p_err ("incorrect nr_jited_line_info %u vs. expected %u" , - info.nr_jited_line_info, nr_jited_linfo); - goto err_free; - } - -if (info.jited_line_info_rec_size != jited_linfo_rec_size) { -p_err ("incorrect jited_line_info_rec_size %u vs. expected %u" , - info.jited_line_info_rec_size, jited_linfo_rec_size); - goto err_free; - } - -if ((member_len == &info.jited_prog_len && - info.jited_prog_insns ==0 ) || - (member_len == &info.xlated_prog_len && - info.xlated_prog_insns ==0 )) { -p_err ("error retrieving insn dump: kernel.kptr_restrict set?" ); - goto err_free; - } - -if (info.btf_id &&btf__get_from_id (info.btf_id, &btf)) { +if (info->btf_id &&btf__get_from_id (info->btf_id, &btf)) {p_err ("failed to get btf" ); goto err_free; } -if (nr_linfo) { - prog_linfo =bpf_prog_linfo__new (&info); + func_info = (void *)info->func_info; + +if (info->nr_line_info) { + prog_linfo =bpf_prog_linfo__new (info);if (!prog_linfo)p_info ("error in processing bpf_line_info. continue without it." ); }
@@ -647,9 +512,9 @@ static int do_dump(int argc, char **argv) goto err_free; } - n =write (fd, buf, *member_len); + n =write (fd, buf, member_len);close (fd); -if (n != *member_len) { +if (n != member_len) {p_err ("error writing output file: %s" , n <0 ?strerror (errno) :"short write" ); goto err_free;
@@ -657,19 +522,19 @@ static int do_dump(int argc, char **argv)if (json_output)jsonw_null (json_wtr); - }else if (member_len == &info.jited_prog_len) { + }else if (mode ==DUMP_JITED ) {const char *name =NULL ; -if (info.ifindex) { - name =ifindex_to_bfd_params (info.ifindex, - info.netns_dev, - info.netns_ino, +if (info->ifindex) { + name =ifindex_to_bfd_params (info->ifindex, + info->netns_dev, + info->netns_ino, &disasm_opt);if (!name) goto err_free; } -if (info.nr_jited_func_lens && info.jited_func_lens) { +if (info->nr_jited_func_lens && info->jited_func_lens) {struct kernel_sym *sym =NULL ;struct bpf_func_info *record;char sym_name[SYM_MAX_NAME ];
@@ -677,17 +542,16 @@ static int do_dump(int argc, char **argv)__u64 *ksyms =NULL ;__u32 *lens;__u32 i; - -if (info.nr_jited_ksyms) { +if (info->nr_jited_ksyms) {kernel_syms_load (&dd); - ksyms = (__u64 *) info.jited_ksyms; + ksyms = (__u64 *) info->jited_ksyms; }if (json_output)jsonw_start_array (json_wtr); - lens = (__u32 *) info.jited_func_lens; -for (i =0 ; i < info.nr_jited_func_lens; i++) { + lens = (__u32 *) info->jited_func_lens; +for (i =0 ; i < info->nr_jited_func_lens; i++) {if (ksyms) { sym =kernel_syms_search (&dd, ksyms[i]);if (sym)
@@ -699,7 +563,7 @@ static int do_dump(int argc, char **argv) }if (func_info) { - record = func_info + i * finfo_rec_size; + record = func_info + i * info->func_info_rec_size;btf_dumper_type_only (btf, record->type_id, func_sig,sizeof (func_sig));
@@ -736,49 +600,37 @@ static int do_dump(int argc, char **argv)if (json_output)jsonw_end_array (json_wtr); }else { -disasm_print_insn (buf, *member_len, opcodes, name, +disasm_print_insn (buf, member_len, opcodes, name, disasm_opt, btf,NULL ,0 ,0 , false); } }else if (visual) {if (json_output)jsonw_null (json_wtr);else -dump_xlated_cfg (buf, *member_len); +dump_xlated_cfg (buf, member_len); }else {kernel_syms_load (&dd); - dd.nr_jited_ksyms = info.nr_jited_ksyms; - dd.jited_ksyms = (__u64 *) info.jited_ksyms; + dd.nr_jited_ksyms = info->nr_jited_ksyms; + dd.jited_ksyms = (__u64 *) info->jited_ksyms; dd.btf = btf; dd.func_info = func_info; - dd.finfo_rec_size = finfo_rec_size; + dd.finfo_rec_size = info->func_info_rec_size; dd.prog_linfo = prog_linfo;if (json_output) -dump_xlated_json (&dd, buf, *member_len, opcodes, +dump_xlated_json (&dd, buf, member_len, opcodes, linum);else -dump_xlated_plain (&dd, buf, *member_len, opcodes, +dump_xlated_plain (&dd, buf, member_len, opcodes, linum);kernel_syms_destroy (&dd); } -free (buf); -free (func_ksyms); -free (func_lens); -free (func_info); -free (linfo); -free (jited_linfo); -bpf_prog_linfo__free (prog_linfo); +free (info_linear);return 0 ; err_free: -free (buf); -free (func_ksyms); -free (func_lens); -free (func_info); -free (linfo); -free (jited_linfo); -bpf_prog_linfo__free (prog_linfo); +free (info_linear);return -1 ; }
Signature · 1 line
2.17.1
PATCH v4 4/15 perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear()
In reply to Song LiuWith bpf_program__get_prog_info_linear, we can simplify the logic that synthesizes bpf events.
This patch doesn't change the behavior of the code.
--- tools/perf/util/bpf-event.c | 118 ++++++++++++------------------------ 1 file changed, 40 insertions(+), 78 deletions(-)
tools/perf/util/bpf-event.c +40 -78
@@ -3,7 +3,9 @@#include <stdlib.h> #include <bpf/bpf.h> #include <bpf/btf.h> +#include <bpf/libbpf.h> #include <linux/btf.h> +#include <linux/err.h> #include "bpf-event.h" #include "debug.h" #include "symbol.h"
@@ -49,99 +51,62 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool, {struct ksymbol_event *ksymbol_event = &event->ksymbol_event;struct bpf_event *bpf_event = &event->bpf_event; -u32 sub_prog_cnt, i, func_info_rec_size =0 ; -u8 (*prog_tags)[BPF_TAG_SIZE ] =NULL ; -struct bpf_prog_info info = { .type =0 , }; -u32 info_len =sizeof (info); -void *func_infos =NULL ; -u64 *prog_addrs =NULL ; +struct bpf_prog_info_linear *info_linear; +struct bpf_prog_info *info;struct btf *btf =NULL ; -u32 *prog_lens =NULL ;bool has_btf = false; -char errbuf[512 ]; +u32 sub_prog_cnt, i;int err =0 ; +u64 arrays; -/* Call bpf_obj_get_info_by_fd() to get sizes of arrays */ - err =bpf_obj_get_info_by_fd (fd, &info, &info_len); + arrays =1UL <<BPF_PROG_INFO_JITED_KSYMS ; + arrays |=1UL <<BPF_PROG_INFO_JITED_FUNC_LENS ; + arrays |=1UL <<BPF_PROG_INFO_FUNC_INFO ; + arrays |=1UL <<BPF_PROG_INFO_PROG_TAGS ; -if (err) { -pr_debug ("%s: failed to get BPF program info: %s, aborting\n" , - __func__,str_error_r (errno, errbuf,sizeof (errbuf))); + info_linear =bpf_program__get_prog_info_linear (fd, arrays); +if (IS_ERR_OR_NULL (info_linear)) { + info_linear =NULL ; +pr_debug ("%s: failed to get BPF program info. aborting\n" , __func__);return -1 ; } -if (info_len < offsetof(struct bpf_prog_info , prog_tags)) { + +if (info_linear->info_len < offsetof(struct bpf_prog_info , prog_tags)) {pr_debug ("%s: the kernel is too old, aborting\n" , __func__);return -2 ; } + info = &info_linear->info; +/* number of ksyms, func_lengths, and tags should match */ - sub_prog_cnt = info.nr_jited_ksyms; -if (sub_prog_cnt != info.nr_prog_tags || - sub_prog_cnt != info.nr_jited_func_lens) + sub_prog_cnt = info->nr_jited_ksyms; +if (sub_prog_cnt != info->nr_prog_tags || + sub_prog_cnt != info->nr_jited_func_lens)return -1 ;/* check BTF func info support */ -if (info.btf_id && info.nr_func_info && info.func_info_rec_size) { +if (info->btf_id && info->nr_func_info && info->func_info_rec_size) {/* btf func info number should be same as sub_prog_cnt */ -if (sub_prog_cnt != info.nr_func_info) { +if (sub_prog_cnt != info->nr_func_info) {pr_debug ("%s: mismatch in BPF sub program count and BTF function info count, aborting\n" , __func__); -return -1 ; - } -if (btf__get_from_id (info.btf_id, &btf)) { -pr_debug ("%s: failed to get BTF of id %u, aborting\n" , __func__, info.btf_id); -return -1 ; + err =-1 ; + goto out; } - func_info_rec_size = info.func_info_rec_size; - func_infos =calloc (sub_prog_cnt, func_info_rec_size); -if (!func_infos) { -pr_debug ("%s: failed to allocate memory for func_infos, aborting\n" , __func__); -return -1 ; +if (btf__get_from_id (info->btf_id, &btf)) { +pr_debug ("%s: failed to get BTF of id %u, aborting\n" , __func__, info->btf_id); + err =-1 ; + btf =NULL ; + goto out; } has_btf = true; } -/* -* We need address, length, and tag for each sub program. -* Allocate memory and call bpf_obj_get_info_by_fd() again -*/ - prog_addrs =calloc (sub_prog_cnt,sizeof (u64)); -if (!prog_addrs) { -pr_debug ("%s: failed to allocate memory for prog_addrs, aborting\n" , __func__); - goto out; - } - prog_lens =calloc (sub_prog_cnt,sizeof (u32)); -if (!prog_lens) { -pr_debug ("%s: failed to allocate memory for prog_lens, aborting\n" , __func__); - goto out; - } - prog_tags =calloc (sub_prog_cnt,BPF_TAG_SIZE ); -if (!prog_tags) { -pr_debug ("%s: failed to allocate memory for prog_tags, aborting\n" , __func__); - goto out; - } - -memset (&info,0 ,sizeof (info)); - info.nr_jited_ksyms = sub_prog_cnt; - info.nr_jited_func_lens = sub_prog_cnt; - info.nr_prog_tags = sub_prog_cnt; - info.jited_ksyms =ptr_to_u64 (prog_addrs); - info.jited_func_lens =ptr_to_u64 (prog_lens); - info.prog_tags =ptr_to_u64 (prog_tags); - info_len =sizeof (info); -if (has_btf) { - info.nr_func_info = sub_prog_cnt; - info.func_info_rec_size = func_info_rec_size; - info.func_info =ptr_to_u64 (func_infos); - } - - err =bpf_obj_get_info_by_fd (fd, &info, &info_len); -if (err) { -pr_debug ("%s: failed to get BPF program info, aborting\n" , __func__); - goto out; - } -/* Synthesize PERF_RECORD_KSYMBOL */ for (i =0 ; i < sub_prog_cnt; i++) { +u8 (*prog_tags)[BPF_TAG_SIZE ] = (void *)(info->prog_tags); +__u32 *prog_lens = (__u32 *)(info->jited_func_lens); +__u64 *prog_addrs = (__u64 *)(info->jited_ksyms); +void *func_infos = (void *)(info->func_info);const struct bpf_func_info *finfo;const char *short_name =NULL ;const struct btf_type *t;
@@ -163,13 +128,13 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool,KSYM_NAME_LEN - name_len, prog_tags[i], BPF_TAG_SIZE);if (has_btf) { - finfo = func_infos + i * info.func_info_rec_size; + finfo = func_infos + i * info->func_info_rec_size; t =btf__type_by_id (btf, finfo->type_id); short_name =btf__name_by_offset (btf, t->name_off); }else if (i ==0 && sub_prog_cnt ==1 ) {/* no subprog */ -if (info.name[0 ]) - short_name = info.name; +if (info->name[0 ]) + short_name = info->name; }else short_name ="F" ;if (short_name)
@@ -195,9 +160,9 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool, }, .type = PERF_BPF_EVENT_PROG_LOAD, .flags = 0, - .id = info.id, + .id = info->id, }; -memcpy (bpf_event->tag, prog_tags[i],BPF_TAG_SIZE ); +memcpy (bpf_event->tag, info->tag,BPF_TAG_SIZE );memset ((void *)event + event->header.size,0 , machine->id_hdr_size); event->header.size += machine->id_hdr_size; err = perf_tool__process_synth_event(tool, event,
@@ -205,10 +170,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool, } out: -free (prog_tags); -free (prog_lens); -free (prog_addrs); -free (func_infos); +free (info_linear);free (btf);return err ?-1 :0 ; }
Signature · 1 line
2.17.1
PATCH v4 5/15 perf: change prototype of perf_event__synthesize_bpf_events()
In reply to Song LiuThis patch changes the arguments of perf_event__synthesize_bpf_events() to include perf_session* instead of perf_tool*. perf_session will be used in the next patch.
--- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-top.c | 2 +- tools/perf/util/bpf-event.c | 8 +++++--- tools/perf/util/bpf-event.h | 4 ++-- 4 files changed, 9 insertions(+), 7 deletions(-)
tools/perf/builtin-record.c +1 -1
@@ -1083,7 +1083,7 @@ static int record__synthesize(struct record *rec, bool tail)return err; } - err =perf_event__synthesize_bpf_events (tool, process_synthesized_event, + err =perf_event__synthesize_bpf_events (session, process_synthesized_event, machine, opts);if (err <0 )pr_warning ("Couldn't synthesize bpf events.\n" );
tools/perf/builtin-top.c +1 -1
@@ -1216,7 +1216,7 @@ static int __cmd_top(struct perf_top *top)init_process_thread (top); - ret =perf_event__synthesize_bpf_events (&top->tool, perf_event__process, + ret =perf_event__synthesize_bpf_events (top->session, perf_event__process, &top->session->machines.host, &top->record_opts);if (ret <0 )
tools/perf/util/bpf-event.c +5 -3
@@ -10,6 +10,7 @@#include "debug.h" #include "symbol.h" #include "machine.h" +#include "session.h" #define ptr_to_u64 (ptr) ((__u64)(unsigned long)(ptr))
@@ -42,7 +43,7 @@ int machine__process_bpf_event(struct machine *machine __maybe_unused,* -1 for failures; * -2 for lack of kernel support. */ -static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool, +static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, perf_event__handler_t process, struct machine *machine, int fd,
@@ -52,6 +53,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool,struct ksymbol_event *ksymbol_event = &event->ksymbol_event;struct bpf_event *bpf_event = &event->bpf_event;struct bpf_prog_info_linear *info_linear; +struct perf_tool *tool = session->tool;struct bpf_prog_info *info;struct btf *btf =NULL ;bool has_btf = false;
@@ -175,7 +177,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_tool *tool,return err ?-1 :0 ; } -int perf_event__synthesize_bpf_events (struct perf_tool *tool, +int perf_event__synthesize_bpf_events (struct perf_session *session,perf_event__handler_t process,struct machine *machine,struct record_opts *opts)
@@ -209,7 +211,7 @@ int perf_event__synthesize_bpf_events(struct perf_tool *tool,continue ; } - err =perf_event__synthesize_one_bpf_prog (tool, process, + err =perf_event__synthesize_one_bpf_prog (session, process, machine, fd, event, opts);close (fd);
tools/perf/util/bpf-event.h +2 -2
@@ -15,7 +15,7 @@ struct record_opts;int machine__process_bpf_event (struct machine *machine,union perf_event *event,struct perf_sample *sample); -int perf_event__synthesize_bpf_events (struct perf_tool *tool, +int perf_event__synthesize_bpf_events (struct perf_session *session,perf_event__handler_t process,struct machine *machine,struct record_opts *opts);
@@ -27,7 +27,7 @@ static inline int machine__process_bpf_event(struct machine *machine __maybe_unureturn 0 ; } -static inline int perf_event__synthesize_bpf_events (struct perf_tool *tool__maybe_unused , +static inline int perf_event__synthesize_bpf_events (struct perf_session *session__maybe_unused ,perf_event__handler_t process__maybe_unused ,struct machine *machine__maybe_unused ,struct record_opts *opts__maybe_unused )
Signature · 1 line
2.17.1
PATCH v4 6/15 perf, bpf: save bpf_prog_info in a rbtree in perf_env
In reply to Song Liubpf_prog_info contains information necessary to annotate bpf programs. This patch saves bpf_prog_info for bpf programs loaded in the system.
--- tools/perf/util/bpf-event.c | 32 +++++++++++++- tools/perf/util/bpf-event.h | 7 ++- tools/perf/util/env.c | 85 +++++++++++++++++++++++++++++++++++++ tools/perf/util/env.h | 17 ++++++++ 4 files changed, 139 insertions(+), 2 deletions(-)
tools/perf/util/bpf-event.c +31 -1
@@ -10,6 +10,7 @@#include "debug.h" #include "symbol.h" #include "machine.h" +#include "env.h" #include "session.h" #define ptr_to_u64 (ptr) ((__u64)(unsigned long)(ptr))
@@ -54,17 +55,28 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,struct bpf_event *bpf_event = &event->bpf_event;struct bpf_prog_info_linear *info_linear;struct perf_tool *tool = session->tool; +struct bpf_prog_info_node *info_node;struct bpf_prog_info *info;struct btf *btf =NULL ;bool has_btf = false; +struct perf_env *env;u32 sub_prog_cnt, i;int err =0 ;u64 arrays; +/* +* for perf-record and perf-report use header.env; +* otherwise, use global perf_env. +*/ + env = session->data ? &session->header.env : &perf_env; + arrays =1UL <<BPF_PROG_INFO_JITED_KSYMS ; arrays |=1UL <<BPF_PROG_INFO_JITED_FUNC_LENS ; arrays |=1UL <<BPF_PROG_INFO_FUNC_INFO ; arrays |=1UL <<BPF_PROG_INFO_PROG_TAGS ; + arrays |=1UL <<BPF_PROG_INFO_JITED_INSNS ; + arrays |=1UL <<BPF_PROG_INFO_LINE_INFO ; + arrays |=1UL <<BPF_PROG_INFO_JITED_LINE_INFO ; info_linear =bpf_program__get_prog_info_linear (fd, arrays);if (IS_ERR_OR_NULL (info_linear)) {
@@ -153,8 +165,8 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, machine, process); } -/* Synthesize PERF_RECORD_BPF_EVENT */ if (opts->bpf_event) { +/* Synthesize PERF_RECORD_BPF_EVENT */ *bpf_event = (struct bpf_event ){ .header = { .type =PERF_RECORD_BPF_EVENT ,
@@ -167,6 +179,24 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,memcpy (bpf_event->tag, info->tag,BPF_TAG_SIZE );memset ((void *)event + event->header.size,0 , machine->id_hdr_size); event->header.size += machine->id_hdr_size; + +/* save bpf_prog_info to env */ + info_node =malloc (sizeof (struct bpf_prog_info_node )); + +/* +* Do not bail out for !info_node, as we still want to +* call perf_tool__process_synth_event() +*/ +if (info_node) { + info_node->info_linear = info_linear; +perf_env__insert_bpf_prog_info (env, info_node); + info_linear =NULL ; + } + +/* +* process after saving bpf_prog_info to env, so that +* required information is ready for look up +*/ err =perf_tool__process_synth_event (tool, event, machine, process); }
tools/perf/util/bpf-event.h +6 -1
@@ -3,14 +3,19 @@#define __PERF_BPF_EVENT_H#include <linux/compiler.h> +#include <linux/rbtree.h> #include "event.h" struct machine ;union perf_event ;struct perf_sample ; -struct perf_tool ;struct record_opts ; +struct bpf_prog_info_node { +struct bpf_prog_info_linear *info_linear; +struct rb_node rb_node; +}; +#ifdef HAVE_LIBBPF_SUPPORT int machine__process_bpf_event (struct machine *machine,union perf_event *event,struct perf_sample *sample);
tools/perf/util/env.c +85 -0
112 lines not on this page · raw message
tools/perf/util/env.h +17 -0
@@ -3,7 +3,9 @@#define __PERF_ENV_H#include <linux/types.h> +#include <linux/rbtree.h> #include "cpumap.h" +#include "rwsem.h" struct cpu_topology_map {int socket_id;
@@ -64,8 +66,19 @@ struct perf_env {struct memory_node *memory_nodes;unsigned long long memory_bsize;u64 clockid_res_ns; + +/* +* bpf_info_lock protects bpf rbtrees. This is needed because the +* trees are accessed by different threads in perf-top +*/ +struct { +struct rw_semaphore lock; +struct rb_root prog_infos; + } bpf_progs; }; +struct bpf_prog_info_node ; +extern struct perf_env perf_env;void perf_env__exit (struct perf_env *env);
@@ -80,4 +93,8 @@ const char *perf_env__arch(struct perf_env *env);const char *perf_env__raw_arch (struct perf_env *env);int perf_env__nr_cpus_avail (struct perf_env *env); +void perf_env__insert_bpf_prog_info (struct perf_env *env, +struct bpf_prog_info_node *info_node); +struct bpf_prog_info_node *perf_env__find_bpf_prog_info (struct perf_env *env, +__u32 prog_id);#endif /* __PERF_ENV_H */
Signature · 1 line
2.17.1
Re: [PATCH v4 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env
Quoted 63 lines · Song Liu
bpf_prog_infocontains information necessary to annotate bpf programs. This patch savesbpf_prog_infofor bpf programs loaded in the system.Signed-off-by Song Liu <[email protected]>--- tools/perf/util/bpf-event.c | 32 +++++++++++++- tools/perf/util/bpf-event.h | 7 ++- tools/perf/util/env.c | 85 +++++++++++++++++++++++++++++++++++++ tools/perf/util/env.h | 17 ++++++++ 4 files changed, 139 insertions(+), 2 deletions(-)tools/perf/util/bpf-event.c +13
-1@@ -10,6 +10,7 @@#include "debug.h" #include "symbol.h" #include "machine.h" +#include "env.h" #include "session.h" #define ptr_to_u64 (ptr) ((__u64)(unsigned long)(ptr))@@ -54,17 +55,28 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,struct bpf_event *bpf_event = &event->bpf_event;struct bpf_prog_info_linear *info_linear;struct perf_tool *tool = session->tool; +struct bpf_prog_info_node *info_node;struct bpf_prog_info *info;struct btf *btf =NULL ;bool has_btf = false; +struct perf_env *env;u32 sub_prog_cnt, i;int err =0 ;u64 arrays; +/* +* for perf-record and perf-report use header.env; +* otherwise, use global perf_env. +*/ + env = session->data ? &session->header.env : &perf_env; + arrays =1UL <<BPF_PROG_INFO_JITED_KSYMS ; arrays |=1UL <<BPF_PROG_INFO_JITED_FUNC_LENS ; arrays |=1UL <<BPF_PROG_INFO_FUNC_INFO ; arrays |=1UL <<BPF_PROG_INFO_PROG_TAGS ; + arrays |=1UL <<BPF_PROG_INFO_JITED_INSNS ; + arrays |=1UL <<BPF_PROG_INFO_LINE_INFO ; + arrays |=1UL <<BPF_PROG_INFO_JITED_LINE_INFO ; info_linear =bpf_program__get_prog_info_linear (fd, arrays);if (IS_ERR_OR_NULL (info_linear)) {@@ -153,8 +165,8 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, machine, process); } -/* Synthesize PERF_RECORD_BPF_EVENT */ if (opts->bpf_event) { +/* Synthesize PERF_RECORD_BPF_EVENT */ *bpf_event = (struct bpf_event ){ .header = { .type =PERF_RECORD_BPF_EVENT ,
tools/perf/util/bpf-event.c static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, · line 183
Quoted 5 lines
tools/perf/util/bpf-event.c +2
-0@@ -167,6 +179,24 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,memcpy (bpf_event->tag, info->tag,BPF_TAG_SIZE );memset ((void *)event + event->header.size,0 , machine->id_hdr_size); event->header.size += machine->id_hdr_size; + +/* save bpf_prog_info to env */
why do we save this to perf_env in here? we just
synthesize the same data as event, so report and
top will read it and fill perf_env again, right?
could you please explain the whole flow of the
bpf events and its respective data in perf_env
and put it into the changelog
tools/perf/util/bpf-event.c static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, · line 188
Quoted 5 lines
tools/perf/util/bpf-event.c +5
-0+ info_node =malloc (sizeof (struct bpf_prog_info_node )); + +/* +* Do not bail out for !info_node, as we still want to +* call perf_tool__process_synth_event()
well, we are out of memory, so I dont think perf_tool__process_synth_event will get too far.. also the perf_env data would be inconsistent with what you store as event.. how can that work?
thanks,
jirka
Quoted 7 lines
tools/perf/util/bpf-event.c +7
-0+*/ +if (info_node) { + info_node->info_linear = info_linear; +perf_env__insert_bpf_prog_info (env, info_node); + info_linear =NULL ; + } +
SNIP
Re: [PATCH v4 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env
Quoted 61 lines · Jiri Olsa
Quoted 56 lines · Song Liu
bpf_prog_infocontains information necessary to annotate bpf programs. This patch savesbpf_prog_infofor bpf programs loaded in the system.Signed-off-by Song Liu <[email protected]>---
tools/perf/util/bpf-event.c | 32 +++++++++++++- tools/perf/util/bpf-event.h | 7 ++- tools/perf/util/env.c | 85 +++++++++++++++++++++++++++++++++++++ tools/perf/util/env.h | 17 ++++++++ 4 files changed, 139 insertions(+), 2 deletions(-)tools/perf/util/bpf-event.c +12
-0@@ -10,6 +10,7 @@#include "debug.h" #include "symbol.h" #include "machine.h" +#include "env.h" #include "session.h" #define ptr_to_u64 (ptr) ((__u64)(unsigned long)(ptr))@@ -54,17 +55,28 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,struct bpf_event *bpf_event = &event->bpf_event;struct bpf_prog_info_linear *info_linear;struct perf_tool *tool = session->tool; +struct bpf_prog_info_node *info_node;struct bpf_prog_info *info;struct btf *btf =NULL ;bool has_btf = false; +struct perf_env *env;u32 sub_prog_cnt, i;int err =0 ;u64 arrays; +/* +* for perf-record and perf-report use header.env; +* otherwise, use global perf_env. +*/ + env = session->data ? &session->header.env : &perf_env; + arrays =1UL <<BPF_PROG_INFO_JITED_KSYMS ; arrays |=1UL <<BPF_PROG_INFO_JITED_FUNC_LENS ; arrays |=1UL <<BPF_PROG_INFO_FUNC_INFO ; arrays |=1UL <<BPF_PROG_INFO_PROG_TAGS ; + arrays |=1UL <<BPF_PROG_INFO_JITED_INSNS ; + arrays |=1UL <<BPF_PROG_INFO_LINE_INFO ; + arrays |=1UL <<BPF_PROG_INFO_JITED_LINE_INFO ; info_linear =bpf_program__get_prog_info_linear (fd, arrays);if (IS_ERR_OR_NULL (info_linear)) {@@ -153,8 +165,8 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, machine, process); }
Quoted 16 lines
tools/perf/util/bpf-event.c static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, · line 183
Quoted 12 lines
tools/perf/util/bpf-event.c +3
-1-/* Synthesize PERF_RECORD_BPF_EVENT */ if (opts->bpf_event) { +/* Synthesize PERF_RECORD_BPF_EVENT */ *bpf_event = (struct bpf_event ){ .header = { .type =PERF_RECORD_BPF_EVENT ,@@ -167,6 +179,24 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session,memcpy (bpf_event->tag, info->tag,BPF_TAG_SIZE );memset ((void *)event + event->header.size,0 , machine->id_hdr_size); event->header.size += machine->id_hdr_size; + +/* save bpf_prog_info to env */ why do we save this to
perf_envin here? we just
synthesize the same data as event, so report and
top will read it and fillperf_envagain, right?
The synthesized events are same as PERF_RECORD_BPF_EVENT PROG_LOAD. We need to process them and fill perf_env as soon as we get PROG_LOAD. Otherwise, the program might unload before we process them.
Quoted 4 lines
could you please explain the whole flow of the
bpf events and its respective data inperf_env
and put it into the changelog
I will add more information to the change log.
Quoted 10 lines
tools/perf/util/bpf-event.c static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, · line 188
Quoted 6 lines
tools/perf/util/bpf-event.c +5
-0+ info_node =malloc (sizeof (struct bpf_prog_info_node )); + +/* +* Do not bail out for !info_node, as we still want to +* call perf_tool__process_synth_event() well, we are out of memory, so I dont think
perf_tool__process_synth_eventwill get too far.. also theperf_envdata would be inconsistent with what you store as event.. how can that work?
It is OK we have PERF_RECORD_BPF_EVENT but not related bpf_prog_info and btf. The perf.data file will show a BPF program was loaded, but we won't be able to do annotation. Does this make sense?
Thanks,
Song
Quoted 13 lines
thanks,
jirkaQuoted 7 lines
tools/perf/util/bpf-event.c +7
-0+*/ +if (info_node) { + info_node->info_linear = info_linear; +perf_env__insert_bpf_prog_info (env, info_node); + info_linear =NULL ; + } +SNIP
Re: [PATCH v4 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env
In reply to Song LiuOn Mon, Feb 25, 2019 at 04:20:10PM -0800, Song Liu wrote:
SNIP
Quoted 14 lines
tools/perf/util/env.c +6
-0@@ -38,6 +116,12 @@ void perf_env__exit(struct perf_env *env)zfree (&env->memory_nodes); } +static void init_bpf_rb_trees (struct perf_env *env) +{ + env->bpf_progs.prog_infos =RB_ROOT ; +init_rwsem (&env->bpf_progs.lock); +} +int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]) {int i;
tools/perf/util/env.c int perf_env__set_cmdline(struct perf_env *env, int argc, const char *argv[]) · line 146
Quoted 4 lines
tools/perf/util/env.c +1
-0@@ -59,6 +143,7 @@ int perf_env__set_cmdline(struct perf_env *env, int argc, const char *argv[]) env->nr_cmdline = argc; +init_bpf_rb_trees (env);
this souldn't be in perf_env__set_cmdline, it's there to set the cmdline
struct bpf_progs is first in perf_env that needs other than zero initialization, so I think we need to add perf_env__init function, that will do that for all the paths that uses perf_env
jirka
Re: [PATCH v4 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env
In reply to Song LiuOn Mon, Feb 25, 2019 at 04:20:10PM -0800, Song Liu wrote:
SNIP
Quoted 16 lines
tools/perf/util/env.h +2
-0@@ -3,7 +3,9 @@#define __PERF_ENV_H#include <linux/types.h> +#include <linux/rbtree.h> #include "cpumap.h" +#include "rwsem.h" struct cpu_topology_map {int socket_id;@@ -64,8 +66,19 @@ struct perf_env {struct memory_node *memory_nodes;
tools/perf/util/env.h struct perf_env { · line 76
Quoted 10 lines
tools/perf/util/env.h +8
-0unsigned long long memory_bsize;u64 clockid_res_ns; + +/* +* bpf_info_lock protects bpf rbtrees. This is needed because the +* trees are accessed by different threads in perf-top +*/ +struct { +struct rw_semaphore lock; +struct rb_root prog_infos;
could be just 'infos' ^^^^ is already in struct name
tools/perf/util/env.h struct perf_env { · line 79
Quoted 3 lines
tools/perf/util/env.h +1
-0+ } bpf_progs; };
jirka
PATCH v4 7/15 perf, bpf: save bpf_prog_info information as headers to perf.data
In reply to Song LiuThis patch enables perf-record to save bpf_prog_info information as headers to perf.data. A new header type HEADER_BPF_PROG_INFO is introduced for this data.
--- tools/perf/util/header.c | 143 ++++++++++++++++++++++++++++++++++++++- tools/perf/util/header.h | 1 + 2 files changed, 143 insertions(+), 1 deletion(-)
tools/perf/util/header.c +142 -1
@@ -18,6 +18,7 @@#include <sys/utsname.h> #include <linux/time64.h> #include <dirent.h> +#include <bpf/libbpf.h> #include "evlist.h" #include "evsel.h"
@@ -39,6 +40,7 @@#include "tool.h" #include "time-utils.h" #include "units.h" +#include "bpf-event.h" #include "sane_ctype.h"
@@ -1080,6 +1082,51 @@ static int write_clockid(struct feat_fd *ff, sizeof(ff->ph->env.clockid_res_ns)); } +static int write_bpf_prog_info (struct feat_fd *ff, +struct perf_evlist *evlist__maybe_unused ) +{ +struct perf_env *env = &ff->ph->env; +struct rb_root *root; +struct rb_node *next; +u32 count =0 ; +int ret; + +down_read (&env->bpf_progs.lock); + + root = &env->bpf_progs.prog_infos; + next =rb_first (root); +while (next) { + ++count; + next =rb_next (next); + } + + ret =do_write (ff, &count,sizeof (count)); + +if (ret <0 ) + goto out; + + next =rb_first (root); +while (next) { +struct bpf_prog_info_node *node; +size_t len; + + node = rb_entry(next, struct bpf_prog_info_node, rb_node); + next =rb_next (&node->rb_node); + len =sizeof (struct bpf_prog_info_linear ) + + node->info_linear->data_len; + +/* before writing to file, translate address to offset */ +bpf_program__bpil_addr_to_offs (node->info_linear); + ret =do_write (ff, node->info_linear, len); +bpf_program__bpil_offs_to_addr (node->info_linear); +if (ret <0 ) + goto out; + } +out: +up_read (&env->bpf_progs.lock); +return ret; +} +static int cpu_cache_level__sort (const void *a,const void *b) {struct cpu_cache_level *cache_a = (struct cpu_cache_level *)a;
@@ -1560,6 +1607,29 @@ static void print_clockid(struct feat_fd *ff, FILE *fp) ff->ph->env.clockid_res_ns * 1000); } +static void print_bpf_prog_info (struct feat_fd *ff,FILE *fp) +{ +struct perf_env *env = &ff->ph->env; +struct rb_root *root; +struct rb_node *next; + +down_read (&env->bpf_progs.lock); + + root = &env->bpf_progs.prog_infos; + next =rb_first (root); + +while (next) { +struct bpf_prog_info_node *node; + + node = rb_entry(next, struct bpf_prog_info_node, rb_node); + next =rb_next (&node->rb_node); +fprintf (fp,"# bpf_prog_info of id %u\n" , + node->info_linear->info.id); + } + +up_read (&env->bpf_progs.lock); +} +static void free_event_desc (struct perf_evsel *events) {struct perf_evsel *evsel;
@@ -2592,6 +2662,76 @@ static int process_clockid(struct feat_fd *ff,return 0 ; } +static int process_bpf_prog_info (struct feat_fd *ff, +void *data__maybe_unused ) +{ +struct bpf_prog_info_linear *info_linear; +struct bpf_prog_info_node *info_node; +struct perf_env *env = &ff->ph->env; +u32 count, i; +int err =-1 ; + +if (do_read_u32 (ff, &count)) +return -1 ; + +down_write (&env->bpf_progs.lock); + +for (i =0 ; i < count; ++i) { +u32 info_len, data_len; + + info_linear =NULL ; + info_node =NULL ; +if (do_read_u32 (ff, &info_len)) + goto out; +if (do_read_u32 (ff, &data_len)) + goto out; + +if (info_len >sizeof (struct bpf_prog_info )) { +pr_warning ("detected invalid bpf_prog_info\n" ); + goto out; + } + + info_linear =malloc (sizeof (struct bpf_prog_info_linear ) + + data_len); +if (!info_linear) + goto out; + info_linear->info_len =sizeof (struct bpf_prog_info ); + info_linear->data_len = data_len; +if (do_read_u64 (ff, (u64 *)(&info_linear->arrays))) + goto out; +if (__do_read (ff, &info_linear->info, info_len)) + goto out; +if (info_len <sizeof (struct bpf_prog_info )) +memset (((void *)(&info_linear->info)) + info_len,0 , +sizeof (struct bpf_prog_info ) - info_len); + +if (__do_read (ff, info_linear->data, data_len)) + goto out; + +/* endian mismatch, drop the info, continue */ +if (ff->ph->needs_swap) { +free (info_linear); +continue ; + } + + info_node =malloc (sizeof (struct bpf_prog_info_node )); +if (!info_node) + goto out; + +/* after reading from file, translate offset to address */ +bpf_program__bpil_offs_to_addr (info_linear); + info_node->info_linear = info_linear; +perf_env__insert_bpf_prog_info (env, info_node); + } + +return 0 ; +out: +free (info_linear); +free (info_node); +up_write (&env->bpf_progs.lock); +return err; +} +struct feature_ops {int (*write)(struct feat_fd *ff,struct perf_evlist *evlist);void (*print)(struct feat_fd *ff,FILE *fp);
@@ -2651,7 +2791,8 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {FEAT_OPN (CACHE , cache, true),FEAT_OPR (SAMPLE_TIME , sample_time, false),FEAT_OPR (MEM_TOPOLOGY , mem_topology, true), -FEAT_OPR (CLOCKID , clockid, false) +FEAT_OPR (CLOCKID , clockid, false), +FEAT_OPR (BPF_PROG_INFO , bpf_prog_info, false) }; struct header_print_data {
tools/perf/util/header.h +1 -0
@@ -39,6 +39,7 @@ enum {HEADER_SAMPLE_TIME ,HEADER_MEM_TOPOLOGY ,HEADER_CLOCKID , +HEADER_BPF_PROG_INFO ,HEADER_LAST_FEATURE , HEADER_FEAT_BITS = 256, };
Signature · 1 line
2.17.1
Re: [PATCH v4 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data
On Mon, Feb 25, 2019 at 04:20:11PM -0800, Song Liu wrote:
SNIP
Quoted 13 lines
tools/perf/util/header.c +13
-0+if (info_len >sizeof (struct bpf_prog_info )) { +pr_warning ("detected invalid bpf_prog_info\n" ); + goto out; + } + + info_linear =malloc (sizeof (struct bpf_prog_info_linear ) + + data_len); +if (!info_linear) + goto out; + info_linear->info_len =sizeof (struct bpf_prog_info ); + info_linear->data_len = data_len; +if (do_read_u64 (ff, (u64 *)(&info_linear->arrays))) + goto out;
tools/perf/util/header.c static int process_clockid(struct feat_fd *ff, · line 2711
Quoted 10 lines
tools/perf/util/header.c +10
-0+if (__do_read (ff, &info_linear->info, info_len)) + goto out; +if (info_len <sizeof (struct bpf_prog_info )) +memset (((void *)(&info_linear->info)) + info_len,0 , +sizeof (struct bpf_prog_info ) - info_len); + +if (__do_read (ff, info_linear->data, data_len)) + goto out; + +/* endian mismatch, drop the info, continue */
so there's no way we can swap the data? why?
jirka
Quoted 4 lines
tools/perf/util/header.c +4
-0+if (ff->ph->needs_swap) { +free (info_linear); +continue ; + }
SNIP
Re: [PATCH v4 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data
Quoted 34 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:11PM -0800, Song Liu wrote:
SNIP
Quoted 13 lines
tools/perf/util/header.c +13
-0+if (info_len >sizeof (struct bpf_prog_info )) { +pr_warning ("detected invalid bpf_prog_info\n" ); + goto out; + } + + info_linear =malloc (sizeof (struct bpf_prog_info_linear ) + + data_len); +if (!info_linear) + goto out; + info_linear->info_len =sizeof (struct bpf_prog_info ); + info_linear->data_len = data_len; +if (do_read_u64 (ff, (u64 *)(&info_linear->arrays))) + goto out;tools/perf/util/header.c static int process_clockid(struct feat_fd *ff, · line 2711
Quoted 10 lines
tools/perf/util/header.c +10
-0+if (__do_read (ff, &info_linear->info, info_len)) + goto out; +if (info_len <sizeof (struct bpf_prog_info )) +memset (((void *)(&info_linear->info)) + info_len,0 , +sizeof (struct bpf_prog_info ) - info_len); + +if (__do_read (ff, info_linear->data, data_len)) + goto out; + +/* endian mismatch, drop the info, continue */ so there's no way we can swap the data? why?
Quoted 1 line
jirka
Yes, we can swap the data. OTOH, the set is big enough. How about we implement the swap later? Running perf-report on a system of with different endianness is a relatively rare case.
Thanks,
Song
Quoted 6 lines
Quoted 4 lines
tools/perf/util/header.c +4
-0+if (ff->ph->needs_swap) { +free (info_linear); +continue ; + }SNIP
PATCH v4 8/15 perf, bpf: save btf in a rbtree in perf_env
In reply to Song Liubtf contains information necessary to annotate bpf programs. This patch saves btf for bpf programs loaded in the system.
--- tools/perf/util/bpf-event.c | 24 ++++++++++++++ tools/perf/util/bpf-event.h | 7 ++++ tools/perf/util/env.c | 65 +++++++++++++++++++++++++++++++++++++ tools/perf/util/env.h | 4 +++ 4 files changed, 100 insertions(+)
tools/perf/util/bpf-event.c +24 -0
@@ -34,6 +34,29 @@ int machine__process_bpf_event(struct machine *machine __maybe_unused,return 0 ; } +static int perf_env__fetch_btf (struct perf_env *env, +u32 btf_id, +struct btf *btf) +{ +struct btf_node *node; +u32 data_size; +const void *data; + + data =btf__get_raw_data (btf, &data_size); + + node =malloc (data_size +sizeof (struct btf_node )); + +if (!node) +return -1 ; + + node->id = btf_id; + node->data_size = data_size; +memcpy (node->data, data, data_size); + +perf_env__insert_btf (env, node); +return 0 ; +} +/* * Synthesize PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT for one bpf * program. One PERF_RECORD_BPF_EVENT is generated for the program. And
@@ -113,6 +136,7 @@ static int perf_event__synthesize_one_bpf_prog(struct perf_session *session, goto out; } has_btf = true; +perf_env__fetch_btf (env, info->btf_id, btf); }/* Synthesize PERF_RECORD_KSYMBOL */
tools/perf/util/bpf-event.h +7 -0
@@ -16,6 +16,13 @@ struct bpf_prog_info_node {struct rb_node rb_node; }; +struct btf_node { +struct rb_node rb_node; +u32 id; +u32 data_size; +char data[]; +}; +#ifdef HAVE_LIBBPF_SUPPORT int machine__process_bpf_event (struct machine *machine,union perf_event *event,struct perf_sample *sample);
tools/perf/util/env.c +65 -0
83 lines not on this page · raw message
tools/perf/util/env.h +4 -0
@@ -74,10 +74,12 @@ struct perf_env {struct {struct rw_semaphore lock;struct rb_root prog_infos; +struct rb_root btfs; } bpf_progs; };struct bpf_prog_info_node ; +struct btf_node ;extern struct perf_env perf_env;
@@ -97,4 +99,6 @@ void perf_env__insert_bpf_prog_info(struct perf_env *env, struct bpf_prog_info_node *info_node);struct bpf_prog_info_node *perf_env__find_bpf_prog_info (struct perf_env *env,__u32 prog_id); +void perf_env__insert_btf (struct perf_env *env,struct btf_node *btf_node); +struct btf_node *perf_env__find_btf (struct perf_env *env,__u32 btf_id);#endif /* __PERF_ENV_H */
Signature · 1 line
2.17.1
PATCH v4 9/15 perf, bpf: save btf information as headers to perf.data
In reply to Song LiuThis patch enables perf-record to save btf information as headers to perf.data A new header type HEADER_BPF_BTF is introduced for this data.
--- tools/perf/util/header.c | 108 ++++++++++++++++++++++++++++++++++++++- tools/perf/util/header.h | 1 + 2 files changed, 108 insertions(+), 1 deletion(-)
tools/perf/util/header.c +107 -1
@@ -1127,6 +1127,45 @@ static int write_bpf_prog_info(struct feat_fd *ff,return ret; } +static int write_bpf_btf (struct feat_fd *ff, +struct perf_evlist *evlist__maybe_unused ) +{ +struct perf_env *env = &ff->ph->env; +struct rb_root *root; +struct rb_node *next; +u32 count =0 ; +int ret; + +down_read (&env->bpf_progs.lock); + + root = &env->bpf_progs.btfs; + next =rb_first (root); +while (next) { + ++count; + next =rb_next (next); + } + + ret =do_write (ff, &count,sizeof (count)); + +if (ret <0 ) + goto out; + + next =rb_first (root); +while (next) { +struct btf_node *node; + + node = rb_entry(next, struct btf_node, rb_node); + next =rb_next (&node->rb_node); + ret =do_write (ff, &node->id, +sizeof (u32) *2 + node->data_size); +if (ret <0 ) + goto out; + } +out: +up_read (&env->bpf_progs.lock); +return ret; +} +static int cpu_cache_level__sort (const void *a,const void *b) {struct cpu_cache_level *cache_a = (struct cpu_cache_level *)a;
@@ -1630,6 +1669,28 @@ static void print_bpf_prog_info(struct feat_fd *ff, FILE *fp)up_read (&env->bpf_progs.lock); } +static void print_bpf_btf (struct feat_fd *ff,FILE *fp) +{ +struct perf_env *env = &ff->ph->env; +struct rb_root *root; +struct rb_node *next; + +down_read (&env->bpf_progs.lock); + + root = &env->bpf_progs.btfs; + next =rb_first (root); + +while (next) { +struct btf_node *node; + + node = rb_entry(next, struct btf_node, rb_node); + next =rb_next (&node->rb_node); +fprintf (fp,"# btf info of id %u\n" , node->id); + } + +up_read (&env->bpf_progs.lock); +} +static void free_event_desc (struct perf_evsel *events) {struct perf_evsel *evsel;
@@ -2732,6 +2793,50 @@ static int process_bpf_prog_info(struct feat_fd *ff,return err; } +static int process_bpf_btf (struct feat_fd *ff,void *data__maybe_unused ) +{ +struct perf_env *env = &ff->ph->env; +u32 count, i; + +if (do_read_u32 (ff, &count)) +return -1 ; + +down_write (&env->bpf_progs.lock); + +for (i =0 ; i < count; ++i) { +struct btf_node *node; +u32 id, data_size; + +if (do_read_u32 (ff, &id)) +return -1 ; +if (do_read_u32 (ff, &data_size)) +return -1 ; + + node =malloc (sizeof (struct btf_node ) + data_size); +if (!node) +return -1 ; + + node->id = id; + node->data_size = data_size; + +if (__do_read (ff, node->data, data_size)) { +free (node); +return -1 ; + } + +/* endian mismatch, drop the btf, continue */ +if (ff->ph->needs_swap) { +free (node); +continue ; + } + +perf_env__insert_btf (env, node); + } + +up_write (&env->bpf_progs.lock); +return 0 ; +} +struct feature_ops {int (*write)(struct feat_fd *ff,struct perf_evlist *evlist);void (*print)(struct feat_fd *ff,FILE *fp);
@@ -2792,7 +2897,8 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {FEAT_OPR (SAMPLE_TIME , sample_time, false),FEAT_OPR (MEM_TOPOLOGY , mem_topology, true),FEAT_OPR (CLOCKID , clockid, false), -FEAT_OPR (BPF_PROG_INFO , bpf_prog_info, false) +FEAT_OPR (BPF_PROG_INFO , bpf_prog_info, false), +FEAT_OPR (BPF_BTF , bpf_btf, false) }; struct header_print_data {
tools/perf/util/header.h +1 -0
@@ -40,6 +40,7 @@ enum {HEADER_MEM_TOPOLOGY ,HEADER_CLOCKID ,HEADER_BPF_PROG_INFO , +HEADER_BPF_BTF ,HEADER_LAST_FEATURE , HEADER_FEAT_BITS = 256, };
Signature · 1 line
2.17.1
PATCH v4 10/15 perf-top: add option --no-bpf-event
In reply to Song Liubpf events should be tracked by default for perf-top. This patch makes it on by default, and adds option to disable bpf events.
--- tools/perf/builtin-top.c | 3 +++ tools/perf/util/top.h | 1 + 2 files changed, 4 insertions(+)
tools/perf/builtin-top.c +3 -0
@@ -1492,6 +1492,7 @@ int cmd_top(int argc, const char **argv) "Display raw encoding of assembly instructions (default)"),OPT_BOOLEAN (0 ,"demangle-kernel" , &symbol_conf.demangle_kernel,"Enable kernel symbol demangling" ), +OPT_BOOLEAN (0 ,"no-bpf-event" , &top.no_bpf_event,"do not record bpf events" ),OPT_STRING (0 ,"objdump" , &top.annotation_opts.objdump_path,"path" ,"objdump binary to use for disassembly and annotations" ), OPT_STRING('M', "disassembler-style", &top.annotation_opts.disassembler_style, "disassembler style",
@@ -1651,6 +1652,8 @@ int cmd_top(int argc, const char **argv)signal (SIGWINCH , winch_sig); } + top.record_opts.bpf_event = !top.no_bpf_event; + status =__cmd_top (&top); out_delete_evlist:
tools/perf/util/top.h +1 -0
@@ -32,6 +32,7 @@ struct perf_top {bool use_tui, use_stdio;bool vmlinux_warned;bool dump_symtab; +bool no_bpf_event;struct hist_entry *sym_filter_entry;struct perf_evsel *sym_evsel;struct perf_session *session;
Signature · 1 line
2.17.1
PATCH v4 11/15 perf: add -lopcodes to feature-libbfd
In reply to Song LiuBoth libbfd and libopcodes are distributed with binutil-dev/devel. When libbfd presents, it is OK to assume libopcodes also presents. This has been a safe assumption for bpftool.
This patch adds -lopcodes to perf/Makefile.config. libopcodes will be used in the next commit for bpf annotation.
--- tools/perf/Makefile.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/Makefile.config +1 -1
@@ -701,7 +701,7 @@ else endif ifeq ($(feature-libbfd), 1) - EXTLIBS += -lbfd + EXTLIBS += -lbfd -lopcodes else # we are on a system that requires -liberty and (maybe) -lz # to link against -lbfd; test each case individually here
Signature · 1 line
2.17.1
PATCH v4 12/15 perf, bpf: enable annotation of bpf program
In reply to Song LiuThis patch enables the annotation of bpf program.
A new dso type DSO_BINARY_TYPE__BPF_PROG_INFO is introduced to for BPF programs. In symbol__disassemble(), DSO_BINARY_TYPE__BPF_PROG_INFO dso calls into a new function symbol__disassemble_bpf(), where annotation line information is filled based bpf_prog_info and btf saved in given perf_env.
symbol__disassemble_bpf() uses libbfd to disassemble bpf programs.
--- tools/build/Makefile.feature | 6 +- tools/perf/Makefile.config | 4 + tools/perf/util/annotate.c | 149 ++++++++++++++++++++++++++++++++++- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 33 +++++--- tools/perf/util/header.c | 7 +- tools/perf/util/symbol.c | 1 + tools/perf/util/util.c | 10 +++ tools/perf/util/util.h | 2 + 9 files changed, 193 insertions(+), 20 deletions(-)
tools/build/Makefile.feature +4 -2
@@ -71,7 +71,8 @@ FEATURE_TESTS_BASIC := \ sdt \ setns \ libopencsd \ - libaio + libaio \ + disassembler-four-args # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list # of all feature tests
@@ -118,7 +119,8 @@ FEATURE_DISPLAY ?= \ lzma \ get_cpuid \ bpf \ - libaio + libaio \ + disassembler-four-args # Set FEATURE_CHECK_(C|LD)FLAGS-all for all FEATURE_TESTS features. # If in the future we need per-feature checks/flags for features not
tools/perf/Makefile.config +4 -0
@@ -796,6 +796,10 @@ ifdef HAVE_KVM_STAT_SUPPORT CFLAGS += -DHAVE_KVM_STAT_SUPPORT endif +ifeq ($(feature-disassembler-four-args), 1) + CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE +endif + ifeq (${IS_64_BIT}, 1) ifndef NO_PERF_READ_VDSO32 $(call feature_check,compile-32)
tools/perf/util/annotate.c +148 -1
179 lines not on this page · raw message
tools/perf/util/dso.c +1 -0
@@ -181,6 +181,7 @@ int dso__read_binary_type_filename(const struct dso *dso,case DSO_BINARY_TYPE__KALLSYMS :case DSO_BINARY_TYPE__GUEST_KALLSYMS :case DSO_BINARY_TYPE__JAVA_JIT : +case DSO_BINARY_TYPE__BPF_PROG_INFO :case DSO_BINARY_TYPE__NOT_FOUND : ret =-1 ;break ;
tools/perf/util/dso.h +22 -11
@@ -14,6 +14,8 @@#include "namespaces.h" #include "build-id.h" +struct perf_env ; +enum dso_binary_type {DSO_BINARY_TYPE__KALLSYMS =0 ,DSO_BINARY_TYPE__GUEST_KALLSYMS ,
@@ -34,6 +36,7 @@ enum dso_binary_type {DSO_BINARY_TYPE__KCORE ,DSO_BINARY_TYPE__GUEST_KCORE ,DSO_BINARY_TYPE__OPENEMBEDDED_DEBUGINFO , +DSO_BINARY_TYPE__BPF_PROG_INFO , DSO_BINARY_TYPE__NOT_FOUND, };
@@ -177,17 +180,25 @@ struct dso {struct auxtrace_cache *auxtrace_cache;int comp; -/* dso data file */ -struct { -struct rb_root cache; -int fd; -int status; -u32 status_seen; -size_t file_size; -struct list_head open_entry; -u64 debug_frame_offset; -u64 eh_frame_hdr_offset; - } data; +union { +/* dso data file */ +struct { +struct rb_root cache; +int fd; +int status; +u32 status_seen; +size_t file_size; +struct list_head open_entry; +u64 debug_frame_offset; +u64 eh_frame_hdr_offset; + } data; +/* bpf prog information */ +struct { +u32 id; +u32 sub_id; +struct perf_env *env; + } bpf_prog; + };union {/* Tool specific area */ void *priv;
tools/perf/util/header.c +1 -6
@@ -533,12 +533,7 @@ static int write_cmdline(struct feat_fd *ff,int i, ret;/* actual path to perf binary */ - ret =readlink ("/proc/self/exe" , buf,sizeof (buf) -1 ); -if (ret <=0 ) -return -1 ; - -/* readlink() does not add null termination */ - buf[ret] ='\0' ; +get_exec_path (buf,sizeof (buf));/* account for binary path */ n = perf_env.nr_cmdline +1 ;
tools/perf/util/symbol.c +1 -0
@@ -1441,6 +1441,7 @@ static bool dso__is_compatible_symtab_type(struct dso *dso, bool kmod,case DSO_BINARY_TYPE__BUILD_ID_CACHE_DEBUGINFO :return true; +case DSO_BINARY_TYPE__BPF_PROG_INFO :case DSO_BINARY_TYPE__NOT_FOUND :default :return false;
tools/perf/util/util.c +10 -0
@@ -506,3 +506,13 @@ const char *perf_tip(const char *dirpath)return tip; } + +void get_exec_path (char *tpath,size_t size) +{ +const char *path ="/proc/self/exe" ; +ssize_t len; + + len =readlink (path, tpath, size -1 ); +assert (len >0 ); + tpath[len] =0 ; +}
tools/perf/util/util.h +2 -0
@@ -76,6 +76,8 @@ extern bool perf_singlethreaded;void perf_set_singlethreaded (void );void perf_set_multithreaded (void ); +void get_exec_path (char *tpath,size_t size); +#ifndef O_CLOEXEC #ifdef __sparc__#define O_CLOEXEC 0x400000
Signature · 1 line
2.17.1
Re: [PATCH v4 perf,bpf 12/15] perf, bpf: enable annotation of bpf program
On Mon, Feb 25, 2019 at 04:20:16PM -0800, Song Liu wrote:
SNIP
Quoted 8 lines
tools/perf/util/util.c +0
-0@@ -506,3 +506,13 @@ const char *perf_tip(const char *dirpath)return tip; }
tools/perf/util/util.c const char *perf_tip(const char *dirpath) · line 518
Quoted 10 lines
tools/perf/util/util.c +10
-0+ +void get_exec_path (char *tpath,size_t size) +{ +const char *path ="/proc/self/exe" ; +ssize_t len; + + len =readlink (path, tpath, size -1 ); +assert (len >0 ); + tpath[len] =0 ; +}
we have now helper for that, please rebase this on top of arnaldo's perf/core:
94816add0005 perf tools: Add perf_exe() helper to find perf binary
jirka
Re: [PATCH v4 perf,bpf 12/15] perf, bpf: enable annotation of bpf program
In reply to Song LiuOn Mon, Feb 25, 2019 at 04:20:16PM -0800, Song Liu wrote:
SNIP
tools/perf/util/annotate.c static int dso__disassemble_filename(struct dso *dso, char *filename, size_t fil · line 1797
Quoted 9 lines
tools/perf/util/annotate.c +9
-0+if (!opts->hide_src_code && srcline) { + args->offset =-1 ; + args->line =strdup (srcline); + args->line_nr =0 ; + args->ms.sym = sym; + dl =disasm_line__new (args); +if (dl) +annotation_line__add (&dl->al, + ¬es->src->source);
please use { } around multiline if leg
jirka
PATCH v4 13/15 perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation
In reply to Song LiuThis patch adds processing of PERF_BPF_EVENT_PROG_LOAD, which sets proper DSO type/id/etc of memory regions mapped to BPF programs to DSO_BINARY_TYPE__BPF_PROG_INFO
--- tools/perf/util/bpf-event.c | 53 +++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+)
tools/perf/util/bpf-event.c +53 -0
@@ -25,12 +25,65 @@ static int snprintf_hex(char *buf, size_t size, unsigned char *data, size_t len)return ret; } +static int machine__process_bpf_event_load (struct machine *machine__maybe_unused , +union perf_event *event, +struct perf_sample *sample__maybe_unused ) +{ +struct bpf_prog_info_linear *info_linear; +struct bpf_prog_info_node *info_node; +struct perf_env *env = machine->env; +int id = event->bpf_event.id; +unsigned int i; + +/* perf-record, no need to handle bpf-event */ +if (env ==NULL ) +return 0 ; + + info_node =perf_env__find_bpf_prog_info (env, id); +if (!info_node) +return 0 ; + info_linear = info_node->info_linear; + +for (i =0 ; i < info_linear->info.nr_jited_ksyms; i++) { +u64 *addrs = (u64 *)(info_linear->info.jited_ksyms); +u64 addr = addrs[i]; +struct map *map; + + map =map_groups__find (&machine->kmaps, addr); + +if (map) { + map->dso->binary_type =DSO_BINARY_TYPE__BPF_PROG_INFO ; + map->dso->bpf_prog.id = id; + map->dso->bpf_prog.sub_id = i; + map->dso->bpf_prog.env = env; + } + } +return 0 ; +} +int machine__process_bpf_event (struct machine *machine__maybe_unused ,union perf_event *event,struct perf_sample *sample__maybe_unused ) {if (dump_trace)perf_event__fprintf_bpf_event (event, stdout); + +switch (event->bpf_event.type) { +case PERF_BPF_EVENT_PROG_LOAD : +return machine__process_bpf_event_load (machine, event, sample); + +case PERF_BPF_EVENT_PROG_UNLOAD : +/* +* Do not free bpf_prog_info and btf of the program here, +* as annotation still need them. They will be freed at +* the end of the session. +*/ +break ; +default : +pr_debug ("unexpected bpf_event type of %d\n" , + event->bpf_event.type); +break ; + }return 0 ; }
Signature · 1 line
2.17.1
PATCH v4 14/15 perf: introduce side band thread
In reply to Song LiuThis patch introduces side band thread that captures extended information for events like PERF_RECORD_BPF_EVENT.
This new thread uses its own evlist that uses ring buffer with very low watermark for lower latency. In the next patch, we uses this thread to handle PERF_RECORD_BPF_EVENT.
--- tools/perf/builtin-record.c | 7 +++ tools/perf/builtin-top.c | 7 +++ tools/perf/util/evlist.c | 100 ++++++++++++++++++++++++++++++++++++ tools/perf/util/evlist.h | 13 +++++ 4 files changed, 127 insertions(+)
tools/perf/builtin-record.c +7 -0
@@ -1106,6 +1106,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)struct perf_data *data = &rec->data;struct perf_session *session;bool disabled = false, draining = false; +struct perf_evlist_sb_poll_args poll_args;int fd;atexit (record__sig_exit);
@@ -1206,6 +1207,10 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) goto out_child; } + poll_args.env = &session->header.env; + poll_args.done = &done; +perf_evlist__start_polling_thread (&rec->opts.target, &poll_args); + err =record__synthesize (rec, false);if (err <0 ) goto out_child;
@@ -1456,6 +1461,8 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) out_delete_session:perf_session__delete (session); + +perf_evlist__stop_polling_thread ();return status; }
tools/perf/builtin-top.c +7 -0
@@ -1524,6 +1524,7 @@ int cmd_top(int argc, const char **argv) "number of thread to run event synthesize"),OPT_END () }; +struct perf_evlist_sb_poll_args poll_args;const char *const top_usage[] = {"perf top [<options>]" ,NULL
@@ -1654,8 +1655,14 @@ int cmd_top(int argc, const char **argv) top.record_opts.bpf_event = !top.no_bpf_event; + poll_args.env = &perf_env; + poll_args.done = &done; +perf_evlist__start_polling_thread (target, &poll_args); + status =__cmd_top (&top); +perf_evlist__stop_polling_thread (); + out_delete_evlist:perf_evlist__delete (top.evlist);
tools/perf/util/evlist.c +100 -0
109 lines not on this page · raw message
tools/perf/util/evlist.h +13 -0
@@ -58,6 +58,12 @@ struct perf_evsel_str_handler {void *handler; }; +struct perf_evlist_sb_poll_args { +struct perf_env *env; + +volatile int *done; +}; +struct perf_evlist *perf_evlist__new (void );struct perf_evlist *perf_evlist__new_default (void );struct perf_evlist *perf_evlist__new_dummy (void );
@@ -84,6 +90,13 @@ int __perf_evlist__add_default_attrs(struct perf_evlist *evlist,int perf_evlist__add_dummy (struct perf_evlist *evlist); +int perf_evlist__new_side_band_event (struct perf_event_attr *attr); + +int perf_evlist__start_polling_thread (struct target *target, +struct perf_evlist_sb_poll_args *args); + +void perf_evlist__stop_polling_thread (void ); +int perf_evlist__add_newtp (struct perf_evlist *evlist,const char *sys,const char *name,void *handler);
Signature · 1 line
2.17.1
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 13 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h>
tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 6 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;
so some of the things are static and some like poll_args you alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated in perf_evlist, like:
struct perf_evlist {
...
struct {
pthread_t th;
int state;
} thread;
};typedef int (perf_evlist__thread_cb_t)(perf_evlist, union perf_event *event,....)
perf_evlist__start_thread(perf_evlist, perf_evlist__thread_cb_t cb); perf_evlist__stop_thread(perf_evlist);
jirka
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
Quoted 20 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 12 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h>
Quoted 12 lines
tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 7 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:
I picked global sb_evlist and poll_thread because there should be only one sb_evlist and one thread polling it. There might be multiple evsel on the sb_evlist.
I am not sure I understand your suggestion..
Quoted 6 lines
struct perf_evlist {
...
struct {
pthread_t th;
int state;
} thread;This will not be used by the main perf_evlist, right?
Quoted 3 lines
};
typedef int (perf_evlist__thread_cb_t)(perf_evlist, union
perf_event*event,....)
How do we use this callback? We need a way to specify which events to poll (mmap, bpf_event, ksymbol, etc). How do we do that with the callback function?
Thanks,
Song
Quoted 5 lines
perf_evlist__start_thread(perf_evlist, perf_evlist__thread_cb_t cb);perf_evlist__stop_thread(perf_evlist);jirka
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
Quoted 39 lines · Song Liu
Quoted 20 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 12 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h> Quoted 12 lines
tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 7 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:I picked global
sb_evlistandpoll_threadbecause there should be only onesb_evlistand one thread polling it. There might be multiple evsel on thesb_evlist.I am not sure I understand your suggestion..
Quoted 8 lines
Quoted 6 lines
struct perf_evlist { ... struct { pthread_t th; int state; } thread;This will not be used by the main
perf_evlist, right?
no, just by the thread interface
Quoted 8 lines
Quoted 4 lines
};
typedef int (perf_evlist__thread_cb_t)(perf_evlist, union
perf_event*event,....)How do we use this callback? We need a way to specify which events to poll (mmap,
bpf_event, ksymbol, etc). How do we do that with the callback function?
you provide your own callback
jirka
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
Quoted 51 lines · Jiri Olsa
Quoted 46 lines · Song Liu
Quoted 20 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 12 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h> Quoted 12 lines
tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 7 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:I picked global
sb_evlistandpoll_threadbecause there should be only onesb_evlistand one thread polling it. There might be multiple evsel on thesb_evlist.I am not sure I understand your suggestion..
Quoted 6 lines
struct perf_evlist { ... struct { pthread_t th; int state; } thread;
Quoted 3 lines
Quoted 1 line
This will not be used by the main
perf_evlist, right?no, just by the thread interface
What is "state" here?
Quoted 11 lines
Quoted 9 lines
Quoted 5 lines
};
typedef int (perf_evlist__thread_cb_t)(perf_evlist, union
perf_event*event,....)How do we use this callback? We need a way to specify which events to poll (mmap,
bpf_event, ksymbol, etc). How do we do that with the callback function?you provide your own callback
I guess I get your point now. I can try that.
Thanks,
Song
Quoted 1 line
jirka
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
Quoted 51 lines · Song Liu
Quoted 51 lines · Jiri Olsa
Quoted 46 lines · Song Liu
Quoted 20 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 12 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h> Quoted 12 lines
tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 7 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:I picked global
sb_evlistandpoll_threadbecause there should be only onesb_evlistand one thread polling it. There might be multiple evsel on thesb_evlist.I am not sure I understand your suggestion..
Quoted 6 lines
struct perf_evlist { ... struct { pthread_t th; int state; } thread;
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
This will not be used by the main
perf_evlist, right?no, just by the thread interface
What is "state" here?
it's replacement for the 'done' pointer u had,
which I did not like.. leting each thread having
its own state is better IMO
jirka
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
Quoted 60 lines · Jiri Olsa
Quoted 55 lines · Song Liu
Quoted 54 lines · Jiri Olsa
Quoted 39 lines · Song Liu
Quoted 20 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 12 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h> Quoted 12 lines
tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 7 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:I picked global
sb_evlistandpoll_threadbecause there should be only onesb_evlistand one thread polling it. There might be multiple evsel on thesb_evlist.I am not sure I understand your suggestion..
Quoted 8 lines
Quoted 6 lines
struct perf_evlist { ... struct { pthread_t th; int state; } thread;This will not be used by the main
perf_evlist, right?no, just by the thread interface
Quoted 7 lines
Quoted 1 line
What is "state" here?
it's replacement for the 'done' pointer u had,
which I did not like.. leting each thread having
its own state is better IMOjirka
I see. Let me try that.
Song
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
In reply to Jiri OlsaQuoted 41 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 13 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h> tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 6 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:struct perf_evlist { ... struct { pthread_t th; int state; } thread; };
Quoted 7 lines
typedef int (perf_evlist__thread_cb_t)(perf_evlist, union
perf_event*event,....)
perf_evlist__start_thread(perf_evlist, perf_evlist__thread_cb_t cb);perf_evlist__stop_thread(perf_evlist);jirka
More questions on this proposal:
IIUC, this approach creates one perf_evlist and one thread for each side band event (only bpf for now, more afterwards). Each of these perf_evlists will create its own ring buffer.
On the other hand, current patch allows different events to share the thread, the perf_evlist, and the ring buffer.
If my understanding is correct, current patch would be more efficient down the road? Did I miss some downsides of current patch?
Thanks,
Song
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
Quoted 49 lines · Song Liu
Quoted 41 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 13 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h> tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 6 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:struct perf_evlist { ... struct { pthread_t th; int state; } thread; };Quoted 7 lines
typedef int (perf_evlist__thread_cb_t)(perf_evlist, union
perf_event*event,....)
perf_evlist__start_thread(perf_evlist, perf_evlist__thread_cb_t cb);perf_evlist__stop_thread(perf_evlist);jirka
Quoted 8 lines
More questions on this proposal:
IIUC, this approach creates one
perf_evlistand one thread for each side band event (only bpf for now, more afterwards). Each of theseperf_evlistswill create its own ring buffer.On the other hand, current patch allows different events to share the thread, the
perf_evlist, and the ring buffer.
you can have those events in single evlist no?
Quoted 3 lines
If my understanding is correct, current patch would be more efficient down the road? Did I miss some downsides of current patch?
I'd just like something configurable and with single handle not scattered around the code, so it's easy to add new callback
jirka
Re: [PATCH v4 perf,bpf 14/15] perf: introduce side band thread
Quoted 66 lines · Jiri Olsa
Quoted 49 lines · Song Liu
Quoted 41 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:18PM -0800, Song Liu wrote:
SNIP
Quoted 13 lines
tools/perf/util/evlist.c +1
-0@@ -19,6 +19,7 @@#include "debug.h" #include "units.h" #include "asm/bug.h" +#include "bpf-event.h" #include <signal.h> #include <unistd.h> tools/perf/util/evlist.c struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, · line 1847
Quoted 6 lines
tools/perf/util/evlist.c +3
-0@@ -1841,3 +1842,102 @@ struct perf_evsel *perf_evlist__reset_weak_group(struct perf_evlist *evsel_list, }return leader; } + +static struct perf_evlist *sb_evlist; +pthread_t poll_thread;so some of the things are static and some like
poll_argsyou alloced on the stack.. I dont like this interface, could we come up with something generic? perhaps encapsulated inperf_evlist, like:struct perf_evlist { ... struct { pthread_t th; int state; } thread; };Quoted 7 lines
typedef int (perf_evlist__thread_cb_t)(perf_evlist, union
perf_event*event,....)
perf_evlist__start_thread(perf_evlist, perf_evlist__thread_cb_t cb);perf_evlist__stop_thread(perf_evlist);jirka
Quoted 8 lines
More questions on this proposal:
IIUC, this approach creates one
perf_evlistand one thread for each side band event (only bpf for now, more afterwards). Each of theseperf_evlistswill create its own ring buffer.On the other hand, current patch allows different events to share the thread, the
perf_evlist, and the ring buffer.you can have those events in single evlist no?
Quoted 1 line
Quoted 7 lines
Quoted 2 lines
If my understanding is correct, current patch would be more efficient down the road? Did I miss some downsides of current patch?
I'd just like something configurable and with single handle not scattered around the code, so it's easy to add new callback
jirka
To make adding callbacks easy, we need to register callback per perf_evsel, so multiple side band events could share the perf_evlist. It will be something like:
typedef int (perf_evsel__sb_cb_t)(union perf_event *event, void *data);
struct perf_evsel {
...
struct {
perf_evsel__sb_cb_t *cb;
void *data;
} side_band;
};perf_evlist__add_sb_event(struct perf_evlist *evlist,
struct perf_event_attr *attr, perf_evsel__sb_cb_t cb, void *data);
perf_evlist__start_sb_evlist(struct perf_evlist *evlist); perf_evlist__stop_sb_evlist(struct perf_evlist *evlist);
Does this look like a good approach?
Thanks,
Song
PATCH v4 15/15 perf, bpf: save information about short living bpf programs
In reply to Song LiuThis patch adds and side band event to capture bpf_prog_info and btf of short living bpf programs.
--- tools/perf/builtin-record.c | 3 ++ tools/perf/builtin-top.c | 3 ++ tools/perf/util/bpf-event.c | 66 +++++++++++++++++++++++++++++++++++++ tools/perf/util/bpf-event.h | 18 ++++++++++ tools/perf/util/evlist.c | 5 +++ 5 files changed, 95 insertions(+)
tools/perf/builtin-record.c +3 -0
@@ -1207,6 +1207,9 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) goto out_child; } +if (opts->bpf_event) +bpf_event__add_polling_event (); + poll_args.env = &session->header.env; poll_args.done = &done;perf_evlist__start_polling_thread (&rec->opts.target, &poll_args);
tools/perf/builtin-top.c +3 -0
@@ -1655,6 +1655,9 @@ int cmd_top(int argc, const char **argv) top.record_opts.bpf_event = !top.no_bpf_event; +if (top.record_opts.bpf_event) +bpf_event__add_polling_event (); + poll_args.env = &perf_env; poll_args.done = &done;perf_evlist__start_polling_thread (target, &poll_args);
tools/perf/util/bpf-event.c +66 -0
75 lines not on this page · raw message
tools/perf/util/bpf-event.h +18 -0
@@ -4,12 +4,17 @@#include <linux/compiler.h> #include <linux/rbtree.h> +#include <pthread.h> +#include <api/fd/array.h> #include "event.h" struct machine ;union perf_event ; +struct perf_env ;struct perf_sample ;struct record_opts ; +struct evlist ; +struct target ;struct bpf_prog_info_node {struct bpf_prog_info_linear *info_linear;
@@ -31,6 +36,9 @@ int perf_event__synthesize_bpf_events(struct perf_session *session,perf_event__handler_t process, struct machine *machine, struct record_opts *opts); +int bpf_event__add_polling_event (void ); +void perf_env__add_bpf_info (struct perf_env *env,u32 id); +#else static inline int machine__process_bpf_event(struct machine *machine __maybe_unused, union perf_event *event __maybe_unused,
@@ -46,5 +54,15 @@ static inline int perf_event__synthesize_bpf_events(struct perf_session *session {return 0 ; } + +static inline int bpf_event__add_polling_event (void ) +{ +return 0 ; +} + +void perf_env__add_bpf_info (struct perf_env *env__maybe_unused , +u32 id__maybe_unused ) +{ +}#endif // HAVE_LIBBPF_SUPPORT #endif
tools/perf/util/evlist.c +5 -0
@@ -1886,6 +1886,11 @@ static void *perf_evlist__poll_thread(void *arg)pr_debug ("processing vip event of type %d\n" , event->header.type);switch (event->header.type) { +case PERF_RECORD_BPF_EVENT : +if (event->bpf_event.type !=PERF_BPF_EVENT_PROG_LOAD ) +break ; +perf_env__add_bpf_info (args->env, event->bpf_event.id); +break ;default :break ; }
Signature · 1 line
2.17.1
Re: [PATCH v4 perf,bpf 15/15] perf, bpf: save information about short living bpf programs
On Mon, Feb 25, 2019 at 04:20:19PM -0800, Song Liu wrote:
SNIP
Quoted 8 lines
tools/perf/util/bpf-event.c +8
-0+ btf_id = info_linear->info.btf_id; + + info_node =malloc (sizeof (struct bpf_prog_info_node )); +if (info_node) { + info_node->info_linear = info_linear; +perf_env__insert_bpf_prog_info (env, info_node); + }else +free (info_linear);
tools/perf/util/bpf-event.c int perf_event__synthesize_bpf_events(struct perf_session *session, · line 381
Quoted 10 lines
tools/perf/util/bpf-event.c +10
-0+ +if (btf_id ==0 ) + goto out; + +if (btf__get_from_id (btf_id, &btf)) { +pr_debug ("%s: failed to get BTF of id %u, aborting\n" , + __func__, btf_id); + goto out; + } +perf_env__fetch_btf (env, btf_id, btf);
so is this the main reason we are doing this? getting the btf data for bpf prog ids and store them?
please describe the whole bpf events/features data flow in changelog as I asked in previous email
thanks,
jirka
Re: [PATCH v4 perf,bpf 15/15] perf, bpf: save information about short living bpf programs
Quoted 14 lines · Jiri Olsa
On Mon, Feb 25, 2019 at 04:20:19PM -0800, Song Liu wrote:
SNIP
tools/perf/util/bpf-event.c int perf_event__synthesize_bpf_events(struct perf_session *session, · line 369
Quoted 6 lines
tools/perf/util/bpf-event.c +6
-0+ btf_id = info_linear->info.btf_id; + + info_node =malloc (sizeof (struct bpf_prog_info_node )); +if (info_node) { + info_node->info_linear = info_linear; +perf_env__insert_bpf_prog_info (env, info_node);
Getting bpf_prog_info here.
Quoted 7 lines
Quoted 7 lines
tools/perf/util/bpf-event.c +7
-0+ }else +free (info_linear); + +if (btf_id ==0 ) + goto out; + +if (btf__get_from_id (btf_id, &btf)) {
Quoted 8 lines
tools/perf/util/bpf-event.c int perf_event__synthesize_bpf_events(struct perf_session *session, · line 381
Quoted 5 lines
tools/perf/util/bpf-event.c +5
-0+pr_debug ("%s: failed to get BTF of id %u, aborting\n" , + __func__, btf_id); + goto out; + } +perf_env__fetch_btf (env, btf_id, btf);so is this the main reason we are doing this? getting the btf data for bpf prog ids and store them?
We are getting both bpf_prog_info (see above) and btf.
Quoted 3 lines
please describe the whole bpf events/features data flow in changelog as I asked in previous email
I will add more details to the change log.
Thanks,
Song
Quoted 3 lines
thanks,
jirka