Skip to contentSkip to conversation

usb: ehci: Cleanup itd/sidt_complete()

DISCUSSION Suwan Kim 1 participant 1 message Feb 26, 2019 USB

lore
Share & tools
lore

Suwan Kim

author
#0 lore raw
Quoted 6 lines · Greg KH
Quoted 2 lines · Suwan Kim

This patch makes itd/sitd_complete() use *bus instead of referening ehci_to_hcd(ehci)->self. And remove unnecessary "urb = NULL" lines.

That is two different things to do in the same patch, please break this up into different patches.

Sorry. I will break it up and send separate patches.

Quoted 7 lines

And when you do, say _why_ you are making these changes, not just a description of the change itself. We can read the patch to see what it does, but we do not know why you want to do this.

thanks,

greg k-h

Ok, you are right. My description is very short. I will rewrite the description including why i do this and resend v2.

Regards

Suwan Kim