Skip to contentSkip to conversation

staging: wilc1000: fix incorrect type in initializer

PATCH Superseded Bo YU 2 participants 2 messages Feb 26, 2019 1 message not in the archive Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bo YU

author
#0 lore raw

PATCH 1/1 staging: wilc1000: fix incorrect type in initializer

Fix sparse warning following:

drivers/staging/wilc1000/host_interface.c:444:49: warning: incorrect type in initializer (different address spaces)
drivers/staging/wilc1000/host_interface.c:444:49: expected struct cfg80211_bss_ies const *ies
drivers/staging/wilc1000/host_interface.c:444:49: got struct cfg80211_bss_ies const [noderef] <asn:4> *ies

---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/host_interface.c +1 -1
index cdcb52aec779..89ae22d40f71 100644
@@ -441,7 +441,7 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
 	const u8 *tim_elm, *ssid_elm, *rates_ie, *supp_rates_ie;
 	const u8 *ht_ie, *wpa_ie, *wmm_ie, *rsn_ie;
 	int ret;
-	const struct cfg80211_bss_ies *ies = bss->ies;
+	const struct cfg80211_bss_ies *ies = rcu_dereference(bss->ies);
 
 	param = kzalloc(sizeof(*param), GFP_KERNEL);
 	if (!param)
Signature · 1 line
2.11.0

A message that is not in the archive (sent off-list or not yet received): CAKq8=3L5tQNuB1EBjp4osZk83XBX48aWtPN7YiB0sbCg+j6q9g@mail.gmail.com

maintainer
#2 lore raw
Quoted 29 lines · Bo YU
Quoted 27 lines · Bo YU

Fix sparse warning following:

drivers/staging/wilc1000/host_interface.c:444:49: warning: incorrect type in initializer (different address spaces)
drivers/staging/wilc1000/host_interface.c:444:49: expected struct
cfg80211_bss_ies const *ies
drivers/staging/wilc1000/host_interface.c:444:49: got struct
cfg80211_bss_ies const [noderef] <asn:4> *ies

---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/host_interface.c +1 -1
index cdcb52aec779..89ae22d40f71 100644
@@ -441,7 +441,7 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss
 *bss,
        const u8 *tim_elm, *ssid_elm, *rates_ie, *supp_rates_ie;
        const u8 *ht_ie, *wpa_ie, *wmm_ie, *rsn_ie;
        int ret;
-       const struct cfg80211_bss_ies *ies = bss->ies;
+       const struct cfg80211_bss_ies *ies = rcu_dereference(bss->ies);
 
Quoted 7 lines
Quoted 6 lines
drivers/staging/wilc1000/host_interface.c +0 -0
        param = kzalloc(sizeof(*param), GFP_KERNEL);
        if (!param)

--
2.11.0

Hi,

I do not Ccing wireless-list, Does it matter?

It would be nice to do that in the future.