Skip to contentSkip to conversation

dt-bindings: Add vendor prefix for oceanic

PATCH In review Jagan Teki 3 participants 12 messages Feb 26, 2019 – Mar 6, 2019

Subsystems (2)
lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/2 dt-bindings: Add vendor prefix for oceanic

Add oceanic vendor prefix.

Oceanic Systems (UK) Ltd design and manufacture world-class marine systems for control and monitoring vessels.

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index f42e12eb9d64..5b551407f487 100644
@@ -285,6 +285,7 @@ nuvoton	Nuvoton Technology Corporation
 nvd	New Vision Display
 nvidia	NVIDIA
 nxp	NXP Semiconductors
+oceanic	Oceanic Systems (UK) Ltd.
 okaya	Okaya Electric America, Inc.
 oki	Oki Electric Industry Co., Ltd.
 olimex	OLIMEX Ltd.
Signature · 1 line
2.18.0.321.gffc6fa0e3
author
#1 lore raw

PATCH 2/2 arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +46 -0

46 lines not on this page · raw message

Signature · 1 line
2.18.0.321.gffc6fa0e3
#2 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Hi,

Quoted 46 lines · Jagan Teki

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +4 -0
new file mode 100644
index 000000000000..d73d1f55acb9
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 14

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +10 -0
+ * Author: Jagan Teki <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine.dtsi"
+
+/ {
+	model = "Oceanic A64-5inMFD";
+	compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

The name of the DT is Oceanic 5inMFD, while you call the board A64-5inMFD here, which name is the actual name?

Quoted 22 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +22 -0
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_pb_pins>;
+	status = "okay";

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 46

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +10 -0
+};
+
+&usb_otg {
+	dr_mode = "host";
+	status = "okay";
+};
+
+&usbphy {
+	status = "okay";
+};

Is the OTG controller really is only capable of running in host mode?

Maxime

Signature · 3 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#3 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 55 lines · Maxime Ripard

Hi,

Quoted 51 lines · Jagan Teki

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +9 -0
new file mode 100644
index 000000000000..d73d1f55acb9
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.
+ * Author: Jagan Teki <[email protected]>
+ */
+
+/dts-v1/;
+
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 14

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +5 -0
+#include "sun50i-a64-sopine.dtsi"
+
+/ {
+     model = "Oceanic A64-5inMFD";
+     compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

The name of the DT is Oceanic 5inMFD, while you call the board A64-5inMFD here, which name is the actual name?

Yes, this is something that we discussed during "Amarula A64-Relic" naming convention.

Since these boards are not famous like teres-i we agreed to add vendor name after sun50i-a64- followed by real board name.

Here A64 already covered during sun50i-a64- so the dts name simply the <vendor_name>-<real_board_name>

Quoted 27 lines
Quoted 27 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +26 -0
+
+     aliases {
+             serial0 = &uart0;
+     };
+
+     chosen {
+             stdout-path = "serial0:115200n8";
+     };
+};
+
+&ehci0 {
+     status = "okay";
+};
+
+&ohci0 {
+     status = "okay";
+};
+
+&uart0 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart0_pb_pins>;
+     status = "okay";
+};
+
+&usb_otg {
+     dr_mode = "host";
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 46

Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +6 -0
+     status = "okay";
+};
+
+&usbphy {
+     status = "okay";
+};

Is the OTG controller really is only capable of running in host mode?

Yes, USB on baseboard is similar like sopine-baseboard

#4 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 65 lines · Jagan Teki
Quoted 55 lines · Maxime Ripard

Hi,

Quoted 51 lines · Jagan Teki

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +9 -0
new file mode 100644
index 000000000000..d73d1f55acb9
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.
+ * Author: Jagan Teki <[email protected]>
+ */
+
+/dts-v1/;
+
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 14

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +5 -0
+#include "sun50i-a64-sopine.dtsi"
+
+/ {
+     model = "Oceanic A64-5inMFD";
+     compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

The name of the DT is Oceanic 5inMFD, while you call the board A64-5inMFD here, which name is the actual name?

Quoted 8 lines

Yes, this is something that we discussed during "Amarula A64-Relic" naming convention.

Since these boards are not famous like teres-i we agreed to add vendor name after sun50i-a64- followed by real board name.

Here A64 already covered during sun50i-a64- so the dts name simply the <vendor_name>-<real_board_name>

For the DT name, yeah, we want that pattern.

For the compatible and model, we want to use the model name.

Quoted 36 lines
Quoted 27 lines
Quoted 27 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +26 -0
+
+     aliases {
+             serial0 = &uart0;
+     };
+
+     chosen {
+             stdout-path = "serial0:115200n8";
+     };
+};
+
+&ehci0 {
+     status = "okay";
+};
+
+&ohci0 {
+     status = "okay";
+};
+
+&uart0 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart0_pb_pins>;
+     status = "okay";
+};
+
+&usb_otg {
+     dr_mode = "host";
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 46

Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +6 -0
+     status = "okay";
+};
+
+&usbphy {
+     status = "okay";
+};

Is the OTG controller really is only capable of running in host mode?

Quoted 1 line

Yes, USB on baseboard is similar like sopine-baseboard

Ok

Maxime

Signature · 3 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#5 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 73 lines · Maxime Ripard
Quoted 71 lines · Jagan Teki
Quoted 55 lines · Maxime Ripard

Hi,

Quoted 51 lines · Jagan Teki

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +9 -0
new file mode 100644
index 000000000000..d73d1f55acb9
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.
+ * Author: Jagan Teki <[email protected]>
+ */
+
+/dts-v1/;
+
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 14

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +5 -0
+#include "sun50i-a64-sopine.dtsi"
+
+/ {
+     model = "Oceanic A64-5inMFD";
+     compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

The name of the DT is Oceanic 5inMFD, while you call the board A64-5inMFD here, which name is the actual name?

Yes, this is something that we discussed during "Amarula A64-Relic" naming convention.

Since these boards are not famous like teres-i we agreed to add vendor name after sun50i-a64- followed by real board name.

Quoted 6 lines
Quoted 2 lines

Here A64 already covered during sun50i-a64- so the dts name simply the <vendor_name>-<real_board_name>

For the DT name, yeah, we want that pattern.

For the compatible and model, we want to use the model name.

Entire model name after <vendor_name>, ?

model = "Oceanic A64-5inMFD";
compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

is this not sufficient?

Let me understand with respective few existing stuff.

model = "Amarula A64-Relic";
compatible = "amarula,a64-relic", "allwinner,sun50i-a64";

model = "Olimex A64 Teres-I"
compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";

model = "FriendlyARM NanoPi A64";
compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";

model = "Olimex A64-Olinuxino";
compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"

Would you comment, what is the different with respect to my change?

#6 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 88 lines · Jagan Teki
Quoted 73 lines · Maxime Ripard
Quoted 71 lines · Jagan Teki
Quoted 55 lines · Maxime Ripard

Hi,

Quoted 51 lines · Jagan Teki

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +9 -0
new file mode 100644
index 000000000000..d73d1f55acb9
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.
+ * Author: Jagan Teki <[email protected]>
+ */
+
+/dts-v1/;
+
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 14

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +5 -0
+#include "sun50i-a64-sopine.dtsi"
+
+/ {
+     model = "Oceanic A64-5inMFD";
+     compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

The name of the DT is Oceanic 5inMFD, while you call the board A64-5inMFD here, which name is the actual name?

Yes, this is something that we discussed during "Amarula A64-Relic" naming convention.

Since these boards are not famous like teres-i we agreed to add vendor name after sun50i-a64- followed by real board name.

Quoted 6 lines
Quoted 2 lines

Here A64 already covered during sun50i-a64- so the dts name simply the <vendor_name>-<real_board_name>

For the DT name, yeah, we want that pattern.

For the compatible and model, we want to use the model name.

Entire model name after <vendor_name>, ?

model = "Oceanic A64-5inMFD";
compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

is this not sufficient?

Quoted 7 lines

Let me understand with respective few existing stuff.

model = "Amarula A64-Relic";
compatible = "amarula,a64-relic", "allwinner,sun50i-a64";

model = "Olimex A64 Teres-I"
compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";

This one is called the TERES-A64:
https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-source-hardware

The laptop is the Teres-I, it can have an A64

Quoted 2 lines

model = "FriendlyARM NanoPi A64";
compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";

NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html

Quoted 2 lines

model = "Olimex A64-Olinuxino";
compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"

A64-Olinuxino is the name of the board too:
https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-source-hardware

Quoted 1 line

Would you comment, what is the different with respect to my change?

If the name of the product is 5inMFD, then the model should be Oceanic 5inMFD, and its compatible oceanic,5inmfd

Maxime

Signature · 3 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#7 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 111 lines · Maxime Ripard
Quoted 88 lines · Jagan Teki
Quoted 73 lines · Maxime Ripard
Quoted 71 lines · Jagan Teki
Quoted 55 lines · Maxime Ripard

Hi,

Quoted 51 lines · Jagan Teki

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb sun50i-a64-bananapi-m64-icn6211.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +9 -0
new file mode 100644
index 000000000000..d73d1f55acb9
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.
+ * Author: Jagan Teki <[email protected]>
+ */
+
+/dts-v1/;
+
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts line 14

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts new file +5 -0
+#include "sun50i-a64-sopine.dtsi"
+
+/ {
+     model = "Oceanic A64-5inMFD";
+     compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

The name of the DT is Oceanic 5inMFD, while you call the board A64-5inMFD here, which name is the actual name?

Yes, this is something that we discussed during "Amarula A64-Relic" naming convention.

Since these boards are not famous like teres-i we agreed to add vendor name after sun50i-a64- followed by real board name.

Quoted 6 lines
Quoted 2 lines

Here A64 already covered during sun50i-a64- so the dts name simply the <vendor_name>-<real_board_name>

For the DT name, yeah, we want that pattern.

For the compatible and model, we want to use the model name.

Entire model name after <vendor_name>, ?

model = "Oceanic A64-5inMFD";
compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

is this not sufficient?

Quoted 7 lines

Let me understand with respective few existing stuff.

model = "Amarula A64-Relic";
compatible = "amarula,a64-relic", "allwinner,sun50i-a64";

model = "Olimex A64 Teres-I"
compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";

This one is called the TERES-A64:
https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-source-hardware

The laptop is the Teres-I, it can have an A64

Quoted 2 lines

model = "FriendlyARM NanoPi A64";
compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";

NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html

Quoted 2 lines

model = "Olimex A64-Olinuxino";
compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"

Quoted 7 lines

A64-Olinuxino is the name of the board too:
https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-source-hardware

Quoted 1 line

Would you comment, what is the different with respect to my change?

If the name of the product is 5inMFD, then the model should be Oceanic 5inMFD, and its compatible oceanic,5inmfd

Oceanic seems to have some multiple Multi Function Devices, ie reason we prefer the product as 'A64-5inMFD' since it is A64 based. In this case the model and compatible should be fine I think?

#8 lore raw

RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

We don't mind if it has to be:
compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";

However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";

Perhaps this solves the issue. Please let me know thoughts.

Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 05 March 2019 16:08
To: Maxime Ripard <[email protected]>
Cc: Chen-Yu Tsai <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Ryan Pannell <[email protected]>; Michael Trimarchi <[email protected]>; linux-arm-kernel <[email protected]>; devicetree <[email protected]>; linux-kernel <[email protected]>; [email protected]
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 119 lines · Maxime Ripard
Quoted 95 lines · Jagan Teki
Quoted 80 lines · Maxime Ripard
Quoted 78 lines · Jagan Teki
Quoted 62 lines · Maxime Ripard

Hi,

Quoted 58 lines · Jagan Teki

Oceanic A64-5inMFD is a 5 inch Multi function display baseboard designed to mount SoPine SOM.

Key features:
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 2GB DDR3 RAM
- SD Slot
- SPI-NOR flash
- EMAC, RTL8211E
- MCP2515 CAN
- MIPI-DSI
- Goodix 911 CTP
- USB Host
- 12V DC power supply

---
 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
 2 files changed, 47 insertions(+)  create mode 100644 

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index a5fb1eaa8acf..ec39fe856117 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb 

sun50i-a64-bananapi-m64-icn6211.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb diff
--git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt s b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt s
new file mode 100644
index 000000000000..d73d1f55acb9

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmf new file +10 -0
+++ d.dts
@@ -0,0 +1,46 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
+ * Copyright (C) 2019 Amarula Solutions B.V.
+ * Author: Jagan Teki <[email protected]>  */
+
+/dts-v1/;
+
+#include "sun50i-a64-sopine.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmf line 14

Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmf new file +5 -0
+
+/ {
+     model = "Oceanic A64-5inMFD";
+     compatible = "oceanic,a64-5inmfd", 
+"allwinner,sun50i-a64";

The name of the DT is Oceanic 5inMFD, while you call the board A64-5inMFD here, which name is the actual name?

Yes, this is something that we discussed during "Amarula A64-Relic" naming convention.

Since these boards are not famous like teres-i we agreed to add vendor name after sun50i-a64- followed by real board name.

Quoted 6 lines
Quoted 2 lines

Here A64 already covered during sun50i-a64- so the dts name simply the <vendor_name>-<real_board_name>

For the DT name, yeah, we want that pattern.

For the compatible and model, we want to use the model name.

Entire model name after <vendor_name>, ?

model = "Oceanic A64-5inMFD";
compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";

is this not sufficient?

Quoted 7 lines

Let me understand with respective few existing stuff.

model = "Amarula A64-Relic";
compatible = "amarula,a64-relic", "allwinner,sun50i-a64";

model = "Olimex A64 Teres-I"
compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";

This one is called the TERES-A64:
https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-s
ource-hardware

The laptop is the Teres-I, it can have an A64

Quoted 2 lines

model = "FriendlyARM NanoPi A64";
compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";

NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html

Quoted 2 lines

model = "Olimex A64-Olinuxino";
compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"

Quoted 8 lines

A64-Olinuxino is the name of the board too:
https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-sourc
e-hardware

Quoted 1 line

Would you comment, what is the different with respect to my change?

If the name of the product is 5inMFD, then the model should be Oceanic 5inMFD, and its compatible oceanic,5inmfd

Oceanic seems to have some multiple Multi Function Devices, ie reason we prefer the product as 'A64-5inMFD' since it is A64 based. In this case the model and compatible should be fine I think?

#9 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 7 lines · Ryan Pannell

We don't mind if it has to be:
compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";

However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";

Perhaps this solves the issue. Please let me know thoughts.

Yep, that works for me

Maxime

Signature · 3 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#10 lore raw

Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 11 lines · Maxime Ripard
Quoted 7 lines · Ryan Pannell

We don't mind if it has to be:
compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";

However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";

Perhaps this solves the issue. Please let me know thoughts.

Yep, that works for me

A64 instead of part-number 5205 seems less confused isn't it? or we need to give more priority with real hardware definition?

#11 lore raw

RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Jagan,

The compatible is for the real hardware name as Maxime previously explained. The platform is described in the latter part. Please use:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";

Thanks,
Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 06 March 2019 09:36
To: Maxime Ripard <[email protected]>
Cc: Ryan Pannell <[email protected]>; Chen-Yu Tsai <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Michael Trimarchi <[email protected]>; linux-arm-kernel <[email protected]>; devicetree <[email protected]>; linux-kernel <[email protected]>; [email protected]
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

Quoted 11 lines · Maxime Ripard
Quoted 7 lines · Ryan Pannell

We don't mind if it has to be:
compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";

However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";

Perhaps this solves the issue. Please let me know thoughts.

Yep, that works for me

A64 instead of part-number 5205 seems less confused isn't it? or we need to give more priority with real hardware definition?