Skip to contentSkip to conversation

autotools: Always build VC4 helpers with the library

PATCH In review Paul Kocialkowski 3 participants 3 messages Feb 26, 2019 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 autotools: Always build VC4 helpers with the library

With recent changes to the igt_fb code, VC4 support is now integrated in common helpers. As a result, VC4 helpers have to be built as part of the library.

This is already the case with meson, but VC4 support was removed from autotools. Bring it back unconditionally to match meson behaviour.

This fixes a build error with autotools.

---
 lib/Makefile.sources | 2 ++
 1 file changed, 2 insertions(+)
lib/Makefile.sources +2 -0
index 808b9617eca2..9711fef34469 100644
@@ -109,6 +109,8 @@ lib_source_list =	 	\
 	igt_psr.h		\
 	igt_v3d.c		\
 	igt_v3d.h		\
+	igt_vc4.c		\
+	igt_vc4.h		\
 	$(NULL)
 
 .PHONY: version.h.tmp
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Paul Kocialkowski

With recent changes to the igt_fb code, VC4 support is now integrated in common helpers. As a result, VC4 helpers have to be built as part of the library.

This is already the case with meson, but VC4 support was removed from autotools. Bring it back unconditionally to match meson behaviour.

This fixes a build error with autotools.

Maxime

Signature · 3 lines
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for autotools: Always build VC4 helpers with the library

In reply to Paul Kocialkowski
== Series Details ==

== Series Details ==

Series: autotools: Always build VC4 helpers with the library
URL : https://patchwork.freedesktop.org/series/57243/
State : failure

== Summary ==

Series 57243 revision 1 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev