Skip to contentSkip to conversation

staging: mt7621-eth: add SPDX GPL-2.0 license identifier ---added punctuation to v1 changelog text

PATCH Superseded Jules Irenge 3 participants 3 messages Feb 25, 2019 – Feb 26, 2019

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: mt7621-eth: add SPDX GPL-2.0 license identifier ---added punctuation to v1 changelog text

Add SPDX GPL-2.0 license to fix missing SPDX warning
reported by checkpatch.pl.

---
 drivers/staging/mt7621-eth/ethtool.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-eth/ethtool.h +1 -0
index 40b4cf011660..d0e97ae0d82e 100644
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*   This program is free software; you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
  *   the Free Software Foundation; version 2 of the License
Signature · 1 line
2.20.1
#1 lore raw

The subject line is still not correct. You can't describe your changes since the previous patch in the subject line. That goes under the ---

v2: added punctuation to v1 changelog text

Please go back and read the outreachy tutorial again thoroughly. That contains all of the information you need to know to send patches in the right way. You shouldn't need to make things up yourself.

julia

Quoted 27 lines · Jules Irenge

Add SPDX GPL-2.0 license to fix missing SPDX warning
reported by checkpatch.pl.

---
 drivers/staging/mt7621-eth/ethtool.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-eth/ethtool.h +1 -1
index 40b4cf011660..d0e97ae0d82e 100644
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*   This program is free software; you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
  *   the Free Software Foundation; version 2 of the License
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190225230929.3861-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

maintainer
#2 lore raw
In reply to Jules Irenge
Quoted 13 lines · Jules Irenge

Add SPDX GPL-2.0 license to fix missing SPDX warning
reported by checkpatch.pl.

---
 drivers/staging/mt7621-eth/ethtool.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-eth/ethtool.h +0 -0
index 40b4cf011660..d0e97ae0d82e 100644

drivers/staging/mt7621-eth/ethtool.h line 4

Quoted 4 lines
drivers/staging/mt7621-eth/ethtool.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*   This program is free software; you can redistribute it and/or modify
  *   it under the terms of the GNU General Public License as published by
  *   the Free Software Foundation; version 2 of the License

When you do this, the follow-on patch afterward should remove the two paragraphs of the license "boiler plate" text.

thanks,

greg k-h