Skip to contentSkip to conversation

Staging: vt6655: Fix check - Lines should not end with a '('

PATCH In review Madhumitha Prabakaran 2 participants 3 messages Feb 25, 2019 – Feb 26, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: vt6655: Fix check - Lines should not end with a '('

Improve readibility

---
Changes in v2
-Make a commit message imperative.
-Use multiple lines to improve readibility

 drivers/staging/vt6655/baseband.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/vt6655/baseband.c +4 -2
index d8321e7fd68b..35bbff807df9 100644
@@ -1704,8 +1704,10 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  * Return Value: FrameTime
  *
  */
-unsigned int BBuGetFrameTime(unsigned char byPreambleType,				unsigned char byPktType,
-	unsigned int cbFrameLength,							unsigned short wRate)
+unsigned int BBuGetFrameTime(unsigned char byPreambleType,
+	unsigned char byPktType,
+	unsigned int cbFrameLength,
+	unsigned short wRate)
 {
 	unsigned int uFrameTime;
 	unsigned int uPreamble;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 16 lines · Madhumitha Prabakaran

Improve readibility

---
Changes in v2
-Make a commit message imperative.
-Use multiple lines to improve readibility

 drivers/staging/vt6655/baseband.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/vt6655/baseband.c +0 -0
index d8321e7fd68b..35bbff807df9 100644

drivers/staging/vt6655/baseband.c static const unsigned short awcFrameTime[MAX_RATE] = { · line 1710

Quoted 9 lines
drivers/staging/vt6655/baseband.c +4 -2
@@ -1704,8 +1704,10 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  * Return Value: FrameTime
  *
  */
-unsigned int BBuGetFrameTime(unsigned char byPreambleType,				unsigned char byPktType,
-	unsigned int cbFrameLength,							unsigned short wRate)
+unsigned int BBuGetFrameTime(unsigned char byPreambleType,
+	unsigned char byPktType,
+	unsigned int cbFrameLength,
+	unsigned short wRate)

This is just inviting another patch to line up the parameters to the right of the (. I would have expected that checkpatch would have complained about this.

drivers/staging/vt6655/baseband.c static const unsigned short awcFrameTime[MAX_RATE] = { · line 1713

Quoted 3 lines
drivers/staging/vt6655/baseband.c +0 -0
 {
 	unsigned int uFrameTime;
 	unsigned int uPreamble;

This looks ripe for some other changes - not using camel case and not encoding types in variable names (the u).

julia

Quoted 10 lines

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190225171403.393-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 46 lines · Julia Lawall
Quoted 16 lines · Madhumitha Prabakaran

Improve readibility

---
Changes in v2
-Make a commit message imperative.
-Use multiple lines to improve readibility

 drivers/staging/vt6655/baseband.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/vt6655/baseband.c +0 -0
index d8321e7fd68b..35bbff807df9 100644

drivers/staging/vt6655/baseband.c static const unsigned short awcFrameTime[MAX_RATE] = { · line 1710

Quoted 9 lines
drivers/staging/vt6655/baseband.c +4 -2
@@ -1704,8 +1704,10 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  * Return Value: FrameTime
  *
  */
-unsigned int BBuGetFrameTime(unsigned char byPreambleType,				unsigned char byPktType,
-	unsigned int cbFrameLength,							unsigned short wRate)
+unsigned int BBuGetFrameTime(unsigned char byPreambleType,
+	unsigned char byPktType,
+	unsigned int cbFrameLength,
+	unsigned short wRate)

This is just inviting another patch to line up the parameters to the right of the (. I would have expected that checkpatch would have complained about this.

drivers/staging/vt6655/baseband.c static const unsigned short awcFrameTime[MAX_RATE] = { · line 1713

Quoted 3 lines
drivers/staging/vt6655/baseband.c +0 -0
 {
 	unsigned int uFrameTime;
 	unsigned int uPreamble;

This looks ripe for some other changes - not using camel case and not encoding types in variable names (the u).

julia

Quoted 3 lines

--
2.17.1

Quoted 14 lines
Quoted 7 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190225171403.393-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Signature · 5 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1902252154390.2481%40hadrien.
For more options, visit https://groups.google.com/d/optout.

I will fix it and change the commit message

Madhumitha