Skip to contentSkip to conversation

monitor: Fix LE Set Extended Advertising Parameters TX power decoding

PATCH Applied Szymon Janc 1 participant 2 messages Feb 26, 2019 – Mar 8, 2019 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 monitor: Fix LE Set Extended Advertising Parameters TX power decoding

TX power of 127 has special meaning for this command.

---
 monitor/packet.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
monitor/packet.c +5 -2
index 96cacddd5..7f4d6b1ea 100644
@@ -1115,7 +1115,7 @@ static void print_power_level(int8_t level, const char *type)
 {
 	print_field("TX power%s%s%s: %d dbm (0x%2.2x)",
 		type ? " (" : "", type ? type : "", type ? ")" : "",
-								level, level);
+							level, (uint8_t) level);
 }
 
 static void print_host_flow_control(uint8_t enable)
@@ -6944,7 +6944,10 @@ static void le_set_ext_adv_params_cmd(const void *data, uint8_t size)
 	print_peer_addr_type("Peer address type", cmd->peer_addr_type);
 	print_addr("Peer address", cmd->peer_addr, cmd->peer_addr_type);
 	print_adv_filter_policy("Filter policy", cmd->filter_policy);
-	print_power_level(cmd->tx_power, NULL);
+	if (cmd->tx_power == 0xff)
+		print_field("TX power: Host has no preference (0xff)");
+	else
+		print_power_level(cmd->tx_power, NULL);
 
 	switch (cmd->primary_phy) {
 	case 0x01:
Signature · 1 line
2.20.1
author Applied
#1 lore raw
Quoted 10 lines · On Tuesday, 26 February 2019 13:56:29 CET Szymon Janc wrote:

TX power of 127 has special meaning for this command.

---
 monitor/packet.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
monitor/packet.c +0 -0
index 96cacddd5..7f4d6b1ea 100644

monitor/packet.c static void print_power_level(int8_t level, const char · line 1118

Quoted 4 lines
monitor/packet.c +0 -1
@@ -1115,7 +1115,7 @@ static void print_power_level(int8_t level, const char
 *type) {
 	print_field("TX power%s%s%s: %d dbm (0x%2.2x)",
 		type ? " (" : "", type ? type : "", type ? ")" : "",
-								

level, level);

monitor/packet.c static void print_power_level(int8_t level, const char · line 1118

Quoted 1 line
monitor/packet.c +1 -0
+							level, 

(uint8_t) level);

Quoted 15 lines
monitor/packet.c +4 -1
 }
 
 static void print_host_flow_control(uint8_t enable)
@@ -6944,7 +6944,10 @@ static void le_set_ext_adv_params_cmd(const void
 *data, uint8_t size) print_peer_addr_type("Peer address type",
 cmd->peer_addr_type);
 	print_addr("Peer address", cmd->peer_addr, cmd->peer_addr_type);
 	print_adv_filter_policy("Filter policy", cmd->filter_policy);
-	print_power_level(cmd->tx_power, NULL);
+	if (cmd->tx_power == 0xff)
+		print_field("TX power: Host has no preference (0xff)");
+	else
+		print_power_level(cmd->tx_power, NULL);
 
 	switch (cmd->primary_phy) {
Quoted 1 line

case 0x01:

Applied.

Signature · 2 lines
pozdrawiam
Szymon Janc