ath10k: Fix length of wmi tlv command for protected mgmt frames
PATCH 1/1 ath10k: Fix length of wmi tlv command for protected mgmt frames
The length of wmi tlv command for management tx send is calculated incorrectly in case of protected management frames as there is addition of IEEE80211_CCMP_MIC_LEN twice. This leads to improper behaviour of firmware as the wmi tlv mgmt tx send command for protected mgmt frames is formed wrongly.
Fix the length calculation of wmi tlv command for mgmt tx send in case of protected management frames by adding the IEEE80211_CCMP_MIC_LEN only once.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/wireless/ath/ath10k/wmi-tlv.c +1 -3
@@ -2764,10 +2764,8 @@ static void *ath10k_wmi_tlv_put_wmm(void *ptr,if ((ieee80211_is_action (hdr->frame_control) ||ieee80211_is_deauth (hdr->frame_control) ||ieee80211_is_disassoc (hdr->frame_control)) && -ieee80211_has_protected (hdr->frame_control)) { - len +=IEEE80211_CCMP_MIC_LEN ; +ieee80211_has_protected (hdr->frame_control)) buf_len +=IEEE80211_CCMP_MIC_LEN ; - } buf_len =min_t (u32, buf_len,WMI_TLV_MGMT_TX_FRAME_MAX_LEN ); buf_len =round_up (buf_len,4 );
Signature · 1 line
1.9.1
Quoted 10 lines · Surabhi Vishnoi
The length of wmi tlv command for management tx send is calculated incorrectly in case of protected management frames as there is addition of
IEEE80211_CCMP_MIC_LENtwice. This leads to improper behaviour of firmware as the wmi tlv mgmt tx send command for protected mgmt frames is formed wrongly.Fix the length calculation of wmi tlv command for mgmt tx send in case of protected management frames by adding the
IEEE80211_CCMP_MIC_LENonly once.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes 1807da49733e "ath10k: wmi: add management tx by reference support over wmi"Signed-off-by Surabhi Vishnoi <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
761156ff573d ath10k: Fix length of wmi tlv command for protected mgmt frames
Signature · 9 lines
https://patchwork.kernel.org/patch/10815099/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 10 lines · Surabhi Vishnoi
The length of wmi tlv command for management tx send is calculated incorrectly in case of protected management frames as there is addition of
IEEE80211_CCMP_MIC_LENtwice. This leads to improper behaviour of firmware as the wmi tlv mgmt tx send command for protected mgmt frames is formed wrongly.Fix the length calculation of wmi tlv command for mgmt tx send in case of protected management frames by adding the
IEEE80211_CCMP_MIC_LENonly once.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes 1807da49733e "ath10k: wmi: add management tx by reference support over wmi"Signed-off-by Surabhi Vishnoi <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
761156ff573d ath10k: Fix length of wmi tlv command for protected mgmt frames
Signature · 3 lines
https://patchwork.kernel.org/patch/10815099/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches