Skip to contentSkip to conversation

USB: serial: option: set driver_info for SIM5218 and compatibles

PATCH In review Mans Rullgard 4 participants 17 messages Feb 26, 2019 – Mar 19, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: serial: option: set driver_info for SIM5218 and compatibles

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +2 -1
index fb544340888b..af4cbfecc3ff 100644
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),
maintainer
#1 lore raw
Quoted 15 lines · Mans Rullgard

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -0
index fb544340888b..af4cbfecc3ff 100644

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1073

Quoted 9 lines
drivers/usb/serial/option.c +2 -1
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Could you please provide the output of usb-devices (or lsusb -v) for this device?

Thanks,
Johan

#2 lore raw
Quoted 20 lines · Johan Hovold
Quoted 19 lines · Mans Rullgard

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -1
index fb544340888b..af4cbfecc3ff 100644
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
Quoted 8 lines

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1073

Quoted 5 lines
drivers/usb/serial/option.c +2 -0
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Could you please provide the output of usb-devices (or lsusb -v) for this device?

lsusb -v:
Bus 001 Device 003: ID 05c6:9000 Qualcomm, Inc. SIMCom SIM5218 modem Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00

  bDeviceClass            0 
  bDeviceSubClass         0 
  bDeviceProtocol         0 
  bMaxPacketSize0        64
  idVendor           0x05c6 Qualcomm, Inc.
  idProduct          0x9000 SIMCom SIM5218 modem
  bcdDevice            0.00
  iManufacturer           3 SimTech, Incorporated
  iProduct                2 SimTech SIM5360
  iSerial                 0 
  bNumConfigurations      1

Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 138
bNumInterfaces 5
bConfigurationValue 1
iConfiguration 1 SimTech Configuration
bmAttributes 0xe0
Self Powered
Remote Wakeup
MaxPower 500mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 1
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 2
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x03 EP 3 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 3
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84 EP 4 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85 EP 5 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x04 EP 4 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 4
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x86 EP 6 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x87 EP 7 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x05 EP 5 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00

  bDeviceClass            0 
  bDeviceSubClass         0 
  bDeviceProtocol         0 

bMaxPacketSize0 64
bNumConfigurations 1
can't get debug descriptor: Resource temporarily unavailable
Device Status: 0x0000
(Bus Powered)

maintainer
#3 lore raw

Adding Bjørn.

Quoted 233 lines · Måns Rullgård
Quoted 20 lines · Johan Hovold
Quoted 19 lines · Mans Rullgard

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -1
index fb544340888b..af4cbfecc3ff 100644
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
Quoted 8 lines

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1073

Quoted 5 lines
drivers/usb/serial/option.c +2 -0
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Could you please provide the output of usb-devices (or lsusb -v) for this device?

lsusb -v:
Bus 001 Device 003: ID 05c6:9000 Qualcomm, Inc. SIMCom SIM5218 modem Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00

  bDeviceClass            0 
  bDeviceSubClass         0 
  bDeviceProtocol         0 
  bMaxPacketSize0        64
  idVendor           0x05c6 Qualcomm, Inc.
  idProduct          0x9000 SIMCom SIM5218 modem
  bcdDevice            0.00
  iManufacturer           3 SimTech, Incorporated
  iProduct                2 SimTech SIM5360
  iSerial                 0 
  bNumConfigurations      1

Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 138
bNumInterfaces 5
bConfigurationValue 1
iConfiguration 1 SimTech Configuration
bmAttributes 0xe0
Self Powered
Remote Wakeup
MaxPower 500mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 1
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 2
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x03 EP 3 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 3
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84 EP 4 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85 EP 5 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x04 EP 4 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 4
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x86 EP 6 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x87 EP 7 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x05 EP 5 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00

Quoted 8 lines
  bDeviceClass            0 
  bDeviceSubClass         0 
  bDeviceProtocol         0 

bMaxPacketSize0 64
bNumConfigurations 1
can't get debug descriptor: Resource temporarily unavailable
Device Status: 0x0000
(Bus Powered)

So the patch looks fine to me. The fifth interface is QMI, but hasn't been available for use until now then, and this seems to have been the vendors idea from the start:

http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf

And you're seeing errors when opening ports 0-3 due to the DTR calls which I guess no one noticed or cared about before?

Before you sent me the lsusb I searched for it and came across the below thread where Bjørn's having a go at SIMCom. In it there's output from a second device using the same id but with entirely different descriptors.

	https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3

If this is a common theme with this vendor we may need to be extra careful when making changes.

Johan

#4 lore raw
Quoted 34 lines · Johan Hovold

Adding Bjørn.

Quoted 31 lines · Måns Rullgård
Quoted 28 lines · Johan Hovold
Quoted 15 lines · Mans Rullgard

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -0
index fb544340888b..af4cbfecc3ff 100644

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1073

Quoted 9 lines
drivers/usb/serial/option.c +2 -1
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Could you please provide the output of usb-devices (or lsusb -v) for this device?

Quoted 8 lines
Quoted 2 lines

lsusb -v:
[...]

So the patch looks fine to me. The fifth interface is QMI, but hasn't been available for use until now then, and this seems to have been the vendors idea from the start:

http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf

That document predates the qmi-wwan driver in the kernel. Note that this driver has an ID table entry for interface 4 of this device. Right now, whichever driver is probed first claims that interface. I haven't actually tried using the QMI interface, though.

Quoted 2 lines

And you're seeing errors when opening ports 0-3 due to the DTR calls which I guess no one noticed or cared about before?

Right, some userspace tools complain about this.

Quoted 8 lines

Before you sent me the lsusb I searched for it and came across the below thread where Bjørn's having a go at SIMCom. In it there's output from a second device using the same id but with entirely different descriptors.

	https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3

If this is a common theme with this vendor we may need to be extra careful when making changes.

Isn't this a common theme with most USB vendors, especially wireless things?

Regardless, setting the NCTRL flag should be harmless.

#5 lore raw
Quoted 59 lines · Måns Rullgård
Quoted 34 lines · Johan Hovold

Adding Bjørn.

Quoted 31 lines · Måns Rullgård
Quoted 28 lines · Johan Hovold
Quoted 15 lines · Mans Rullgard

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -0
index fb544340888b..af4cbfecc3ff 100644

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1073

Quoted 9 lines
drivers/usb/serial/option.c +2 -1
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Could you please provide the output of usb-devices (or lsusb -v) for this device?

Quoted 8 lines
Quoted 2 lines

lsusb -v:
[...]

So the patch looks fine to me. The fifth interface is QMI, but hasn't been available for use until now then, and this seems to have been the vendors idea from the start:

http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf

That document predates the qmi-wwan driver in the kernel. Note that this driver has an ID table entry for interface 4 of this device. Right now, whichever driver is probed first claims that interface. I haven't actually tried using the QMI interface, though.

Quoted 2 lines

And you're seeing errors when opening ports 0-3 due to the DTR calls which I guess no one noticed or cared about before?

Right, some userspace tools complain about this.

Quoted 4 lines

Before you sent me the lsusb I searched for it and came across the below thread where Bjørn's having a go at SIMCom. In it there's output from a second device using the same id but with entirely different descriptors.

Quoted 8 lines
Quoted 4 lines
	https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3

If this is a common theme with this vendor we may need to be extra careful when making changes.

Isn't this a common theme with most USB vendors, especially wireless things?

Regardless, setting the NCTRL flag should be harmless.

Any further comments on this?

maintainer
#6 lore raw
In reply to Måns Rullgård
Quoted 43 lines · Måns Rullgård
Quoted 41 lines · Johan Hovold

Adding Bjørn.

Quoted 31 lines · Måns Rullgård
Quoted 20 lines · Johan Hovold
Quoted 19 lines · Mans Rullgard

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -1
index fb544340888b..af4cbfecc3ff 100644
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
Quoted 8 lines

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1073

Quoted 5 lines
drivers/usb/serial/option.c +2 -0
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Could you please provide the output of usb-devices (or lsusb -v) for this device?

Quoted 2 lines

lsusb -v:
[...]

So the patch looks fine to me. The fifth interface is QMI, but hasn't been available for use until now then, and this seems to have been the vendors idea from the start:

Quoted 6 lines
Quoted 1 line

http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf

That document predates the qmi-wwan driver in the kernel. Note that this driver has an ID table entry for interface 4 of this device. Right now, whichever driver is probed first claims that interface. I haven't actually tried using the QMI interface, though.

I didn't say it was correct, just that the vendor proposed binding to it anyway.

Quoted 4 lines
Quoted 2 lines

And you're seeing errors when opening ports 0-3 due to the DTR calls which I guess no one noticed or cared about before?

Right, some userspace tools complain about this.

Hmm. You shouldn't see any errors on open (they're not even logged), but I guess your user space tools complains on receiving -EPROTO instead of -EINVAL when trying to manage these signals directly?

Quoted 4 lines
Quoted 4 lines

Before you sent me the lsusb I searched for it and came across the below thread where Bjørn's having a go at SIMCom. In it there's output from a second device using the same id but with entirely different descriptors.

Quoted 8 lines
Quoted 4 lines
	https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3

If this is a common theme with this vendor we may need to be extra careful when making changes.

Isn't this a common theme with most USB vendors, especially wireless things?

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least for the QMI interface. But we can always revert if anyone complains.

Now applied, thanks.

Johan

#7 lore raw
Quoted 54 lines · Johan Hovold
Quoted 43 lines · Måns Rullgård
Quoted 41 lines · Johan Hovold

Adding Bjørn.

Quoted 31 lines · Måns Rullgård
Quoted 20 lines · Johan Hovold
Quoted 19 lines · Mans Rullgard

The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a network interface supported by the qmi-wwan driver. Furthermore, the serial ports do not support modem control signals. Add driver_info flags to reflect this.

---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -1
index fb544340888b..af4cbfecc3ff 100644
@@ -1066,7 +1066,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = RSVD(3) },
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
-	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
Quoted 8 lines

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1073

Quoted 5 lines
drivers/usb/serial/option.c +2 -0
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000), /* SIMCom SIM5218 */
+	  .driver_info = NCTRL(0) | NCTRL(1) | NCTRL(2) | NCTRL(3) | RSVD(4) },
 	/* Quectel products using Qualcomm vendor ID */
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),

Could you please provide the output of usb-devices (or lsusb -v) for this device?

Quoted 2 lines

lsusb -v:
[...]

So the patch looks fine to me. The fifth interface is QMI, but hasn't been available for use until now then, and this seems to have been the vendors idea from the start:

Quoted 6 lines
Quoted 1 line

http://www.microchip.ua/simcom/WCDMA/APPNOTES/SIMCom_3G_Linux_driver_Application%20Note_V1.00.pdf

That document predates the qmi-wwan driver in the kernel. Note that this driver has an ID table entry for interface 4 of this device. Right now, whichever driver is probed first claims that interface. I haven't actually tried using the QMI interface, though.

I didn't say it was correct, just that the vendor proposed binding to it anyway.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

And you're seeing errors when opening ports 0-3 due to the DTR calls which I guess no one noticed or cared about before?

Right, some userspace tools complain about this.

Hmm. You shouldn't see any errors on open (they're not even logged), but I guess your user space tools complains on receiving -EPROTO instead of -EINVAL when trying to manage these signals directly?

Yes, one specific case is pyserial. On open, it attempts to set those signals and, depending on the error returned, either aborts or marks them as unavailable.

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines

Before you sent me the lsusb I searched for it and came across the below thread where Bjørn's having a go at SIMCom. In it there's output from a second device using the same id but with entirely different descriptors.

	https://forum.openwrt.org/t/lte-wireless-module-support-by-openwrt-led-on-tplink/13586?page=3

If this is a common theme with this vendor we may need to be extra careful when making changes.

Quoted 6 lines
Quoted 3 lines

Isn't this a common theme with most USB vendors, especially wireless things?

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least for the QMI interface. But we can always revert if anyone complains.

The QMI interface doesn't even pretend to be a uart. The other ones do, but there isn't actually any real uart behind them. For instance, it doesn't matter what baud rate one sets.

Quoted 1 line

Now applied, thanks.

Thanks.

maintainer
#8 lore raw
Quoted 10 lines · Måns Rullgård
Quoted 4 lines · Johan Hovold
Quoted 1 line

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least for the QMI interface. But we can always revert if anyone complains.

The QMI interface doesn't even pretend to be a uart. The other ones do, but there isn't actually any real uart behind them. For instance, it doesn't matter what baud rate one sets.

Sure, but some devices still require "DTR" to be set for the QMI interface, so there not being any real uart is no guarantee that there is no firmware that expects these calls.

Johan

#9 lore raw
Quoted 8 lines · Johan Hovold
Quoted 7 lines · Måns Rullgård
Quoted 4 lines · Johan Hovold
Quoted 1 line

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least for the QMI interface. But we can always revert if anyone complains.

Quoted 7 lines
Quoted 3 lines

The QMI interface doesn't even pretend to be a uart. The other ones do, but there isn't actually any real uart behind them. For instance, it doesn't matter what baud rate one sets.

Sure, but some devices still require "DTR" to be set for the QMI interface, so there not being any real uart is no guarantee that there is no firmware that expects these calls.

Now I'm thoroughly confused. The QMI interface has a completely separate driver that creates a network device (if I'm reading the code correctly).

maintainer
#10 lore raw
Quoted 14 lines · Måns Rullgård
Quoted 12 lines · Johan Hovold
Quoted 10 lines · Måns Rullgård
Quoted 4 lines · Johan Hovold
Quoted 1 line

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least for the QMI interface. But we can always revert if anyone complains.

The QMI interface doesn't even pretend to be a uart. The other ones do, but there isn't actually any real uart behind them. For instance, it doesn't matter what baud rate one sets.

Quoted 7 lines
Quoted 3 lines

Sure, but some devices still require "DTR" to be set for the QMI interface, so there not being any real uart is no guarantee that there is no firmware that expects these calls.

Now I'm thoroughly confused. The QMI interface has a completely separate driver that creates a network device (if I'm reading the code correctly).

I was just giving an example of firmware sometimes doing unexpected things.

Johan

maintainer
#11 lore raw
Quoted 19 lines · Johan Hovold
Quoted 18 lines · Måns Rullgård
Quoted 15 lines · Johan Hovold
Quoted 10 lines · Måns Rullgård
Quoted 4 lines · Johan Hovold
Quoted 1 line

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least for the QMI interface. But we can always revert if anyone complains.

The QMI interface doesn't even pretend to be a uart. The other ones do, but there isn't actually any real uart behind them. For instance, it doesn't matter what baud rate one sets.

Sure, but some devices still require "DTR" to be set for the QMI interface, so there not being any real uart is no guarantee that there is no firmware that expects these calls.

Quoted 6 lines
Quoted 3 lines

Now I'm thoroughly confused. The QMI interface has a completely separate driver that creates a network device (if I'm reading the code correctly).

I was just giving an example of firmware sometimes doing unexpected things.

See 93725149794d ("net: qmi_wwan: MDM9x30 specific power management") for some background.

Johan

#12 lore raw
Quoted 30 lines · Johan Hovold
Quoted 29 lines · Johan Hovold
Quoted 27 lines · Måns Rullgård
Quoted 15 lines · Johan Hovold
Quoted 8 lines · Måns Rullgård
Quoted 6 lines · Johan Hovold
Quoted 1 line

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least
for the QMI interface. But we can always revert if anyone complains.

Quoted 5 lines

The QMI interface doesn't even pretend to be a uart. The other ones do,
but there isn't actually any real uart behind them. For instance, it
doesn't matter what baud rate one sets.

Quoted 5 lines

Sure, but some devices still require "DTR" to be set for the QMI
interface, so there not being any real uart is no guarantee that there
is no firmware that expects these calls.

Now I'm thoroughly confused. The QMI interface has a completely separate driver that creates a network device (if I'm reading the code
correctly).

Quoted 5 lines
Quoted 2 lines

I was just giving an example of firmware sometimes doing unexpected things.

See 93725149794d ("net: qmi_wwan: MDM9x30 specific power management") for some background.

TLDR; some firmware uses the DTR signal as an indicator to come out of low-power mode. Without doing so you cannot talk to the modem over any of it's ports, QMI, net, or serial.

Dan

#13 lore raw
Quoted 34 lines · Dan Williams
Quoted 33 lines · Johan Hovold
Quoted 31 lines · Johan Hovold
Quoted 23 lines · Måns Rullgård
Quoted 15 lines · Johan Hovold
Quoted 8 lines · Måns Rullgård
Quoted 6 lines · Johan Hovold
Quoted 1 line

Regardless, setting the NCTRL flag should be harmless.

Well, there are devices that depend on getting these requests, at least
for the QMI interface. But we can always revert if anyone complains.

Quoted 5 lines

The QMI interface doesn't even pretend to be a uart. The other ones do,
but there isn't actually any real uart behind them. For instance, it
doesn't matter what baud rate one sets.

Quoted 5 lines

Sure, but some devices still require "DTR" to be set for the QMI
interface, so there not being any real uart is no guarantee that there
is no firmware that expects these calls.

Quoted 4 lines

Now I'm thoroughly confused. The QMI interface has a completely separate driver that creates a network device (if I'm reading the code
correctly).

I was just giving an example of firmware sometimes doing unexpected things.

Quoted 6 lines
Quoted 2 lines

See 93725149794d ("net: qmi_wwan: MDM9x30 specific power management") for some background.

TLDR; some firmware uses the DTR signal as an indicator to come out of low-power mode. Without doing so you cannot talk to the modem over any of it's ports, QMI, net, or serial.

I must be missing something, but how does a network interface have a DTR signal?

#14 lore raw
Quoted 8 lines · Måns Rullgård
Quoted 3 lines · Dan Williams

TLDR; some firmware uses the DTR signal as an indicator to come out of low-power mode. Without doing so you cannot talk to the modem over any of it's ports, QMI, net, or serial.

I must be missing something, but how does a network interface have a DTR signal?

It does not. But the network function is (ab)using the Comm class USB control message "SetControlLineState" to signal "wake up" from the host to the device. Which is perfectly fine since the USB function in question is vendor specific. The vendor can define any USB control message to mean anything they want. Reusing a Comm class message probably made sense to the firmware engineer designing this. We can only note and adapt.

It doesn't have anything to do with DTR.

Bjørn

#15 lore raw
Quoted 18 lines · Bjørn Mork
Quoted 8 lines · Måns Rullgård
Quoted 3 lines · Dan Williams

TLDR; some firmware uses the DTR signal as an indicator to come out of low-power mode. Without doing so you cannot talk to the modem over any of it's ports, QMI, net, or serial.

I must be missing something, but how does a network interface have a DTR signal?

It does not. But the network function is (ab)using the Comm class USB control message "SetControlLineState" to signal "wake up" from the host to the device. Which is perfectly fine since the USB function in question is vendor specific. The vendor can define any USB control message to mean anything they want. Reusing a Comm class message probably made sense to the firmware engineer designing this. We can only note and adapt.

Quoted 1 line

It doesn't have anything to do with DTR.

Every time you think USB can't get any worse, it does.

#16 lore raw
Quoted 1 line · Måns Rullgård

Every time you think USB can't get any worse, it does.

You can't blame vendor creativity on the bus spec. Look at what the same vendors do to e.g. SCSI to make these firmwares appear as different USB devices. The fact that some of then use "eject" as a signal to reboot the firmware into some other mode is not a SCSI problem.

But I do agree that USB should have dropped "vendor specific" and mandated class functions for everything. In theory. In practice, that would probably have casued USB to lose to some other competing spec with vendor specific as an option...

Bjørn