hw/rdma: Fix the error prints in create_qp_rings()
PATCH 1/1 hw/rdma: Fix the error prints in create_qp_rings()
The prints should indicate that we are talking about QP and not CQ.
Fixes 98d176f8e592 ("hw/rdma: PVRDMA commands and data-path ops")
Reviewed-by Yuval Shaia <[email protected]>
Signed-off-by Kamal Heib <[email protected]>
--- hw/rdma/vmw/pvrdma_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
hw/rdma/vmw/pvrdma_cmd.c +3 -3
@@ -374,13 +374,13 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, dir =rdma_pci_dma_map (pci_dev, pdir_dma,TARGET_PAGE_SIZE );if (!dir) { -rdma_error_report ("Failed to map to CQ page directory" ); +rdma_error_report ("Failed to map to QP page directory" ); goto out; } tbl =rdma_pci_dma_map (pci_dev, dir[0 ],TARGET_PAGE_SIZE );if (!tbl) { -rdma_error_report ("Failed to map to CQ page table" ); +rdma_error_report ("Failed to map to QP page table" ); goto out; }
@@ -393,7 +393,7 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, sr->ring_state = (struct pvrdma_ring *)rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE );if (!sr->ring_state) { -rdma_error_report ("Failed to map to CQ ring state" ); +rdma_error_report ("Failed to map to QP ring state" ); goto out_free_sr_mem; }
Signature · 1 line
2.20.1
Quoted 14 lines · Kamal Heib
The prints should indicate that we are talking about QP and not CQ.
Fixes 98d176f8e592 ("hw/rdma: PVRDMA commands and data-path ops")Reviewed-by Yuval Shaia <[email protected]>Signed-off-by Kamal Heib <[email protected]>--- hw/rdma/vmw/pvrdma_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)hw/rdma/vmw/pvrdma_cmd.c +0
-0
hw/rdma/vmw/pvrdma_cmd.c static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, · line 377
Quoted 5 lines
hw/rdma/vmw/pvrdma_cmd.c +1
-1@@ -374,13 +374,13 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, dir =rdma_pci_dma_map (pci_dev, pdir_dma,TARGET_PAGE_SIZE );if (!dir) { -rdma_error_report ("Failed to map to CQ page directory" ); +rdma_error_report ("Failed to map to QP page directory" );
I guess it is based on latest patch-set, suggesting to specify it next time.
Quoted 11 lines
hw/rdma/vmw/pvrdma_cmd.c +1
-1goto out; } tbl =rdma_pci_dma_map (pci_dev, dir[0 ],TARGET_PAGE_SIZE );if (!tbl) { -rdma_error_report ("Failed to map to CQ page table" ); +rdma_error_report ("Failed to map to QP page table" ); goto out; }
hw/rdma/vmw/pvrdma_cmd.c static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, · line 399
Quoted 8 lines
hw/rdma/vmw/pvrdma_cmd.c +1
-1@@ -393,7 +393,7 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, sr->ring_state = (struct pvrdma_ring *)rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE );if (!sr->ring_state) { -rdma_error_report ("Failed to map to CQ ring state" ); +rdma_error_report ("Failed to map to QP ring state" ); goto out_free_sr_mem; }
Thanks!
Reviewed-by Yuval Shaia <[email protected]>
Quoted 4 lines
Signature · 1 line
2.20.1