net: dev: Use unsigned integer as an argument to left-shift
Subsystems (2)
PATCH 1/1 net: dev: Use unsigned integer as an argument to left-shift
1 << 31 is Undefined Behaviour according to the C standard. Use U type modifier to avoid theoretical overflow.
Signed-off-by Andy Shevchenko <[email protected]>
--- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/netdevice.h +1 -1
@@ -3861,7 +3861,7 @@ static inline u32 netif_msg_init(int debug_value, int default_msg_enable_bits)if (debug_value ==0 )/* no output */ return 0 ;/* set low N bits */ -return (1 << debug_value) -1 ; +return (1U << debug_value) -1 ; }static inline void __netif_tx_lock (struct netdev_queue *txq,int cpu)
Signature · 1 line
2.20.1
From: Andy Shevchenko <[email protected]>
Date: Wed, 27 Feb 2019 13:37:26 +0300
Quoted 4 lines
1 << 31 is Undefined Behaviour according to the C standard. Use U type modifier to avoid theoretical overflow.
Signed-off-by Andy Shevchenko <[email protected]>
Applied, thanks Andy.