Skip to contentSkip to conversation

Drop support for I2C 10 bit devices from I3C subsystem

PATCH Superseded Przemyslaw Gaj 3 participants 8 messages Feb 26, 2019 – Feb 27, 2019

Subsystems (3)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Przemyslaw Gaj

author maintainer
#0 lore raw

v2 cover Drop support for I2C 10 bit devices from I3C subsystem

I3C MIPI spec does not clearly say that I2C 10bit devices are supported. Additionally, it isn't possible to pass 10 bit device properly through DEFSLVS command and reserve address for such device on secondary master side.

Przemyslaw Gaj (3):
i3c: Drop support for I2C 10 bit addresing
i3c: master: cdns: Drop support for I2C 10 bit addresing in Cadence
I3C master
dt-bindings: i3c: Document dropped support for I2C 10 bit devices

 Documentation/devicetree/bindings/i3c/i3c.txt | 4 +++-
 drivers/i3c/master.c                          | 9 +++++++++
 drivers/i3c/master/i3c-master-cdns.c          | 4 +---
 3 files changed, 13 insertions(+), 4 deletions(-)
Signature · 7 lines
2.8.3


_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
author maintainer
#1 lore raw

PATCH v2 1/3 i3c: Drop support for I2C 10 bit addresing

This patch dropps support for I2C devices with 10 bit addressing. When I2C device with 10 bit address is defined in DT, I3C master registration fails.

---

Main changes between v1 and v2 are:
- Add error message when registering I2C device with 10 bit address.

---
 drivers/i3c/master.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/i3c/master.c +9 -0
index 2dc628d..8c1e365 100644
@@ -1962,6 +1962,15 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	if (ret)
 		return ret;
 
+	/* The I3C Specification does not clearly say I2C devices with 10-bit
+	 * address are supported. These devices can't be passed properly through
+	 * DEFSLVS command.
+	 */
+	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
+		dev_err(&master->dev, "I2C device with 10 bit address not supported.");
+		return -ENOTSUPP;
+	}
+
 	/* LVR is encoded in reg[2]. */
 	boardinfo->lvr = reg[2];
 
Signature · 7 lines
2.8.3


_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
#2 lore raw

Re: [PATCH v2 1/3] i3c: Drop support for I2C 10 bit addresing

Quoted 19 lines · Przemyslaw Gaj

This patch dropps support for I2C devices with 10 bit addressing. When I2C device with 10 bit address is defined in DT, I3C master registration fails.

---

Main changes between v1 and v2 are:
- Add error message when registering I2C device with 10 bit address.

---
 drivers/i3c/master.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/i3c/master.c +0 -0
index 2dc628d..8c1e365 100644

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1968

Quoted 7 lines
drivers/i3c/master.c +4 -0
@@ -1962,6 +1962,15 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	if (ret)
 		return ret;
 
+	/* The I3C Specification does not clearly say I2C devices with 10-bit
+	 * address are supported. These devices can't be passed properly through
+	 * DEFSLVS command.
+	 */

IMO we just need to say 10-bit address not used or not supported in i3c.

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1976

Quoted 8 lines
drivers/i3c/master.c +5 -0
+	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
+		dev_err(&master->dev, "I2C device with 10 bit address not supported.");
+		return -ENOTSUPP;
+	}
+
 	/* LVR is encoded in reg[2]. */
 	boardinfo->lvr = reg[2];
 

Also need to change:

#define I2C_MAX_ADDR            GENMASK(9, 0)
to
#define I2C_MAX_ADDR            GENMASK(6, 0)
in master.h file

Not sure about:
unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG]; @Boris can you check this part?

Best regards,
Vitor Soares

_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c

#3 lore raw

Re: [PATCH v2 1/3] i3c: Drop support for I2C 10 bit addresing

Hi Vitor,

Quoted 23 lines · On Wed, 27 Feb 2019 12:05:30 +0000 vitor <[email protected]> wrote:
Quoted 22 lines · Przemyslaw Gaj

This patch dropps support for I2C devices with 10 bit addressing. When I2C device with 10 bit address is defined in DT, I3C master registration fails.

---

Main changes between v1 and v2 are:
- Add error message when registering I2C device with 10 bit address.

---
 drivers/i3c/master.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/i3c/master.c +0 -0
index 2dc628d..8c1e365 100644
@@ -1962,6 +1962,15 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	if (ret)
 		return ret;
 
Quoted 6 lines

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1968

Quoted 4 lines
drivers/i3c/master.c +4 -0
+	/* The I3C Specification does not clearly say I2C devices with 10-bit
+	 * address are supported. These devices can't be passed properly through
+	 * DEFSLVS command.
+	 */  

IMO we just need to say 10-bit address not used or not supported in i3c.

I'd like to keep a clear comment on why it cannot supported right now even though the spec is unclear about that. If the spec is updated to state that I2C devs using extended addresses are forbidden, then we'll update this comment accordingly.

Quoted 12 lines

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1976

Quoted 9 lines
drivers/i3c/master.c +5 -0
+	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
+		dev_err(&master->dev, "I2C device with 10 bit address not supported.");
+		return -ENOTSUPP;
+	}
+
 	/* LVR is encoded in reg[2]. */
 	boardinfo->lvr = reg[2];
 

Also need to change:

Quoted 4 lines

#define I2C_MAX_ADDR            GENMASK(9, 0)
to
#define I2C_MAX_ADDR            GENMASK(6, 0)
in master.h file

Yep, you can reduce the address space.

Quoted 4 lines

Not sure about:
unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG]; @Boris can you check this part?

This part is still valid, no need to update it as you already updated I2C_MAX_ADDR.

Thanks for the review.

Boris

_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c

#4 lore raw

Re: [PATCH v2 1/3] i3c: Drop support for I2C 10 bit addresing

Hi,

Quoted 33 lines · Boris Brezillon

Hi Vitor,

Quoted 23 lines · On Wed, 27 Feb 2019 12:05:30 +0000 vitor <[email protected]> wrote:
Quoted 22 lines · Przemyslaw Gaj

This patch dropps support for I2C devices with 10 bit addressing. When I2C device with 10 bit address is defined in DT, I3C master registration fails.

---

Main changes between v1 and v2 are:
- Add error message when registering I2C device with 10 bit address.

---
 drivers/i3c/master.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/i3c/master.c +0 -0
index 2dc628d..8c1e365 100644
@@ -1962,6 +1962,15 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	if (ret)
 		return ret;
 
Quoted 5 lines

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1968

Quoted 4 lines
drivers/i3c/master.c +4 -0
+	/* The I3C Specification does not clearly say I2C devices with 10-bit
+	 * address are supported. These devices can't be passed properly through
+	 * DEFSLVS command.
+	 */  

IMO we just need to say 10-bit address not used or not supported in i3c.

Quoted 4 lines

I'd like to keep a clear comment on why it cannot supported right now even though the spec is unclear about that. If the spec is updated to state that I2C devs using extended addresses are forbidden, then we'll update this comment accordingly.

I'm not sure if the terms aren't the same, but let's keep the comment.

Quoted 20 lines
Quoted 11 lines

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1976

Quoted 9 lines
drivers/i3c/master.c +5 -0
+	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
+		dev_err(&master->dev, "I2C device with 10 bit address not supported.");
+		return -ENOTSUPP;
+	}
+
 	/* LVR is encoded in reg[2]. */
 	boardinfo->lvr = reg[2];
 

Also need to change:

Quoted 4 lines

#define I2C_MAX_ADDR            GENMASK(9, 0)
to
#define I2C_MAX_ADDR            GENMASK(6, 0)
in master.h file

Yep, you can reduce the address space.

Quoted 3 lines

Not sure about:
unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG]; @Boris can you check this part?

Quoted 6 lines

This part is still valid, no need to update it as you already updated I2C_MAX_ADDR.

Thanks for the review.

Boris

Also we can make i2c_algorithm.functionality = I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C, and in this way we won't need ->i2c_func() and avoid the I2C_FUNC_10BIT_ADDR flag on host controller side.

Best regards,
Vitor Soares

_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c

#5 lore raw

Re: [PATCH v2 1/3] i3c: Drop support for I2C 10 bit addresing

Quoted 31 lines · On Wed, 27 Feb 2019 12:52:42 +0000 vitor <[email protected]> wrote:

Hi,

Quoted 28 lines · Boris Brezillon

Hi Vitor,

Quoted 23 lines · On Wed, 27 Feb 2019 12:05:30 +0000 vitor <[email protected]> wrote:
Quoted 22 lines · Przemyslaw Gaj

This patch dropps support for I2C devices with 10 bit addressing. When I2C device with 10 bit address is defined in DT, I3C master registration fails.

---

Main changes between v1 and v2 are:
- Add error message when registering I2C device with 10 bit address.

---
 drivers/i3c/master.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/i3c/master.c +0 -0
index 2dc628d..8c1e365 100644
@@ -1962,6 +1962,15 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	if (ret)
 		return ret;
 
Quoted 1 line
Quoted 1 line
Quoted 1 line

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1965

Quoted 1 line
drivers/i3c/master.c +1 -0
+	/* The I3C Specification does not clearly say I2C devices with 10-bit

Nitpick: please do not use net-style comments in the I3C subsystem.

Use

/*
* blablabla
*/

instead.

Quoted 10 lines
Quoted 8 lines
Quoted 4 lines

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1968

Quoted 3 lines
drivers/i3c/master.c +3 -0
+	 * address are supported. These devices can't be passed properly through
+	 * DEFSLVS command.
+	 */    

IMO we just need to say 10-bit address not used or not supported in i3c.

I'd like to keep a clear comment on why it cannot supported right now even though the spec is unclear about that. If the spec is updated to state that I2C devs using extended addresses are forbidden, then we'll update this comment accordingly.

I'm not sure if the terms aren't the same,

Don't understand what you mean, sorry.

Quoted 22 lines

but let's keep the comment.

Quoted 20 lines
Quoted 11 lines

drivers/i3c/master.c of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, · line 1976

Quoted 9 lines
drivers/i3c/master.c +5 -0
+	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
+		dev_err(&master->dev, "I2C device with 10 bit address not supported.");
+		return -ENOTSUPP;
+	}
+
 	/* LVR is encoded in reg[2]. */
 	boardinfo->lvr = reg[2];
 

Also need to change:

Quoted 4 lines

#define I2C_MAX_ADDR            GENMASK(9, 0)
to
#define I2C_MAX_ADDR            GENMASK(6, 0)
in master.h file

Yep, you can reduce the address space.

Quoted 3 lines

Not sure about:
unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG]; @Boris can you check this part?

Quoted 8 lines
Quoted 6 lines

This part is still valid, no need to update it as you already updated I2C_MAX_ADDR.

Thanks for the review.

Boris

Also we can make i2c_algorithm.functionality = I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C, and in this way we won't need ->i2c_func() and avoid the I2C_FUNC_10BIT_ADDR flag on host controller side.

Ack. Let's rip ->i2c_func() out and return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C for everyone. We'll add it back if some drivers want to support SMBUS natively or if 10bit addressing appears to be needed at some point.

_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c

author maintainer
#6 lore raw

PATCH v2 2/3 i3c: master: cdns: Drop support for I2C 10 bit addresing in Cadence I3C master

In reply to Przemyslaw Gaj

Because this patch series dropped support for 10 bit I2C devices, support is also dropped in Cadence I3C master driver.

---
 drivers/i3c/master/i3c-master-cdns.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/i3c/master/i3c-master-cdns.c +1 -3
index 8889a4f..1797fbf 100644
@@ -1010,9 +1010,7 @@ static int cdns_i3c_master_attach_i2c_dev(struct i2c_dev_desc *dev)
 	master->free_rr_slots &= ~BIT(slot);
 	i2c_dev_set_master_data(dev, data);
 
-	writel(prepare_rr0_dev_address(dev->boardinfo->base.addr) |
-	       (dev->boardinfo->base.flags & I2C_CLIENT_TEN ?
-		DEV_ID_RR0_LVR_EXT_ADDR : 0),
+	writel(prepare_rr0_dev_address(dev->boardinfo->base.addr),
 	       master->regs + DEV_ID_RR0(data->id));
 	writel(dev->boardinfo->lvr, master->regs + DEV_ID_RR2(data->id));
 	writel(readl(master->regs + DEVS_CTRL) |
Signature · 7 lines
2.8.3


_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
author maintainer
#7 lore raw

PATCH v2 3/3 dt-bindings: i3c: Document dropped support for I2C 10 bit devices

In reply to Przemyslaw Gaj

Because this patch series dropped support for 10 bit I2C devices, I'm documenting this.

---
 Documentation/devicetree/bindings/i3c/i3c.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/i3c/i3c.txt +3 -1
index ab729a0..4ffe059 100644
@@ -39,7 +39,9 @@ valid here, but several new properties have been added.
 New constraint on existing properties:
 --------------------------------------
 - reg: contains 3 cells
-  + first cell : still encoding the I2C address
+  + first cell : still encoding the I2C address. 10 bit addressing is not
+    supported. Devices with 10 bit address can't be properly passed through
+    DEFSLVS command.
 
   + second cell: shall be 0
 
Signature · 7 lines
2.8.3


_______________________________________________
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c