Skip to contentSkip to conversation

iotests: use iotests.VM in 238

PATCH Applied Stefan Hajnoczi 2 participants 2 messages Feb 27, 2019 – Feb 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 iotests: use iotests.VM in 238

Test 238 does not require the kvm accelerator. Using the qtest accelerator allows the test to run in both non-kvm and non-tcg environments.

iotests.VM implicitly uses the qtest accelerator and is really the class that this test should be using. Switch to that instead of qemu.QEMUMachine.

---
 tests/qemu-iotests/238 | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
tests/qemu-iotests/238 +1 -6
index f81ee1112f..1c0a46fa90 100755
@@ -23,17 +23,12 @@ import os
 import iotests
 from iotests import log
 
-sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'scripts'))
-
-from qemu import QEMUMachine
-
 if iotests.qemu_default_machine == 's390-ccw-virtio':
     virtio_scsi_device = 'virtio-scsi-ccw'
 else:
     virtio_scsi_device = 'virtio-scsi-pci'
 
-vm = QEMUMachine(iotests.qemu_prog)
-vm.add_args('-machine', 'accel=kvm')
+vm = iotests.VM()
 vm.launch()
 
 log(vm.qmp('blockdev-add', node_name='hd0', driver='null-co'))
Signature · 1 line
2.20.1
Applied
#1 lore raw

Am 27.02.2019 um 15:44 hat Stefan Hajnoczi geschrieben:

Quoted 10 lines

Test 238 does not require the kvm accelerator. Using the qtest accelerator allows the test to run in both non-kvm and non-tcg environments.

iotests.VM implicitly uses the qtest accelerator and is really the class that this test should be using. Switch to that instead of qemu.QEMUMachine.

Thanks, applied to the block branch.

Kevin