Skip to contentSkip to conversation

Staging: vt6655: Alignment of function parameters

PATCH In review Madhumitha Prabakaran 2 participants 2 messages Feb 26, 2019 – Feb 27, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Staging: vt6655: Alignment of function parameters

This patch align the function parameters to improve readibility.

---
Changes in v2
-Make a commit message imperative
-Use multiple lines to improve readibility

Changes in v3
-Commit message and subject line are modified
-Alignment of function parameters

---
 drivers/staging/vt6655/baseband.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/vt6655/baseband.c +3 -3
index 35bbff807df9..e3fecd732c88 100644
@@ -1705,9 +1705,9 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  *
  */
 unsigned int BBuGetFrameTime(unsigned char byPreambleType,
-	unsigned char byPktType,
-	unsigned int cbFrameLength,
-	unsigned short wRate)
+		unsigned char byPktType,
+		unsigned int cbFrameLength,
+		unsigned short wRate)
 {
 	unsigned int uFrameTime;
 	unsigned int uPreamble;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 21 lines · Madhumitha Prabakaran

This patch align the function parameters to improve readibility.

---
Changes in v2

(quoted diff) +0 -2
-Make a commit message imperative
-Use multiple lines to improve readibility

Changes in v3

(quoted diff) +0 -3
-Commit message and subject line are modified
-Alignment of function parameters
---
 drivers/staging/vt6655/baseband.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/vt6655/baseband.c +0 -0
index 35bbff807df9..e3fecd732c88 100644

drivers/staging/vt6655/baseband.c static const unsigned short awcFrameTime[MAX_RATE] = { · line 1710

Quoted 9 lines
drivers/staging/vt6655/baseband.c +3 -3
@@ -1705,9 +1705,9 @@ static const unsigned short awcFrameTime[MAX_RATE] = {
  *
  */
 unsigned int BBuGetFrameTime(unsigned char byPreambleType,
-	unsigned char byPktType,
-	unsigned int cbFrameLength,
-	unsigned short wRate)
+		unsigned char byPktType,
+		unsigned int cbFrameLength,
+		unsigned short wRate)

They should line up with the variable above it, so this should end up looking like:
unsigned int BBuGetFrameTime(unsigned char byPreambleType,
unsigned char byPktType, unsigned int cbFrameLength, unsigned short wRate)

But, given that there is no need to put one variable per line, you can shorten this and make it look like:

unsigned int BBuGetFrameTime(unsigned char byPreambleType,
unsigned char byPktType,
unsigned int cbFrameLength, unsigned short wRate)

thanks,

greg k-h