xen, fbfront: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

    if (dev->state == XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/video/fbdev/xen-fbfront.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/video/fbdev/xen-fbfront.c +1 -1

index 6a4bbc9e1fb0..a3d6b6db221b 100644
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
  	case XenbusStateClosed:
  		if (dev->state == XenbusStateClosed)
  			break;
-		/* Missed the backend's CLOSING state -- fallthrough */
+		/* fall through - Missed the backend's CLOSING state. */
  	case XenbusStateClosing:
  		xenbus_frontend_closed(dev);
  		break;

+Xen-devel list

Quoted 39 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (dev->state = XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/video/fbdev/xen-fbfront.c | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/video/fbdev/xen-fbfront.c +0 -0

index 6a4bbc9e1fb0..a3d6b6db221b 100644
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,

      case XenbusStateClosed:
          if (dev->state = XenbusStateClosed)
              break;
-        /* Missed the backend's CLOSING state -- fallthrough */ +        /* fall through - Missed the backend's CLOSING state. */ case XenbusStateClosing:
          xenbus_frontend_closed(dev);
          break;

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

Quoted 42 lines · Oleksandr Andrushchenko

+Xen-devel list

Quoted 39 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

    if (dev->state == XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/video/fbdev/xen-fbfront.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/video/fbdev/xen-fbfront.c +1 -1

index 6a4bbc9e1fb0..a3d6b6db221b 100644
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
      case XenbusStateClosed:
          if (dev->state == XenbusStateClosed)
              break;
-        /* Missed the backend's CLOSING state -- fallthrough */
+        /* fall through - Missed the backend's CLOSING state. */
      case XenbusStateClosing:
          xenbus_frontend_closed(dev);
          break;

Hi,

Quoted 5 lines · Gustavo A. R. Silva

Hi all,

Friendly ping:

Who can take this?

I'll take this for v5.2.

Hi,

Quoted 5 lines · Gustavo A. R. Silva

Hi all,

Friendly ping:

Who can take this?

I'll take this for v5.2.

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

Quoted 29 lines · Oleksandr Andrushchenko

+Xen-devel list

Quoted 26 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

    if (dev->state == XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/video/fbdev/xen-fbfront.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 5 lines

Quoted 5 lines

drivers/video/fbdev/xen-fbfront.c +0 -0

index 6a4bbc9e1fb0..a3d6b6db221b 100644
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,

Quoted 8 lines

drivers/video/fbdev/xen-fbfront.c static void xenfb_backend_changed(struct xenbus_device *dev, · line 683

Quoted 8 lines

drivers/video/fbdev/xen-fbfront.c +1 -1

      case XenbusStateClosed:
          if (dev->state == XenbusStateClosed)
              break;
-        /* Missed the backend's CLOSING state -- fallthrough */
+        /* fall through - Missed the backend's CLOSING state. */
      case XenbusStateClosing:
          xenbus_frontend_closed(dev);
          break;

+Xen-devel list

Quoted 26 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (dev->state == XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/video/fbdev/xen-fbfront.c | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 5 lines

drivers/video/fbdev/xen-fbfront.c +0 -0

index 6a4bbc9e1fb0..a3d6b6db221b 100644
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,

Quoted 8 lines

      case XenbusStateClosed:
          if (dev->state == XenbusStateClosed)
              break;
-        /* Missed the backend's CLOSING state -- fallthrough */ +        /* fall through - Missed the backend's CLOSING state. */ case XenbusStateClosing:
          xenbus_frontend_closed(dev);
          break;

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

    if (dev->state == XenbusStateClosed)
       ^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
   case XenbusStateClosing:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/video/fbdev/xen-fbfront.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/video/fbdev/xen-fbfront.c +0 -0

index 6a4bbc9e1fb0..a3d6b6db221b 100644