sctp: chunk.c: correct format string for size_t in printk
Subsystems (3)
PATCH 1/1 sctp: chunk.c: correct format string for size_t in printk
According to Documentation/core-api/printk-formats.rst, size_t should be printed with %zu, rather than %Zu.
In addition, using %Zu triggers a warning on clang (-Wformat-extra-args):
net/sctp/chunk.c:196:25: warning: data argument not used by format string [-Wformat-extra-args]
__func__, asoc, max_data);
~~~~~~~~~~~~~~~~^~~~~~~~~
./include/linux/printk.h:440:49: note: expanded from macro 'pr_warn_ratelimited'
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
./include/linux/printk.h:424:17: note: expanded from macro 'printk_ratelimited'
printk(fmt, ##__VA_ARGS__); \
~~~ ^--- net/sctp/chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sctp/chunk.c +1 -1
@@ -192,7 +192,7 @@ struct sctp_datamsg *sctp_datamsg_from_user(struct sctp_association *asoc,if (unlikely (!max_data)) { max_data =sctp_min_frag_point (sctp_sk (asoc->base.sk),sctp_datachk_len (&asoc->stream)); -pr_warn_ratelimited ("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%Zu)" , +pr_warn_ratelimited ("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%zu)" , __func__, asoc, max_data); }
Signature · 1 line
2.21.0.rc2.261.ga7da99ff1b-goog
Quoted 15 lines · Matthias Maennich
According to
Documentation/core-api/printk-formats.rst,size_tshould be printed with %zu, rather than %Zu.In addition, using %Zu triggers a warning on clang (-Wformat-extra-args):
net/sctp/chunk.c:196:25: warning: data argument not used by format string [-Wformat-extra-args]__func__, asoc, max_data); ~~~~~~~~~~~~~~~~^~~~~~~~~ ./include/linux/printk.h:440:49: note: expanded from macro 'pr_warn_ratelimited' printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ ./include/linux/printk.h:424:17: note: expanded from macro 'printk_ratelimited' printk(fmt, ##__VA_ARGS__); \ ~~~ ^
Quoted 3 lines
Fixes 5b5e0928f742 ("lib/vsprintf.c: remove %Z support")Signed-off-by Matthias Maennich <[email protected]>
Quoted 20 lines
--- net/sctp/chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/sctp/chunk.c +1
-1@@ -192,7 +192,7 @@ struct sctp_datamsg *sctp_datamsg_from_user(struct sctp_association *asoc,if (unlikely (!max_data)) { max_data =sctp_min_frag_point (sctp_sk (asoc->base.sk),sctp_datachk_len (&asoc->stream)); -pr_warn_ratelimited ("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%Zu)" , +pr_warn_ratelimited ("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%zu)" , __func__, asoc, max_data); }Signature · 1 line
2.21.0.rc2.261.ga7da99ff1b-goog
From: Matthias Maennich <[email protected]>
Date: Thu, 28 Feb 2019 11:36:52 +0000
Quoted 15 lines
According to
Documentation/core-api/printk-formats.rst,size_tshould be printed with %zu, rather than %Zu.In addition, using %Zu triggers a warning on clang (-Wformat-extra-args):
net/sctp/chunk.c:196:25: warning: data argument not used by format string [-Wformat-extra-args]__func__, asoc, max_data); ~~~~~~~~~~~~~~~~^~~~~~~~~ ./include/linux/printk.h:440:49: note: expanded from macro 'pr_warn_ratelimited' printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ ./include/linux/printk.h:424:17: note: expanded from macro 'printk_ratelimited' printk(fmt, ##__VA_ARGS__); \ ~~~ ^
Quoted 3 lines
Fixes 5b5e0928f742 ("lib/vsprintf.c: remove %Z support")Signed-off-by Matthias Maennich <[email protected]>
Applied, thanks.
Quoted 4 lines · Matthias Maennich
According to
Documentation/core-api/printk-formats.rst,size_tshould be printed with %zu, rather than %Zu.In addition, using %Zu triggers a warning on clang (-Wformat-extra-args):
[]
net/sctp/chunk.c
Quoted 1 line
net/sctp/chunk.c +0
-0
[]
net/sctp/chunk.c struct sctp_datamsg *sctp_datamsg_from_user(struct sctp_association *asoc, · line 196
Quoted 7 lines
net/sctp/chunk.c +1
-1@@ -192,7 +192,7 @@ struct sctp_datamsg *sctp_datamsg_from_user(struct sctp_association *asoc,if (unlikely (!max_data)) { max_data =sctp_min_frag_point (sctp_sk (asoc->base.sk),sctp_datachk_len (&asoc->stream)); -pr_warn_ratelimited ("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%Zu)" , +pr_warn_ratelimited ("%s: asoc:%p frag_point is zero, forcing max_data to default minimum (%zu)" , __func__, asoc, max_data);
trivia: the format is also missing a terminating '\n'