Skip to contentSkip to conversation

imx8mq_evk: Move CONFIG_ENV_IS_IN_MMC to Kconfig

PATCH New Fabio Estevam 2 participants 4 messages Feb 28, 2019 – Mar 1, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 imx8mq_evk: Move CONFIG_ENV_IS_IN_MMC to Kconfig

Currently the command "saveenv" is not available.

The CONFIG_ENV_IS_IN_MMC symbol has been converted to Kconfig, so fix the problem by moving it to the defconfig.

---
 configs/imx8mq_evk_defconfig | 1 +
 include/configs/imx8mq_evk.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
configs/imx8mq_evk_defconfig +1 -0
index 53025e45bc..889d8f1484 100644
@@ -22,6 +22,7 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8mq-evk"
+CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SAVED_DRAM_TIMING_BASE=0x40000000
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
include/configs/imx8mq_evk.h +0 -1
index f0430224cb..a9e38a70e6 100644
@@ -187,7 +187,6 @@
 #define CONFIG_ENV_OVERWRITE
 #define CONFIG_ENV_OFFSET               (64 * SZ_64K)
 #define CONFIG_ENV_SIZE			0x1000
-#define CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV		1   /* USDHC2 */
 #define CONFIG_MMCROOT			"/dev/mmcblk1p2"  /* USDHC2 */
 
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 2/2 imx8mq_evk: Add myself as a co-maintainer

I would like to help maintaining this board.

---
 board/freescale/imx8mq_evk/MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
board/freescale/imx8mq_evk/MAINTAINERS +1 -0
index a2e320cb10..a00bb4ef78 100644
@@ -1,5 +1,6 @@
 i.MX8MQ EVK BOARD
 M:	Peng Fan <[email protected]>
+M:	Fabio Estevam <[email protected]>
 S:	Maintained
 F:	board/freescale/imx8mq_evk/
 F:	include/configs/imx8mq_evk.h
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 imx8mq_evk: Add myself as a co-maintainer

Quoted 11 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2019年2月28日 19:46
To: sbabic at denx.de
Cc: Peng Fan <[email protected]>; u-boot at lists.denx.de; dl-uboot-imx <[email protected]>; spencercw at gmail.com; baruch at tkos.co.il; Fabio Estevam <[email protected]>
Subject: [PATCH 2/2] imx8mq_evk: Add myself as a co-maintainer

Quoted 3 lines

I would like to help maintaining this board.

Quoted 18 lines
---
 board/freescale/imx8mq_evk/MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
board/freescale/imx8mq_evk/MAINTAINERS +1 -1
index a2e320cb10..a00bb4ef78 100644
@@ -1,5 +1,6 @@
 i.MX8MQ EVK BOARD
 M:	Peng Fan <[email protected]>
+M:	Fabio Estevam <[email protected]>
 S:	Maintained
 F:	board/freescale/imx8mq_evk/
 F:	include/configs/imx8mq_evk.h
--

2.17.1

#3 lore raw

PATCH 1/2 imx8mq_evk: Move CONFIG_ENV_IS_IN_MMC to Kconfig

In reply to Fabio Estevam
Quoted 39 lines

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2019年2月28日 19:46
To: sbabic at denx.de
Cc: Peng Fan <[email protected]>; u-boot at lists.denx.de; dl-uboot-imx <[email protected]>; spencercw at gmail.com; baruch at tkos.co.il; Fabio Estevam <[email protected]>
Subject: [PATCH 1/2] imx8mq_evk: Move CONFIG_ENV_IS_IN_MMC to Kconfig

Currently the command "saveenv" is not available.

The CONFIG_ENV_IS_IN_MMC symbol has been converted to Kconfig, so fix the problem by moving it to the defconfig.

---
 configs/imx8mq_evk_defconfig | 1 +
 include/configs/imx8mq_evk.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
configs/imx8mq_evk_defconfig +0 -0
index 53025e45bc..889d8f1484 100644
@@ -22,6 +22,7 @@ CONFIG_CMD_EXT4_WRITE=y  CONFIG_CMD_FAT=y

CONFIG_OF_CONTROL=y
CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8mq-evk"

configs/imx8mq_evk_defconfig +1 -0
+CONFIG_ENV_IS_IN_MMC=y
 CONFIG_SAVED_DRAM_TIMING_BASE=0x40000000
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
include/configs/imx8mq_evk.h +0 -0
index f0430224cb..a9e38a70e6 100644

include/configs/imx8mq_evk.h line 191

Quoted 6 lines
include/configs/imx8mq_evk.h +0 -1
@@ -187,7 +187,6 @@
 #define CONFIG_ENV_OVERWRITE
 #define CONFIG_ENV_OFFSET               (64 * SZ_64K)
 #define CONFIG_ENV_SIZE			0x1000
-#define CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV		1   /* USDHC2 */
 #define CONFIG_MMCROOT			"/dev/mmcblk1p2"  /* USDHC2
Quoted 4 lines
include/configs/imx8mq_evk.h +0 -1
 */
 
--

2.17.1