Skip to contentSkip to conversation

Fix documentation of tls-verify script argument

PATCH In review [email protected]... 3 participants 3 messages Feb 1, 2019 – Feb 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix documentation of tls-verify script argument

From: Thomas Quinot <[email protected]...>

The second argument is the entire subject DN, not just the CN.

---
 doc/openvpn.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/openvpn.8 +1 -1
index 7abcaf1e..f80393ee 100644
@@ -5448,7 +5448,7 @@ is executed two arguments are appended after any arguments specified in
 .B cmd certificate_depth subject
 
 These arguments are, respectively, the current certificate depth and
-the X509 common name (cn) of the peer.
+the X509 subject distinguished name (dn) of the peer.
 
 This feature is useful if the peer you want to trust has a certificate
 which was signed by a certificate authority who also signed many
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 13 lines · On 01-02-19 21:43, [email protected]... wrote:

From: Thomas Quinot <[email protected]...>

The second argument is the entire subject DN, not just the CN.

---
 doc/openvpn.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/openvpn.8 +0 -0
index 7abcaf1e..f80393ee 100644

doc/openvpn.8 is executed two arguments are appended after any arguments specified in · line 5454

Quoted 8 lines
doc/openvpn.8 +1 -1
@@ -5448,7 +5448,7 @@ is executed two arguments are appended after any arguments specified in
 .B cmd certificate_depth subject
 
 These arguments are, respectively, the current certificate depth and
-the X509 common name (cn) of the peer.
+the X509 subject distinguished name (dn) of the peer.
 
 This feature is useful if the peer you want to trust has a certificate
 which was signed by a certificate authority who also signed many

This is indeed what we do. Thanks for the fix.

-Steffan

#2 lore raw
In reply to [email protected]...

Your patch has been applied to the master and release/2.4 branch. Thanks.

commit a35d517f4893b3967783ad7926a7edd08f9f59d3 (master) commit 4e36eb913dfe5b4e4d9c0c0637f480c5b9f63e33 (release/2.4)

Author: Thomas Quinot
Date:   Fri Feb 1 21:43:48 2019 +0100
     Fix documentation of tls-verify script argument

     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: <20190201204348.22326-1-openvpn-devel=lists.sourceforge.net@...2493...>
     URL: https://www.mail-archive.com/[email protected]/msg18195.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering