Skip to contentSkip to conversation

update NFIT flags error message

PATCH In review Toshi Kani 2 participants 2 messages Feb 28, 2019 – Mar 2, 2019

Subsystems (2)
lore
Share & tools
lore

Toshi Kani

author
#0 lore raw

PATCH 1/1 update NFIT flags error message

ACPI NFIT flags field reports major errors on NVDIMM, which need user's attention.

Update the current log to a proper error message with dev_err(). The current message string is kept for grep-compatibility.

Cc Dan Williams <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Robert Elliott <[email protected]>
---
 drivers/acpi/nfit/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/nfit/core.c +1 -1
index e18ade5d74e9..143a77704481 100644
@@ -2050,7 +2050,7 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc *acpi_desc)
 		if ((mem_flags & ACPI_NFIT_MEM_FAILED_MASK) == 0)
 			continue;
 
-		dev_info(acpi_desc->dev, "%s flags:%s%s%s%s%s\n",
+		dev_err(acpi_desc->dev, "Error found in NVDIMM %s flags:%s%s%s%s%s\n",
 				nvdimm_name(nvdimm),
 		  mem_flags & ACPI_NFIT_MEM_SAVE_FAILED ? " save_fail" : "",
 		  mem_flags & ACPI_NFIT_MEM_RESTORE_FAILED ? " restore_fail":"",
#1 lore raw
Quoted 7 lines · Toshi Kani

ACPI NFIT flags field reports major errors on NVDIMM, which need user's attention.

Update the current log to a proper error message with dev_err(). The current message string is kept for grep-compatibility.

Looks good, applied.