Skip to contentSkip to conversation

Add device tree support for kxcjk1013 accelerometer

PATCH Superseded Robert Yang 2 participants 5 messages Feb 28, 2019 – Mar 2, 2019

Subsystems (2)
Device tree bindings IIO

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover Add device tree support for kxcjk1013 accelerometer

- Add a vendor prefix for Kionix Inc. to device tree bindings. There is already one other Kionix accelerometer (kxsd9) with device tree bindings but this vendor prefix hasn't been documented.
- Document the kxcjk1013 device tree bindings.
- Add device tree support for Kionix kxcjk1013 accelerometer sensors.

Robert Yang (3):
dt-bindings: Add vendor prefix for Kionix, Inc.
dt-bindings: iio: accel: kxcjk1013: Add device tree binding
documentation
iio: accel: kxcjk1013: Add device tree support

 .../bindings/iio/accel/kionix,kxcjk1013.txt    | 18 ++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.txt    |  1 +
 drivers/iio/accel/kxcjk-1013.c                 | 11 +++++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/3 dt-bindings: Add vendor prefix for Kionix, Inc.

Kionix manufactured MEMs sensors. There are Kionix acceleromoter sensor drivers which can be used with device tree.

Signed-off-by Robert Yang <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 01732c887521..e28583ebe5e8 100644
@@ -208,6 +208,7 @@ kiebackpeter    Kieback & Peter GmbH
 kinetic Kinetic Technologies
 kingdisplay	King & Display Technology Co., Ltd.
 kingnovel	Kingnovel Technology Co., Ltd.
+kionix	Kionix, Inc.
 koe	Kaohsiung Opto-Electronics Inc.
 kosagi	Sutajio Ko-Usagi PTE Ltd.
 kyo	Kyocera Corporation
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH 2/3 dt-bindings: iio: accel: kxcjk1013: Add device tree binding documentation

In reply to Robert Yang

Document device tree bindings for Kionix KXCJK-1013 Accelerometer driver.

Signed-off-by Robert Yang <[email protected]>
---
 .../bindings/iio/accel/kionix,kxcjk1013.txt    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt
Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt new file +18 -0
new file mode 100644
index 000000000000..521c53799bc5
@@ -0,0 +1,18 @@
+Kionix KXCJK-1013 Accelerometer device tree bindings
+
+Required properties:
+
+- compatible: Must be one of:
+    "kionix,kxcjk1013"
+    "kionix,kxcj91008"
+    "kionix,kxtj21009"
+    "kionix,kxtf9"
+    "kionix,SMO8500"
+ - reg: i2c slave address
+
+Example:
+
+kxtf9@f {
+	compatible = "kionix,kxtf9";
+	reg = <0x0F>;
+};
Signature · 1 line
2.17.1
maintainer
#3 lore raw

Re: [PATCH 2/3] dt-bindings: iio: accel: kxcjk1013: Add device tree binding documentation

Quoted 3 lines · On Thu, 28 Feb 2019 15:18:10 -0500 Robert Yang <[email protected]> wrote:

Document device tree bindings for Kionix KXCJK-1013 Accelerometer driver.

Signed-off-by Robert Yang <[email protected]>

Hi Robert,

Thanks for this. One comment inline.

Jonathan

Quoted 11 lines
---
 .../bindings/iio/accel/kionix,kxcjk1013.txt    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt
Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt new file +0 -0
new file mode 100644
index 000000000000..521c53799bc5

Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt line 10

Quoted 10 lines
Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt new file +10 -0
@@ -0,0 +1,18 @@
+Kionix KXCJK-1013 Accelerometer device tree bindings
+
+Required properties:
+
+- compatible: Must be one of:
+    "kionix,kxcjk1013"
+    "kionix,kxcj91008"
+    "kionix,kxtj21009"
+    "kionix,kxtf9"
+    "kionix,SMO8500"

This looks like an ACPI binding rather than a device name. So I'd drop this last one.

Quoted 8 lines
Documentation/devicetree/bindings/iio/accel/kionix,kxcjk1013.txt new file +8 -0
+ - reg: i2c slave address
+
+Example:
+
+kxtf9@f {
+	compatible = "kionix,kxtf9";
+	reg = <0x0F>;
+};
author
#4 lore raw

PATCH 3/3 iio: accel: kxcjk1013: Add device tree support

In reply to Robert Yang

Add device tree support for kxcjk-1013 accelerometer sensors.

Signed-off-by Robert Yang <[email protected]>
---
 drivers/iio/accel/kxcjk-1013.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/iio/accel/kxcjk-1013.c +11 -0
index 7096e577b23f..e7a00743cdcb 100644
@@ -1510,10 +1510,21 @@ static const struct i2c_device_id kxcjk1013_id[] = {
 
 MODULE_DEVICE_TABLE(i2c, kxcjk1013_id);
 
+static const struct of_device_id kxcjk1013_of_match[] = {
+	{ .compatible = "kionix,kxcjk1013", },
+	{ .compatible = "kionix,kxcj91008", },
+	{ .compatible = "kionix,kxtj21009", },
+	{ .compatible = "kionix,kxtf9", },
+	{ .compatible = "kionix,SMO8500", },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, kxcjk1013_of_match);
+
 static struct i2c_driver kxcjk1013_driver = {
 	.driver = {
 		.name	= KXCJK1013_DRV_NAME,
 		.acpi_match_table = ACPI_PTR(kx_acpi_match),
+		.of_match_table = of_match_ptr(kxcjk1013_of_match),
 		.pm	= &kxcjk1013_pm_ops,
 	},
 	.probe		= kxcjk1013_probe,
Signature · 1 line
2.17.1