Skip to contentSkip to conversation

Staging: vt6655: Align a static function declaration

PATCH Superseded Madhumitha Prabakaran 2 participants 4 messages Feb 28, 2019 Staging

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 Staging: vt6655: Align a static function declaration

Align function arguments and function return type to improve readabilty.

---
Changes in v5
- Commit log and code diff are matching. In last commit, there was error from my side while reevaluating and commiting it again.

Changes in v4
- Commit log and code diff are matching

Changes in v3
- Included driver name in subject line.

Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/staging/vt6655/card.c +4 -11
index 3226dbaab3bb..f858f97cf119 100644
@@ -60,14 +60,9 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
 
 /*---------------------  Static Functions  --------------------------*/
 
-static
-void
-s_vCalculateOFDMRParameter(
-	unsigned char byRate,
-	u8 bb_type,
-	unsigned char *pbyTxRate,
-	unsigned char *pbyRsvTime
-);
+static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
+				       unsigned char *pbyTxRate,
+				       unsigned char *pbyRsvTime);
 
 /*---------------------  Export Functions  --------------------------*/
 
@@ -84,9 +79,7 @@ s_vCalculateOFDMRParameter(
  *
  * Return Value: none
  */
-static
-void
-s_vCalculateOFDMRParameter(
+static void s_vCalculateOFDMRParameter(
 	unsigned char byRate,
 	u8 bb_type,
 	unsigned char *pbyTxRate,
Signature · 1 line
2.17.1
#1 lore raw
Quoted 44 lines · Madhumitha Prabakaran

Align function arguments and function return type to improve readabilty.

---
Changes in v5
- Commit log and code diff are matching. In last commit, there was error from my side while reevaluating and commiting it again.

Changes in v4
- Commit log and code diff are matching

Changes in v3
- Included driver name in subject line.

Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/staging/vt6655/card.c +3 -8
index 3226dbaab3bb..f858f97cf119 100644
@@ -60,14 +60,9 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
 
 /*---------------------  Static Functions  --------------------------*/
 
-static
-void
-s_vCalculateOFDMRParameter(
-	unsigned char byRate,
-	u8 bb_type,
-	unsigned char *pbyTxRate,
-	unsigned char *pbyRsvTime
-);
+static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
+				       unsigned char *pbyTxRate,
+				       unsigned char *pbyRsvTime);
 
 /*---------------------  Export Functions  --------------------------*/
 

drivers/staging/vt6655/card.c s_vCalculateOFDMRParameter( · line 85

Quoted 10 lines
drivers/staging/vt6655/card.c +1 -3
@@ -84,9 +79,7 @@ s_vCalculateOFDMRParameter(
  *
  * Return Value: none
  */
-static
-void
-s_vCalculateOFDMRParameter(
+static void s_vCalculateOFDMRParameter(
 	unsigned char byRate,
 	u8 bb_type,
 	unsigned char *pbyTxRate,

You could realign the parameter list here as in the other case.

julia

Quoted 10 lines

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190228202810.26235-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 66 lines · Julia Lawall
Quoted 44 lines · Madhumitha Prabakaran

Align function arguments and function return type to improve readabilty.

---
Changes in v5
- Commit log and code diff are matching. In last commit, there was error from my side while reevaluating and commiting it again.

Changes in v4
- Commit log and code diff are matching

Changes in v3
- Included driver name in subject line.

Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/staging/vt6655/card.c +3 -8
index 3226dbaab3bb..f858f97cf119 100644
@@ -60,14 +60,9 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
 
 /*---------------------  Static Functions  --------------------------*/
 
-static
-void
-s_vCalculateOFDMRParameter(
-	unsigned char byRate,
-	u8 bb_type,
-	unsigned char *pbyTxRate,
-	unsigned char *pbyRsvTime
-);
+static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
+				       unsigned char *pbyTxRate,
+				       unsigned char *pbyRsvTime);
 
 /*---------------------  Export Functions  --------------------------*/
 

drivers/staging/vt6655/card.c s_vCalculateOFDMRParameter( · line 85

Quoted 10 lines
drivers/staging/vt6655/card.c +1 -3
@@ -84,9 +79,7 @@ s_vCalculateOFDMRParameter(
  *
  * Return Value: none
  */
-static
-void
-s_vCalculateOFDMRParameter(
+static void s_vCalculateOFDMRParameter(
 	unsigned char byRate,
 	u8 bb_type,
 	unsigned char *pbyTxRate,

You could realign the parameter list here as in the other case.

julia

Quoted 3 lines

--
2.17.1

Quoted 14 lines
Quoted 7 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190228202810.26235-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Signature · 5 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1902282140240.3134%40hadrien.
For more options, visit https://groups.google.com/d/optout.

I realigned the parameter list for function s_vCalculateOFDMRParameter. I don't know why it is showing in a mail like that after EXPORT FUNCTION Please correct me, if I'm understanding it in a wrong way

#3 lore raw
Quoted 82 lines · Madhumthia Prabakaran
Quoted 74 lines · Julia Lawall
Quoted 44 lines · Madhumitha Prabakaran

Align function arguments and function return type to improve readabilty.

---
Changes in v5
- Commit log and code diff are matching. In last commit, there was error from my side while reevaluating and commiting it again.

Changes in v4
- Commit log and code diff are matching

Changes in v3
- Included driver name in subject line.

Changes in v2
- Improved alignment of function declaration
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/staging/vt6655/card.c +3 -8
index 3226dbaab3bb..f858f97cf119 100644
@@ -60,14 +60,9 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
 
 /*---------------------  Static Functions  --------------------------*/
 
-static
-void
-s_vCalculateOFDMRParameter(
-	unsigned char byRate,
-	u8 bb_type,
-	unsigned char *pbyTxRate,
-	unsigned char *pbyRsvTime
-);
+static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
+				       unsigned char *pbyTxRate,
+				       unsigned char *pbyRsvTime);
 
 /*---------------------  Export Functions  --------------------------*/
 

drivers/staging/vt6655/card.c s_vCalculateOFDMRParameter( · line 85

Quoted 10 lines
drivers/staging/vt6655/card.c +1 -3
@@ -84,9 +79,7 @@ s_vCalculateOFDMRParameter(
  *
  * Return Value: none
  */
-static
-void
-s_vCalculateOFDMRParameter(
+static void s_vCalculateOFDMRParameter(
 	unsigned char byRate,
 	u8 bb_type,
 	unsigned char *pbyTxRate,

You could realign the parameter list here as in the other case.

julia

Quoted 10 lines

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190228202810.26235-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Quoted 6 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1902282140240.3134%40hadrien.
For more options, visit https://groups.google.com/d/optout.

Quoted 2 lines

I realigned the parameter list for function s_vCalculateOFDMRParameter. I don't know why it is showing in a mail like that after EXPORT FUNCTION Please correct me, if I'm understanding it in a wrong way

Indeed, there seems to be some code duplication. I would suggest to get rid of all of your commits and go back to Greg's version and start over.

julia