Skip to contentSkip to conversation

net: dsa: mv88e6xxx: power serdes on/off for 10G interfaces on 6390X

PATCH In review Maxime Chevallier 3 participants 3 messages Feb 28, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: mv88e6xxx: power serdes on/off for 10G interfaces on 6390X

Upon setting the cmode on 6390 and 6390X, the associated serdes interfaces must be powered off/on.

Both 6390X and 6390 share code to do so, but it currently uses the 6390 specific helper mv88e6390_serdes_power() to disable and enable the serdes interface.

This call will fail silently on 6390X when trying so set a 10G interface such as XAUI or RXAUI, since mv88e6390_serdes_power() internally grabs the lane number based on modes supported by the 6390, and returns 0 when getting -ENODEV as a lane number.

Using mv88e6390x_serdes_power() should be safe here, since we explicitly rule-out all ports but the 9 and 10, and because modes supported by 6390 ports 9 and 10 are a subset of those supported on 6390X.

This was tested on 6390X using RXAUI mode.

Fixes 364e9d7776a3 ("net: dsa: mv88e6xxx: Power on/off SERDES on cmode change")
---
 drivers/net/dsa/mv88e6xxx/port.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/dsa/mv88e6xxx/port.c +2 -2
index ebd26b6a93e6..4b02c96f6786 100644
@@ -408,7 +408,7 @@ int mv88e6390x_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
 			return err;
 	}
 
-	err = mv88e6390_serdes_power(chip, port, false);
+	err = mv88e6390x_serdes_power(chip, port, false);
 	if (err)
 		return err;
 
@@ -424,7 +424,7 @@ int mv88e6390x_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
 		if (err)
 			return err;
 
-		err = mv88e6390_serdes_power(chip, port, true);
+		err = mv88e6390x_serdes_power(chip, port, true);
 		if (err)
 			return err;
 
Signature · 1 line
2.19.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Maxime Chevallier

Upon setting the cmode on 6390 and 6390X, the associated serdes interfaces must be powered off/on.

Both 6390X and 6390 share code to do so, but it currently uses the 6390 specific helper mv88e6390_serdes_power() to disable and enable the serdes interface.

This call will fail silently on 6390X when trying so set a 10G interface such as XAUI or RXAUI, since mv88e6390_serdes_power() internally grabs the lane number based on modes supported by the 6390, and returns 0 when getting -ENODEV as a lane number.

Quoted 8 lines

Using mv88e6390x_serdes_power() should be safe here, since we explicitly rule-out all ports but the 9 and 10, and because modes supported by 6390 ports 9 and 10 are a subset of those supported on 6390X.

This was tested on 6390X using RXAUI mode.

Fixes 364e9d7776a3 ("net: dsa: mv88e6xxx: Power on/off SERDES on cmode change")

Andrew

maintainer
#2 lore raw
In reply to Maxime Chevallier

From: Maxime Chevallier <[email protected]>
Date: Thu, 28 Feb 2019 22:14:33 +0100

Quoted 12 lines

Upon setting the cmode on 6390 and 6390X, the associated serdes interfaces must be powered off/on.

Both 6390X and 6390 share code to do so, but it currently uses the 6390 specific helper mv88e6390_serdes_power() to disable and enable the serdes interface.

This call will fail silently on 6390X when trying so set a 10G interface such as XAUI or RXAUI, since mv88e6390_serdes_power() internally grabs the lane number based on modes supported by the 6390, and returns 0 when getting -ENODEV as a lane number.

Quoted 8 lines

Using mv88e6390x_serdes_power() should be safe here, since we explicitly rule-out all ports but the 9 and 10, and because modes supported by 6390 ports 9 and 10 are a subset of those supported on 6390X.

This was tested on 6390X using RXAUI mode.

Fixes 364e9d7776a3 ("net: dsa: mv88e6xxx: Power on/off SERDES on cmode change")

Applied and queued up for -stable.