Add SPDX license
Subsystems (2)
v3 cover Add SPDX license
This patch series adds SPDX license identifier to fix missing and malformed warning reported by checkpatch.pl tool
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
The patch then removes unnecessary license boilerplates. Now that we have the spdx specified, the license text is not necessary.
v3:
[PATCH 1/2]:Commit log corrected, commit message clearer
Jules Irenge (2):
staging: mt7621-eth: Add SPDX license identifier
staging: mt7621-eth: Remove license boilerplate text
drivers/staging/mt7621-eth/ethtool.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
Signature · 1 line
2.20.1
PATCH v3 1/2 staging: mt7621-eth: Add SPDX license identifier
Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning Issue reported by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
--- drivers/staging/mt7621-eth/ethtool.h | 1 + 1 file changed, 1 insertion(+)
drivers/staging/mt7621-eth/ethtool.h +1 -0
@@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License
Signature · 1 line
2.20.1
Greg KH
maintainerRe: [v3 1/2] staging: mt7621-eth: Add SPDX license identifier
Quoted 5 lines · Jules Irenge
Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning Issue reported by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"Signed-off-by Jules Irenge <[email protected]>
This is fine, but where did the PATCH go in the subject line?
thanks,
greg k-h
PATCH v3 2/2 staging: mt7621-eth: Remove license boilerplate text
In reply to Jules IrengeRemoves license boilerplate text
--- drivers/staging/mt7621-eth/ethtool.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/staging/mt7621-eth/ethtool.h +1 -9
@@ -1,13 +1,5 @@/* SPDX-License-Identifier: GPL-2.0 */ -/* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; version 2 of the License -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* +/* * Copyright (C) 2009-2016 John Crispin <[email protected]> * Copyright (C) 2009-2016 Felix Fietkau <[email protected]> * Copyright (C) 2013-2016 Michael Lee <[email protected]>
Signature · 1 line
2.20.1
Greg KH
maintainerQuoted 10 lines · Jules Irenge
This patch series adds SPDX license identifier to fix missing and malformed warning reported by checkpatch.pl tool
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
The patch then removes unnecessary license boilerplates. Now that we have the spdx specified, the license text is not necessary.
v3:
[PATCH 1/2]:Commit log corrected, commit message clearer
Next time, the subject for this email should match the patch emails. It should be something like:
Subject: [PATCH 0/2 v3] staging: mt7621-eth: SPDX license cleanups
thanks,
greg k-h