intel_th: gth: Fix an off-by-one in output unassigning
Subsystems (2)
Alexander Shishkin
maintainerPATCH 1/1 intel_th: gth: Fix an off-by-one in output unassigning
Commit 9ed3f22223c3 ("intel_th: Don't reference unassigned outputs") fixes a NULL dereference for all masters except the last one ("256+"), which keeps the stale pointer after the output driver had been unassigned.
Fix the off-by-one.
Signed-off-by Alexander Shishkin <[email protected]>
Fixes 9ed3f22223c3 ("intel_th: Don't reference unassigned outputs")
--- drivers/hwtracing/intel_th/gth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwtracing/intel_th/gth.c +1 -1
@@ -616,7 +616,7 @@ static void intel_th_gth_unassign(struct intel_th_device *thdev, othdev->output.port =-1 ; othdev->output.active = false; gth->output[port].output =NULL ; -for (master =0 ; master <TH_CONFIGURABLE_MASTERS ; master++) +for (master =0 ; master <=TH_CONFIGURABLE_MASTERS ; master++)if (gth->master[master] == port) gth->master[master] =-1 ;spin_unlock (>h->gth_lock);
Signature · 1 line
2.20.1