This patchset is to remove PPCisms for QEIC
Subsystems (6)
Zhao Qiang
maintainerv13 cover This patchset is to remove PPCisms for QEIC
QEIC is an interrupt controller for QE, was put under drivers/soc/fsl/qe, and now move to driver/irqchip.
And QEIC is supported more than just powerpc boards, so remove PPCisms.
changelog:
Changes for v8:
- use IRQCHIP_DECLARE() instead of subsys_initcall in qeic driver
- remove include/soc/fsl/qe/qe_ic.h
Changes for v9:
- rebase
- fix the compile issue when apply the second patch, in fact, there was no compile issue when apply all the patches of this patchset
Changes for v10:
- simplify codes, remove duplicated codes
Changes for v11:
- rebase
Changes for v13:
- rewrite single-bit constants to BIT(x) to make the code more readable
Zhao Qiang (4):
irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
Changes for v2:
- modify the subject and commit msg
Changes for v3:
- merge .h file to .c, rename it with irq-qeic.c
Changes for v4:
- modify comments
Changes for v5:
- disable rename detection
Changes for v6:
- rebase
Changes for v7:
- na
irqchip/qeic: merge qeic init code from platforms to a common function
Changes for v2:
- modify subject and commit msg
- add check for qeic by type
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v8:
- use IRQCHIP_DECLARE() instead of subsys_initcall
irqchip/qeic: merge qeic_of_init into qe_ic_init
Changes for v2:
- modify subject and commit msg
- return 0 and add put node when return in qe_ic_init
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v12:
- remove unused code
irqchip/qeic: remove PPCisms for QEIC
Changes for v6:
- new added
Changes for v7:
- fix warning
Changes for v8:
- remove include/soc/fsl/qe/qe_ic.h
Zhao Qiang (4):
irqchip/qeic: move qeic driver from drivers/soc/fsl/qe irqchip/qeic: merge qeic init code from platforms to a common function irqchip/qeic: merge qeic_of_init into qe_ic_init irqchip/qeic: remove PPCisms for QEIC
MAINTAINERS | 6 +
arch/powerpc/platforms/83xx/km83xx.c | 1 -
arch/powerpc/platforms/83xx/misc.c | 16 -
arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 -
arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 -
arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 -
arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 -
arch/powerpc/platforms/85xx/corenet_generic.c | 10 -
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 15 -
arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 17 -
arch/powerpc/platforms/85xx/twr_p102x.c | 15 -
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 423 +++++++++++----------
drivers/soc/fsl/qe/Makefile | 2 +-
drivers/soc/fsl/qe/qe_ic.h | 103 -----
include/soc/fsl/qe/qe_ic.h | 139 -------
16 files changed, 231 insertions(+), 521 deletions(-)
rename drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (53%)
delete mode 100644 drivers/soc/fsl/qe/qe_ic.h
delete mode 100644 include/soc/fsl/qe/qe_ic.hSignature · 1 line
2.14.1
Zhao Qiang
maintainerPATCH v13 1/4 irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
move the driver from drivers/soc/fsl/qe to drivers/irqchip, merge qe_ic.h and qe_ic.c into irq-qeic.c.
---
MAINTAINERS | 6 +
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 141 +++++++++++++++++----
drivers/soc/fsl/qe/Makefile | 2 +-
drivers/soc/fsl/qe/qe_ic.h | 103 ---------------
5 files changed, 123 insertions(+), 130 deletions(-)
rename drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (81%)
delete mode 100644 drivers/soc/fsl/qe/qe_ic.hMAINTAINERS +6 -0
@@ -5553,6 +5553,12 @@ F: drivers/soc/fsl/qe/ F: include/soc/fsl/*qe*.h F: include/soc/fsl/*ucc*.h +FREESCALE QEIC DRIVERS +M: Qiang Zhao <[email protected]> +L: [email protected] +S: Maintained +F: drivers/irqchip/irq-qeic.c + FREESCALE QUICC ENGINE UCC ETHERNET DRIVER M: Li Yang <[email protected]> L: [email protected]
drivers/irqchip/Makefile +1 -0
@@ -79,3 +79,4 @@ obj-$(CONFIG_ARCH_ASPEED) += irq-aspeed-vic.o irq-aspeed-i2c-ic.o obj-$(CONFIG_STM32_EXTI) += irq-stm32-exti.o obj-$(CONFIG_QCOM_IRQ_COMBINER) += qcom-irq-combiner.o obj-$(CONFIG_IRQ_UNIPHIER_AIDET) += irq-uniphier-aidet.o +obj-$(CONFIG_QUICC_ENGINE) += irq-qeic.o
drivers/irqchip/irq-qeic.c renamed from drivers/soc/fsl/qe/qe_ic.c +115 -26
267 lines not on this page · raw message
drivers/soc/fsl/qe/Makefile +1 -1
@@ -1,7 +1,7 @@ # # Makefile for the linux ppc-specific parts of QE # -obj-$(CONFIG_QUICC_ENGINE)+= qe.o qe_common.o qe_ic.o qe_io.o +obj-$(CONFIG_QUICC_ENGINE)+= qe.o qe_common.o qe_io.o obj-$(CONFIG_CPM) += qe_common.o obj-$(CONFIG_UCC) += ucc.o obj-$(CONFIG_UCC_SLOW) += ucc_slow.o
drivers/soc/fsl/qe/qe_ic.h deleted +0 -103
103 lines not on this page · raw message
Signature · 1 line
2.14.1
Zhao Qiang
maintainerPATCH v13 2/4 irqchip/qeic: merge qeic init code from platforms to a common function
In reply to Zhao QiangThe codes of qe_ic init from a variety of platforms are redundant, merge them to a common function and put it to irqchip/irq-qeic.c
For non-p1021_mds mpc85xx_mds boards, use "qe_ic_init(np, 0, qe_ic_cascade_low_mpic, qe_ic_cascade_high_mpic);" instead of "qe_ic_init(np, 0, qe_ic_cascade_muxed_mpic, NULL);".
qe_ic_cascade_muxed_mpic was used for boards has the same interrupt number for low interrupt and high interrupt, qe_ic_init has checked if "low interrupt == high interrupt"
--- arch/powerpc/platforms/83xx/misc.c | 15 --------------- arch/powerpc/platforms/85xx/corenet_generic.c | 9 --------- arch/powerpc/platforms/85xx/mpc85xx_mds.c | 14 -------------- arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 16 ---------------- arch/powerpc/platforms/85xx/twr_p102x.c | 14 -------------- drivers/irqchip/irq-qeic.c | 13 +++++++++++++ 6 files changed, 13 insertions(+), 68 deletions(-)
arch/powerpc/platforms/83xx/misc.c +0 -15
@@ -93,24 +93,9 @@ void __init mpc83xx_ipic_init_IRQ(void) }#ifdef CONFIG_QUICC_ENGINE -void __init mpc83xx_qe_init_IRQ (void ) -{ -struct device_node *np; - - np =of_find_compatible_node (NULL ,NULL ,"fsl,qe-ic" ); -if (!np) { - np =of_find_node_by_type (NULL ,"qeic" ); -if (!np) -return ; - } -qe_ic_init (np,0 , qe_ic_cascade_low_ipic, qe_ic_cascade_high_ipic); -of_node_put (np); -} -void __init mpc83xx_ipic_and_qe_init_IRQ (void ) {mpc83xx_ipic_init_IRQ (); -mpc83xx_qe_init_IRQ (); }#endif /* CONFIG_QUICC_ENGINE */
arch/powerpc/platforms/85xx/corenet_generic.c +0 -9
@@ -41,8 +41,6 @@ void __init corenet_gen_pic_init(void)unsigned int flags =MPIC_BIG_ENDIAN |MPIC_SINGLE_DEST_CPU |MPIC_NO_RESET ; -struct device_node *np; -if (ppc_md.get_irq == mpic_get_coreint_irq) flags |=MPIC_ENABLE_COREINT ;
@@ -50,13 +48,6 @@ void __init corenet_gen_pic_init(void)BUG_ON (mpic ==NULL );mpic_init (mpic); - - np =of_find_compatible_node (NULL ,NULL ,"fsl,qe-ic" ); -if (np) { -qe_ic_init (np,0 , qe_ic_cascade_low_mpic, - qe_ic_cascade_high_mpic); -of_node_put (np); - } }/*
arch/powerpc/platforms/85xx/mpc85xx_mds.c +0 -14
@@ -283,20 +283,6 @@ static void __init mpc85xx_mds_qeic_init(void)of_node_put (np); return; } - - np =of_find_compatible_node (NULL ,NULL ,"fsl,qe-ic" ); -if (!np) { - np =of_find_node_by_type (NULL ,"qeic" ); -if (!np) -return ; - } - -if (machine_is (p1021_mds)) -qe_ic_init (np,0 , qe_ic_cascade_low_mpic, - qe_ic_cascade_high_mpic); -else -qe_ic_init (np,0 , qe_ic_cascade_muxed_mpic,NULL ); -of_node_put (np); }#else static void __init mpc85xx_mds_qe_init (void ) { }
arch/powerpc/platforms/85xx/mpc85xx_rdb.c +0 -16
@@ -48,10 +48,6 @@ void __init mpc85xx_rdb_pic_init(void) {struct mpic *mpic; -#ifdef CONFIG_QUICC_ENGINE -struct device_node *np; -#endif -if (of_machine_is_compatible ("fsl,MPC85XXRDB-CAMP" )) { mpic = mpic_alloc(NULL, 0, MPIC_NO_RESET | MPIC_BIG_ENDIAN |
@@ -66,18 +62,6 @@ void __init mpc85xx_rdb_pic_init(void)BUG_ON (mpic ==NULL );mpic_init (mpic); - -#ifdef CONFIG_QUICC_ENGINE - np =of_find_compatible_node (NULL ,NULL ,"fsl,qe-ic" ); -if (np) { -qe_ic_init (np,0 , qe_ic_cascade_low_mpic, - qe_ic_cascade_high_mpic); -of_node_put (np); - - }else -pr_err ("%s: Could not find qe-ic node\n" , __func__); -#endif - }/*
arch/powerpc/platforms/85xx/twr_p102x.c +0 -14
@@ -35,26 +35,12 @@ static void __init twr_p1025_pic_init(void) {struct mpic *mpic; -#ifdef CONFIG_QUICC_ENGINE -struct device_node *np; -#endif - mpic =mpic_alloc (NULL ,0 ,MPIC_BIG_ENDIAN |MPIC_SINGLE_DEST_CPU ,0 ,256 ," OpenPIC " );BUG_ON (mpic ==NULL );mpic_init (mpic); - -#ifdef CONFIG_QUICC_ENGINE - np =of_find_compatible_node (NULL ,NULL ,"fsl,qe-ic" ); -if (np) { -qe_ic_init (np,0 , qe_ic_cascade_low_mpic, - qe_ic_cascade_high_mpic); -of_node_put (np); - }else -pr_err ("Could not find qe-ic node\n" ); -#endif }/* ************************************************************************
drivers/irqchip/irq-qeic.c +13 -0
@@ -18,6 +18,7 @@#include <linux/of_address.h> #include <linux/kernel.h> #include <linux/init.h> +#include <linux/irqchip.h> #include <linux/errno.h> #include <linux/reboot.h> #include <linux/slab.h>
@@ -598,4 +599,16 @@ static int __init init_qe_ic_sysfs(void)return 0 ; } +static int __init qeic_of_init (struct device_node *node, +struct device_node *parent) +{ +if (!node) +return -ENODEV ; +qe_ic_init (node,0 , qe_ic_cascade_low_mpic, + qe_ic_cascade_high_mpic); +of_node_put (node); +return 0 ; +} + +IRQCHIP_DECLARE (qeic,"fsl,qe-ic" , qeic_of_init);subsys_initcall (init_qe_ic_sysfs);
Signature · 1 line
2.14.1
Zhao Qiang
maintainerPATCH v13 3/4 irqchip/qeic: merge qeic_of_init into qe_ic_init
In reply to Zhao Qiangqeic_of_init just get device_node of qeic from dtb and call qe_ic_init, pass the device_node to qe_ic_init.
So merge qeic_of_init into qe_ic_init to get the qeic node in qe_ic_init.
--- drivers/irqchip/irq-qeic.c | 109 ++++++++++++--------------------------------- include/soc/fsl/qe/qe_ic.h | 7 --- 2 files changed, 29 insertions(+), 87 deletions(-)
drivers/irqchip/irq-qeic.c +29 -80
@@ -407,27 +407,29 @@ unsigned int qe_ic_get_high_irq(struct qe_ic *qe_ic)return irq_linear_revmap (qe_ic->irqhost, irq); } -void __init qe_ic_init (struct device_node *node,unsigned int flags, -void (*low_handler)(struct irq_desc *desc), -void (*high_handler)(struct irq_desc *desc)) +static int __init qe_ic_init (struct device_node *node,struct device_node *parent) {struct qe_ic *qe_ic;struct resource res; -u32 temp =0 , ret, high_active =0 ; +int ret =0 ; ret =of_address_to_resource (node,0 , &res); -if (ret) -return ; +if (ret) { + ret = -ENODEV ; + goto err_put_node; + } qe_ic =kzalloc (sizeof (*qe_ic),GFP_KERNEL ); -if (qe_ic ==NULL ) -return ; +if (qe_ic ==NULL ) { + ret = -ENOMEM ; + goto err_put_node; + } qe_ic->irqhost =irq_domain_add_linear (node,NR_QE_IC_INTS , &qe_ic_host_ops, qe_ic);if (qe_ic->irqhost ==NULL ) { -kfree (qe_ic); -return ; + ret = -ENOMEM ; + goto err_free_qe_ic; } qe_ic->regs =ioremap (res.start,resource_size (&res));
@@ -438,42 +440,30 @@ void __init qe_ic_init(struct device_node *node, unsigned int flags, qe_ic->virq_low =irq_of_parse_and_map (node,1 );if (qe_ic->virq_low ==NO_IRQ ) { -printk (KERN_ERR "Failed to map QE_IC low IRQ\n" ); -kfree (qe_ic); -return ; - } - -/* default priority scheme is grouped. If spread mode is */ -/* required, configure cicr accordingly. */ -if (flags &QE_IC_SPREADMODE_GRP_W ) - temp |=CICR_GWCC ; -if (flags &QE_IC_SPREADMODE_GRP_X ) - temp |=CICR_GXCC ; -if (flags &QE_IC_SPREADMODE_GRP_Y ) - temp |=CICR_GYCC ; -if (flags &QE_IC_SPREADMODE_GRP_Z ) - temp |=CICR_GZCC ; -if (flags &QE_IC_SPREADMODE_GRP_RISCA ) - temp |=CICR_GRTA ; -if (flags &QE_IC_SPREADMODE_GRP_RISCB ) - temp |=CICR_GRTB ; - -/* choose destination signal for highest priority interrupt */ -if (flags &QE_IC_HIGH_SIGNAL ) { - temp |= (SIGNAL_HIGH <<CICR_HPIT_SHIFT ); - high_active =1 ; +pr_err ("Failed to map QE_IC low IRQ\n" ); + ret = -ENOMEM ; + goto err_domain_remove; } -qe_ic_write (qe_ic->regs,QEIC_CICR , temp); -irq_set_handler_data (qe_ic->virq_low, qe_ic); -irq_set_chained_handler (qe_ic->virq_low, low_handler); +irq_set_chained_handler (qe_ic->virq_low, qe_ic_cascade_low_mpic);if (qe_ic->virq_high !=NO_IRQ && qe_ic->virq_high != qe_ic->virq_low) {irq_set_handler_data (qe_ic->virq_high, qe_ic); -irq_set_chained_handler (qe_ic->virq_high, high_handler); +irq_set_chained_handler (qe_ic->virq_high, + qe_ic_cascade_high_mpic); } +of_node_put (node); +return 0 ; + +err_domain_remove: +irq_domain_remove (qe_ic->irqhost); +err_free_qe_ic: +kfree (qe_ic); +err_put_node: +of_node_put (node); +return ret; }void qe_ic_set_highest_priority (unsigned int virq,int high)
@@ -570,45 +560,4 @@ int qe_ic_set_high_priority(unsigned int virq, unsigned int priority, int high)return 0 ; } -static struct bus_type qe_ic_subsys = { - .name ="qe_ic" , - .dev_name ="qe_ic" , -}; - -static struct device device_qe_ic = { - .id =0 , - .bus = &qe_ic_subsys, -}; - -static int __init init_qe_ic_sysfs (void ) -{ -int rc; - -printk (KERN_DEBUG "Registering qe_ic with sysfs...\n" ); - - rc =subsys_system_register (&qe_ic_subsys,NULL ); -if (rc) { -printk (KERN_ERR "Failed registering qe_ic sys class\n" ); -return -ENODEV ; - } - rc =device_register (&device_qe_ic); -if (rc) { -printk (KERN_ERR "Failed registering qe_ic sys device\n" ); -return -ENODEV ; - } -return 0 ; -} - -static int __init qeic_of_init (struct device_node *node, -struct device_node *parent) -{ -if (!node) -return -ENODEV ; -qe_ic_init (node,0 , qe_ic_cascade_low_mpic, - qe_ic_cascade_high_mpic); -of_node_put (node); -return 0 ; -} - -IRQCHIP_DECLARE (qeic,"fsl,qe-ic" , qeic_of_init); -subsys_initcall (init_qe_ic_sysfs); +IRQCHIP_DECLARE (qeic,"fsl,qe-ic" , qe_ic_init);
include/soc/fsl/qe/qe_ic.h +0 -7
@@ -58,16 +58,9 @@ enum qe_ic_grp_id { };#ifdef CONFIG_QUICC_ENGINE -void qe_ic_init (struct device_node *node,unsigned int flags, -void (*low_handler)(struct irq_desc *desc), -void (*high_handler)(struct irq_desc *desc));unsigned int qe_ic_get_low_irq (struct qe_ic *qe_ic);unsigned int qe_ic_get_high_irq (struct qe_ic *qe_ic);#else -static inline void qe_ic_init (struct device_node *node,unsigned int flags, -void (*low_handler)(struct irq_desc *desc), -void (*high_handler)(struct irq_desc *desc)) -{}static inline unsigned int qe_ic_get_low_irq (struct qe_ic *qe_ic) {return 0 ; }static inline unsigned int qe_ic_get_high_irq (struct qe_ic *qe_ic)
Signature · 1 line
2.14.1
Zhao Qiang
maintainerPATCH v13 4/4 irqchip/qeic: remove PPCisms for QEIC
In reply to Zhao QiangQEIC was supported on PowerPC, and dependent on PPC, Now it is supported on other platforms, so remove PPCisms.
--- arch/powerpc/platforms/83xx/km83xx.c | 1 - arch/powerpc/platforms/83xx/misc.c | 1 - arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 - arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 - arch/powerpc/platforms/85xx/corenet_generic.c | 1 - arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 - arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 1 - arch/powerpc/platforms/85xx/twr_p102x.c | 1 - drivers/irqchip/irq-qeic.c | 188 +++++++++++--------------- include/soc/fsl/qe/qe_ic.h | 132 ------------------ 12 files changed, 80 insertions(+), 250 deletions(-) delete mode 100644 include/soc/fsl/qe/qe_ic.h
arch/powerpc/platforms/83xx/km83xx.c +0 -1
@@ -38,7 +38,6 @@#include <sysdev/fsl_soc.h> #include <sysdev/fsl_pci.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include "mpc83xx.h"
arch/powerpc/platforms/83xx/misc.c +0 -1
@@ -17,7 +17,6 @@#include <asm/io.h> #include <asm/hw_irq.h> #include <asm/ipic.h> -#include <soc/fsl/qe/qe_ic.h> #include <sysdev/fsl_soc.h> #include <sysdev/fsl_pci.h>
arch/powerpc/platforms/83xx/mpc832x_mds.c +0 -1
@@ -37,7 +37,6 @@#include <sysdev/fsl_soc.h> #include <sysdev/fsl_pci.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include "mpc83xx.h"
arch/powerpc/platforms/83xx/mpc832x_rdb.c +0 -1
@@ -26,7 +26,6 @@#include <asm/ipic.h> #include <asm/udbg.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include <sysdev/fsl_soc.h> #include <sysdev/fsl_pci.h>
arch/powerpc/platforms/83xx/mpc836x_mds.c +0 -1
@@ -45,7 +45,6 @@#include <sysdev/fsl_pci.h> #include <sysdev/simple_gpio.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include "mpc83xx.h"
arch/powerpc/platforms/83xx/mpc836x_rdk.c +0 -1
@@ -21,7 +21,6 @@#include <asm/ipic.h> #include <asm/udbg.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include <sysdev/fsl_soc.h> #include <sysdev/fsl_pci.h>
arch/powerpc/platforms/85xx/corenet_generic.c +0 -1
@@ -27,7 +27,6 @@#include <asm/udbg.h> #include <asm/mpic.h> #include <asm/ehv_pic.h> -#include <soc/fsl/qe/qe_ic.h> #include <linux/of_platform.h> #include <sysdev/fsl_soc.h>
arch/powerpc/platforms/85xx/mpc85xx_mds.c +0 -1
@@ -49,7 +49,6 @@#include <sysdev/fsl_pci.h> #include <sysdev/simple_gpio.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include <asm/mpic.h> #include <asm/swiotlb.h> #include "smp.h"
arch/powerpc/platforms/85xx/mpc85xx_rdb.c +0 -1
@@ -27,7 +27,6 @@#include <asm/udbg.h> #include <asm/mpic.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include <sysdev/fsl_soc.h> #include <sysdev/fsl_pci.h>
arch/powerpc/platforms/85xx/twr_p102x.c +0 -1
@@ -23,7 +23,6 @@#include <asm/udbg.h> #include <asm/mpic.h> #include <soc/fsl/qe/qe.h> -#include <soc/fsl/qe/qe_ic.h> #include <sysdev/fsl_soc.h> #include <sysdev/fsl_pci.h>
drivers/irqchip/irq-qeic.c +80 -108
262 lines not on this page · raw message
include/soc/fsl/qe/qe_ic.h deleted +0 -132
132 lines not on this page · raw message
Signature · 1 line
2.14.1
Qiang Zhao
maintainerHi Thomas and Marc,
Is there any feedback? Thank you!
Best Regards
Qiang Zhao
Quoted 112 lines
-----Original Message-----
From: Zhao Qiang [mailto:[email protected]]
Sent: Friday, November 10, 2017 11:31 AM
To: [email protected]; [email protected]; [email protected]
Cc: [email protected]; Qiang Zhao <[email protected]>
Subject: [Patch v13 0/4] This patchset is to remove PPCisms for QEICQEIC is an interrupt controller for QE, was put under
drivers/soc/fsl/qe, and now move to driver/irqchip.
And QEIC is supported more than just powerpc boards, so remove PPCisms.changelog:
Changes for v8:
- useIRQCHIP_DECLARE()instead ofsubsys_initcallin qeic driver
- removeinclude/soc/fsl/qe/qe_ic.h
Changes for v9:
- rebase
- fix the compile issue when apply the second patch, in fact, there was
no compile issue
when apply all the patches of this patchset
Changes for v10:
- simplify codes, remove duplicated codes
Changes for v11:
- rebase
Changes for v13:
- rewrite single-bit constants to BIT(x) to make the code more readableZhao Qiang (4):
irqchip/qeic: move qeic driver fromdrivers/soc/fsl/qe
Changes for v2:
- modify the subject and commit msg
Changes for v3:
- merge .h file to .c, rename it withirq-qeic.c
Changes for v4:
- modify comments
Changes for v5:
- disable rename detection
Changes for v6:
- rebase
Changes for v7:
- nairqchip/qeic: merge qeic init code from platforms to a common function
Changes for v2:
- modify subject and commit msg
- add check for qeic by type
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v8:
- useIRQCHIP_DECLARE()instead ofsubsys_initcallirqchip/qeic: merge
qeic_of_initintoqe_ic_init
Changes for v2:
- modify subject and commit msg
- return 0 and add put node when return inqe_ic_init
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v12:
- remove unused codeirqchip/qeic: remove PPCisms for QEIC
Changes for v6:
- new added
Changes for v7:
- fix warning
Changes for v8:
- removeinclude/soc/fsl/qe/qe_ic.hZhao Qiang (4):
irqchip/qeic: move qeic driver fromdrivers/soc/fsl/qeirqchip/qeic: merge qeic init code from platforms to a common function irqchip/qeic: mergeqeic_of_initintoqe_ic_initirqchip/qeic: remove PPCisms for QEICMAINTAINERS | 6 + arch/powerpc/platforms/83xx/km83xx.c | 1 - arch/powerpc/platforms/83xx/misc.c | 16 - arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 - arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 - arch/powerpc/platforms/85xx/corenet_generic.c | 10 - arch/powerpc/platforms/85xx/mpc85xx_mds.c | 15 - arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 17 - arch/powerpc/platforms/85xx/twr_p102x.c | 15 - drivers/irqchip/Makefile | 1 + drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 423 +++++++++++---------- drivers/soc/fsl/qe/Makefile | 2 +- drivers/soc/fsl/qe/qe_ic.h | 103 ----- include/soc/fsl/qe/qe_ic.h | 139 ------- 16 files changed, 231 insertions(+), 521 deletions(-) rename
drivers/{soc/fsl/qe/qe_ic.c=>irqchip/irq-qeic.c} (53%) delete mode 100644drivers/soc/fsl/qe/qe_ic.hdelete mode 100644include/soc/fsl/qe/qe_ic.h--
2.14.1
Qiang Zhao
maintainerAnybody help to review on this patchset?
Best Regards
Qiang Zhao
Quoted 129 lines
-----Original Message-----
From: Qiang Zhao
Sent: 2017年11月30日 9:11
To: Qiang Zhao <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: RE: [Patch v13 0/4] This patchset is to remove PPCisms for QEICHi Thomas and Marc,
Is there any feedback? Thank you!
Best Regards
Qiang ZhaoQuoted 114 lines
-----Original Message-----
From: Zhao Qiang [mailto:[email protected]]
Sent: Friday, November 10, 2017 11:31 AM
To: [email protected]; [email protected]; [email protected]
Cc: [email protected]; Qiang Zhao <[email protected]>
Subject: [Patch v13 0/4] This patchset is to remove PPCisms for QEICQEIC is an interrupt controller for QE, was put under
drivers/soc/fsl/qe, and now move to driver/irqchip.
And QEIC is supported more than just powerpc boards, so remove PPCisms.changelog:
Changes for v8:
- useIRQCHIP_DECLARE()instead ofsubsys_initcallin qeic driver
- removeinclude/soc/fsl/qe/qe_ic.h
Changes for v9:
- rebase
- fix the compile issue when apply the second patch, in fact, there
was no compile issue
when apply all the patches of this patchset
Changes for v10:
- simplify codes, remove duplicated codes
Changes for v11:
- rebase
Changes for v13:
- rewrite single-bit constants to BIT(x) to make the code more
readableZhao Qiang (4):
irqchip/qeic: move qeic driver fromdrivers/soc/fsl/qe
Changes for v2:
- modify the subject and commit msg
Changes for v3:
- merge .h file to .c, rename it withirq-qeic.c
Changes for v4:
- modify comments
Changes for v5:
- disable rename detection
Changes for v6:
- rebase
Changes for v7:
- nairqchip/qeic: merge qeic init code from platforms to a common function
Changes for v2:
- modify subject and commit msg
- add check for qeic by type
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v8:
- useIRQCHIP_DECLARE()instead ofsubsys_initcallirqchip/qeic: merge
qeic_of_initintoqe_ic_init
Changes for v2:
- modify subject and commit msg
- return 0 and add put node when return inqe_ic_init
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v12:
- remove unused codeirqchip/qeic: remove PPCisms for QEIC
Changes for v6:
- new added
Changes for v7:
- fix warning
Changes for v8:
- removeinclude/soc/fsl/qe/qe_ic.hZhao Qiang (4):
irqchip/qeic: move qeic driver fromdrivers/soc/fsl/qeirqchip/qeic: merge qeic init code from platforms to a common function irqchip/qeic: mergeqeic_of_initintoqe_ic_initirqchip/qeic: remove PPCisms for QEICMAINTAINERS | 6 + arch/powerpc/platforms/83xx/km83xx.c | 1 - arch/powerpc/platforms/83xx/misc.c | 16 - arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 - arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 - arch/powerpc/platforms/85xx/corenet_generic.c | 10 - arch/powerpc/platforms/85xx/mpc85xx_mds.c | 15 - arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 17 - arch/powerpc/platforms/85xx/twr_p102x.c | 15 - drivers/irqchip/Makefile | 1 + drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 423 +++++++++++---------- drivers/soc/fsl/qe/Makefile | 2 +- drivers/soc/fsl/qe/qe_ic.h | 103 ----- include/soc/fsl/qe/qe_ic.h | 139 ------- 16 files changed, 231 insertions(+), 521 deletions(-) rename
drivers/{soc/fsl/qe/qe_ic.c=>irqchip/irq-qeic.c} (53%) delete mode 100644drivers/soc/fsl/qe/qe_ic.hdelete mode 100644include/soc/fsl/qe/qe_ic.h--
2.14.1
Quoted 1 line · On Fri, 1 Mar 2019 02:13:44 +0000 Qiang Zhao <[email protected]> wrote:
Anybody help to review on this patchset?
I'm afraid reviving reviving a series from 2017 by sending a ping like this isn't going to have much effect. If you want people to review it, please send an updated series on top of current mainline, and you'll be in the review queue for 5.2.
Thanks.
M.
Quoted 134 lines
Best Regards
Qiang ZhaoQuoted 129 lines
-----Original Message-----
From: Qiang Zhao
Sent: 2017年11月30日 9:11
To: Qiang Zhao <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: RE: [Patch v13 0/4] This patchset is to remove PPCisms for QEICHi Thomas and Marc,
Is there any feedback? Thank you!
Best Regards
Qiang ZhaoQuoted 114 lines
-----Original Message-----
From: Zhao Qiang [mailto:[email protected]]
Sent: Friday, November 10, 2017 11:31 AM
To: [email protected]; [email protected]; [email protected]
Cc: [email protected]; Qiang Zhao <[email protected]>
Subject: [Patch v13 0/4] This patchset is to remove PPCisms for QEICQEIC is an interrupt controller for QE, was put under
drivers/soc/fsl/qe, and now move to driver/irqchip.
And QEIC is supported more than just powerpc boards, so remove PPCisms.changelog:
Changes for v8:
- useIRQCHIP_DECLARE()instead ofsubsys_initcallin qeic driver
- removeinclude/soc/fsl/qe/qe_ic.h
Changes for v9:
- rebase
- fix the compile issue when apply the second patch, in fact, there
was no compile issue
when apply all the patches of this patchset
Changes for v10:
- simplify codes, remove duplicated codes
Changes for v11:
- rebase
Changes for v13:
- rewrite single-bit constants to BIT(x) to make the code more
readableZhao Qiang (4):
irqchip/qeic: move qeic driver fromdrivers/soc/fsl/qe
Changes for v2:
- modify the subject and commit msg
Changes for v3:
- merge .h file to .c, rename it withirq-qeic.c
Changes for v4:
- modify comments
Changes for v5:
- disable rename detection
Changes for v6:
- rebase
Changes for v7:
- nairqchip/qeic: merge qeic init code from platforms to a common function
Changes for v2:
- modify subject and commit msg
- add check for qeic by type
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v8:
- useIRQCHIP_DECLARE()instead ofsubsys_initcallirqchip/qeic: merge
qeic_of_initintoqe_ic_init
Changes for v2:
- modify subject and commit msg
- return 0 and add put node when return inqe_ic_init
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v12:
- remove unused codeirqchip/qeic: remove PPCisms for QEIC
Changes for v6:
- new added
Changes for v7:
- fix warning
Changes for v8:
- removeinclude/soc/fsl/qe/qe_ic.hZhao Qiang (4):
irqchip/qeic: move qeic driver fromdrivers/soc/fsl/qeirqchip/qeic: merge qeic init code from platforms to a common function irqchip/qeic: mergeqeic_of_initintoqe_ic_initirqchip/qeic: remove PPCisms for QEICMAINTAINERS | 6 + arch/powerpc/platforms/83xx/km83xx.c | 1 - arch/powerpc/platforms/83xx/misc.c | 16 - arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 - arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 - arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 - arch/powerpc/platforms/85xx/corenet_generic.c | 10 - arch/powerpc/platforms/85xx/mpc85xx_mds.c | 15 - arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 17 - arch/powerpc/platforms/85xx/twr_p102x.c | 15 - drivers/irqchip/Makefile | 1 + drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 423 +++++++++++---------- drivers/soc/fsl/qe/Makefile | 2 +- drivers/soc/fsl/qe/qe_ic.h | 103 ----- include/soc/fsl/qe/qe_ic.h | 139 ------- 16 files changed, 231 insertions(+), 521 deletions(-) rename
drivers/{soc/fsl/qe/qe_ic.c=>irqchip/irq-qeic.c} (53%) delete mode 100644drivers/soc/fsl/qe/qe_ic.hdelete mode 100644include/soc/fsl/qe/qe_ic.h--
2.14.1
Signature · 1 line
Without deviation from the norm, progress is not possible.
Qiang Zhao
maintainerHi all,
Is there any comments on this patchset?
Best Regards
Qiang Zhao
-----Original Message-----
From: Zhao Qiang [mailto:[email protected]]
Sent: 2017年11月10日 11:31
To: [email protected]; [email protected]; [email protected]
Cc: [email protected]; Qiang Zhao <[email protected]>
Subject: [Patch v13 0/4] This patchset is to remove PPCisms for QEIC
QEIC is an interrupt controller for QE, was put under drivers/soc/fsl/qe, and now move to driver/irqchip. And QEIC is supported more than just powerpc boards, so remove PPCisms.
changelog:
Changes for v8:
- use IRQCHIP_DECLARE() instead of subsys_initcall in qeic driver
- remove include/soc/fsl/qe/qe_ic.h
Changes for v9:
- rebase
- fix the compile issue when apply the second patch, in fact, there was no compile issue when apply all the patches of this patchset
Changes for v10:
- simplify codes, remove duplicated codes
Changes for v11:
- rebase
Changes for v13:
- rewrite single-bit constants to BIT(x) to make the code more readable
Zhao Qiang (4):
irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
Changes for v2:
- modify the subject and commit msg
Changes for v3:
- merge .h file to .c, rename it with irq-qeic.c
Changes for v4:
- modify comments
Changes for v5:
- disable rename detection
Changes for v6:
- rebase
Changes for v7:
- na
irqchip/qeic: merge qeic init code from platforms to a common function
Changes for v2:
- modify subject and commit msg
- add check for qeic by type
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v8:
- use IRQCHIP_DECLARE() instead of subsys_initcall
irqchip/qeic: merge qeic_of_init into qe_ic_init
Changes for v2:
- modify subject and commit msg
- return 0 and add put node when return in qe_ic_init
Changes for v3:
- na
Changes for v4:
- na
Changes for v5:
- na
Changes for v6:
- rebase
Changes for v7:
- na
Changes for v12:
- remove unused code
irqchip/qeic: remove PPCisms for QEIC
Changes for v6:
- new added
Changes for v7:
- fix warning
Changes for v8:
- remove include/soc/fsl/qe/qe_ic.h
Zhao Qiang (4):
irqchip/qeic: move qeic driver from drivers/soc/fsl/qe irqchip/qeic: merge qeic init code from platforms to a common function irqchip/qeic: merge qeic_of_init into qe_ic_init irqchip/qeic: remove PPCisms for QEIC
MAINTAINERS | 6 +
arch/powerpc/platforms/83xx/km83xx.c | 1 -
arch/powerpc/platforms/83xx/misc.c | 16 -
arch/powerpc/platforms/83xx/mpc832x_mds.c | 1 -
arch/powerpc/platforms/83xx/mpc832x_rdb.c | 1 -
arch/powerpc/platforms/83xx/mpc836x_mds.c | 1 -
arch/powerpc/platforms/83xx/mpc836x_rdk.c | 1 -
arch/powerpc/platforms/85xx/corenet_generic.c | 10 -
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 15 -
arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 17 -
arch/powerpc/platforms/85xx/twr_p102x.c | 15 -
drivers/irqchip/Makefile | 1 +
drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 423 +++++++++++----------
drivers/soc/fsl/qe/Makefile | 2 +-
drivers/soc/fsl/qe/qe_ic.h | 103 -----
include/soc/fsl/qe/qe_ic.h | 139 -------
16 files changed, 231 insertions(+), 521 deletions(-) rename drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (53%) delete mode 100644 drivers/soc/fsl/qe/qe_ic.h delete mode 100644 include/soc/fsl/qe/qe_ic.h--
2.14.1