Skip to contentSkip to conversation

PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static

PATCH Applied Wei Yongjun 3 participants 3 messages Mar 1, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: aardvark: Make symbol 'advk_pci_bridge_emul_ops' static

Fixes the following sparse warning:

drivers/pci/controller/pci-aardvark.c:469:28: warning:
symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static?

Fixes 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space")
---
 drivers/pci/controller/pci-aardvark.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-aardvark.c +1 -1
index 6eecae447af3..eb58dfdaba1b 100644
@@ -466,7 +466,7 @@ advk_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
 	}
 }
 
-struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
+static struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
 	.read_pcie = advk_pci_bridge_emul_pcie_conf_read,
 	.write_pcie = advk_pci_bridge_emul_pcie_conf_write,
 };
maintainer Acked-by on v1 1/1
#1 lore raw

Hello Wei,

Quoted 7 lines · On Fri, 1 Mar 2019 06:58:09 +0000 Wei Yongjun <[email protected]> wrote:

Fixes the following sparse warning:

drivers/pci/controller/pci-aardvark.c:469:28: warning:
symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static?

Fixes 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space")

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw
In reply to Wei Yongjun
Quoted 10 lines · Wei Yongjun

Fixes the following sparse warning:

drivers/pci/controller/pci-aardvark.c:469:28: warning:
symbol 'advk_pci_bridge_emul_ops' was not declared. Should it be static?

Fixes 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space")
---
 drivers/pci/controller/pci-aardvark.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/misc for v5.1, thanks.

Lorenzo

Quoted 16 lines
drivers/pci/controller/pci-aardvark.c +1 -1
index 6eecae447af3..eb58dfdaba1b 100644
@@ -466,7 +466,7 @@ advk_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
 	}
 }
 
-struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
+static struct pci_bridge_emul_ops advk_pci_bridge_emul_ops = {
 	.read_pcie = advk_pci_bridge_emul_pcie_conf_read,
 	.write_pcie = advk_pci_bridge_emul_pcie_conf_write,
 };