Staging: fpgaboot: Delete newline at the end of Kconfig
PATCH v2 1/1 Staging: fpgaboot: Delete newline at the end of Kconfig
Delete the newline at the end of a Kconfig file, to silence the checkpatch warning:
WARNING: please write a paragraph that describes the config symbol fully.
--- drivers/staging/gs_fpgaboot/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gs_fpgaboot/Kconfig +1 -1
@@ -5,4 +5,4 @@ config GS_FPGABOOT tristate "Xilinx FPGA firmware download module" default n help - Xilinx FPGA firmware download module + Xilinx FPGA firmware download module
Signature · 1 line
2.17.1
Greg Kroah-Hartman
maintainerQuoted 4 lines · Wentao Cai
Delete the newline at the end of a
Kconfigfile, to silence the checkpatch warning:
WARNING: please write a paragraph that describes the config symbol fully.
That is not the way to fix this warning :)
You need to actually write a paragraph, not delete an empty line.
thanks,
greg k-h
Quoted 7 lines · gregkh
Quoted 7 lines · Wentao Cai
Quoted 4 lines
Delete the newline at the end of a
Kconfigfile, to silence the checkpatch warning:
WARNING: please write a paragraph that describes the config symbol fully.
Quoted 5 lines
Quoted 4 lines
That is not the way to fix this warning :)
You need to actually write a paragraph, not delete an empty line.
Hi, greg, I wonder if it is ok to solve this problem by adding this?
Say Y if you want to include this driver in the kernel.
To compile this driver as a module, choose M here. The module will be called gs_fpgaboot.ko.
Also I have a stupid question. I've just reinstall my system, so I can't revise my previous patches through git log.
If I want to revise those patches, should I still send them with a [PATCH vn] version or just with [PATCH]?
Thanks,
Wentao
Quoted 4 lines
thanks,
Quoted 2 lines
greg k-h
Quoted 14 lines · Wentao Cai
On Friday, March 1, 2019 at 1:08:53 AM UTC-8, gregkh wrote:
> On Fri, Mar 01, 2019 at 05:02:25PM +0800, Wentao Cai wrote:
> > Delete the newline at the end of aKconfigfile, to silence the > > checkpatch warning:
> > WARNING: please write a paragraph that describes the config symbol > > fully.
>
> That is not the way to fix this warning :)
>
> You need to actually write a paragraph, not delete an empty line. >
Quoted 7 lines
Hi, greg, I wonder if it is ok to solve this problem by adding this?
Say Y if you want to include this driver in the kernel.
To compile this driver as a module, choose M here. The module will be called gs_fpgaboot.ko.Also I have a stupid question. I've just reinstall my system, so I can't revise my previous patches through git log. If I want to revise those patches, should I still send them with a [PATCH vn] version or just with [PATCH]?
The version number is from the recipient's point of view. So it doesn't matter if you are revising your previos patch or creating it again from scratch.
julia
Quoted 17 lines
Thanks,
Wentao
> thanks, > > greg k-h--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/6289455c-2178-4baf-b1ae-899b7c19fa2a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 13 lines · Julia Lawall
Quoted 2 lines
Also I have a stupid question. I've just reinstall my system, so I can't
revise my previous patches through git log.
Quoted 1 line
If I want to revise those patches, should I still send them with a
[PATCH vn] version or just with [PATCH]?
Quoted 5 lines
The version number is from the recipient's point of view. So it doesn't matter if you are revising your previos patch or creating it again from scratch.
julia
Thanks, Julia!
Quoted 22 lines
Quoted 11 lines
Thanks,
Wentao
> thanks,
>
> greg k-hSignature · 1 line
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
Quoted 3 lines
For more options, visit https://groups.google.com/d/optout.
Quoted 12 lines · Wentao Cai
Quoted 9 lines · gregkh
Quoted 9 lines · Wentao Cai
Quoted 4 lines
Delete the newline at the end of a
Kconfigfile, to silence the checkpatch warning:
WARNING: please write a paragraph that describes the config symbol fully.That is not the way to fix this warning :)
Quoted 8 lines
Quoted 3 lines
Quoted 2 lines
You need to actually write a paragraph, not delete an empty line.
Hi, greg, I wonder if it is ok to solve this problem by adding this?
Say Y if you want to include this driver in the kernel.
To compile this driver as a module, choose M here. The module will be called gs_fpgaboot.ko.
You need to say what the driver does, otherwise the user has no idea if they need it or not.
thanks,
greg k-h