Skip to contentSkip to conversation

usb: core: make default autosuspend delay configurable

PATCH Superseded Mans Rullgard 2 participants 4 messages Mar 1, 2019 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: core: make default autosuspend delay configurable

Make the default autosuspend delay configurable at build time. This is useful for systems that require a non-standard value as it avoids relying on the command line being properly set.

---
 drivers/usb/core/Kconfig | 8 ++++++++
 drivers/usb/core/usb.c   | 4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)
drivers/usb/core/Kconfig +8 -0
index 4d75d9a80001..38ed837538c4 100644
@@ -90,3 +90,11 @@ config USB_LEDS_TRIGGER_USBPORT
 	  This driver allows LEDs to be controlled by USB events. Enabling this
 	  trigger allows specifying list of USB ports that should turn on LED
 	  when some USB device gets connected.
+
+config USB_AUTOSUSPEND_DELAY
+	int "Default autosuspend delay"
+	depends on USB
+	default 2
+	help
+	  The default autosuspend delay in seconds.  Can be overridden
+	  with the usbcore.autosuspend command line or module parameter.
drivers/usb/core/usb.c +2 -2
index 4ebfbd737905..52e749386c1c 100644
@@ -65,8 +65,8 @@ int usb_disabled(void)
 EXPORT_SYMBOL_GPL(usb_disabled);
 
 #ifdef	CONFIG_PM
-static int usb_autosuspend_delay = 2;		/* Default delay value,
-						 * in seconds */
+/* Default delay value, in seconds */
+static int usb_autosuspend_delay = CONFIG_USB_AUTOSUSPEND_DELAY;
 module_param_named(autosuspend, usb_autosuspend_delay, int, 0644);
 MODULE_PARM_DESC(autosuspend, "default autosuspend delay");
 
#1 lore raw
Quoted 16 lines · Mans Rullgard

Make the default autosuspend delay configurable at build time. This is useful for systems that require a non-standard value as it avoids relying on the command line being properly set.

---
 drivers/usb/core/Kconfig | 8 ++++++++
 drivers/usb/core/usb.c   | 4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)
drivers/usb/core/Kconfig +0 -0
index 4d75d9a80001..38ed837538c4 100644
@@ -90,3 +90,11 @@ config USB_LEDS_TRIGGER_USBPORT
 	  This driver allows LEDs to be controlled by USB events. Enabling this

drivers/usb/core/Kconfig config USB_LEDS_TRIGGER_USBPORT · line 100

Quoted 10 lines
drivers/usb/core/Kconfig +8 -0
 	  trigger allows specifying list of USB ports that should turn on LED
 	  when some USB device gets connected.
+
+config USB_AUTOSUSPEND_DELAY
+	int "Default autosuspend delay"
+	depends on USB
+	default 2
+	help
+	  The default autosuspend delay in seconds.  Can be overridden
+	  with the usbcore.autosuspend command line or module parameter.

As everyone is suddenly going to be hit with this for a new kernel upate, you might want to put something in here that says:
The default value Linux has always had is 2 seconds. Change this value if you want a different delay timeframe and can not modify the command line or module parameter option.

to make people a lot more comfortable with this change.

thanks,

greg k-h

#2 lore raw

PATCH v2 1/1 usb: core: make default autosuspend delay configurable

Make the default autosuspend delay configurable at build time. This is useful for systems that require a non-standard value as it avoids relying on the command line being properly set.

---
Changes in v2:
- add explanatory text to Kconfig help

---
 drivers/usb/core/Kconfig | 12 ++++++++++++
 drivers/usb/core/usb.c   |  4 ++--
 2 files changed, 14 insertions(+), 2 deletions(-)
drivers/usb/core/Kconfig +12 -0
index 4d75d9a80001..cd91006e3f84 100644
@@ -90,3 +90,15 @@ config USB_LEDS_TRIGGER_USBPORT
 	  This driver allows LEDs to be controlled by USB events. Enabling this
 	  trigger allows specifying list of USB ports that should turn on LED
 	  when some USB device gets connected.
+
+config USB_AUTOSUSPEND_DELAY
+	int "Default autosuspend delay"
+	depends on USB
+	default 2
+	help
+	  The default autosuspend delay in seconds.  Can be overridden
+	  with the usbcore.autosuspend command line or module parameter.
+
+	  The default value Linux has always had is 2 seconds.  Change
+	  this value if you want a different delay and cannot modify
+	  the command line or module parameter.
drivers/usb/core/usb.c +2 -2
index 4ebfbd737905..52e749386c1c 100644
@@ -65,8 +65,8 @@ int usb_disabled(void)
 EXPORT_SYMBOL_GPL(usb_disabled);
 
 #ifdef	CONFIG_PM
-static int usb_autosuspend_delay = 2;		/* Default delay value,
-						 * in seconds */
+/* Default delay value, in seconds */
+static int usb_autosuspend_delay = CONFIG_USB_AUTOSUSPEND_DELAY;
 module_param_named(autosuspend, usb_autosuspend_delay, int, 0644);
 MODULE_PARM_DESC(autosuspend, "default autosuspend delay");
 
#3 lore raw
Quoted 8 lines · Mans Rullgard

Make the default autosuspend delay configurable at build time. This is useful for systems that require a non-standard value as it avoids relying on the command line being properly set.

---
Changes in v2:
- add explanatory text to Kconfig help

Much nicer, thanks!

greg k-h