ASoC: ab8500: Mark expected switch fall-through
PATCH 1/1 ASoC: ab8500: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
In file included from sound/soc/codecs/ab8500-codec.c:24:sound/soc/codecs/ab8500-codec.c: In function ‘ab8500_codec_set_dai_fmt’:./include/linux/device.h:1485:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~sound/soc/codecs/ab8500-codec.c:2129:3: note: in expansion of macro ‘dev_err’
dev_err(dai->component->dev,
^~~~~~~sound/soc/codecs/ab8500-codec.c:2132:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- sound/soc/codecs/ab8500-codec.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/codecs/ab8500-codec.c +1 -0
@@ -2129,6 +2129,7 @@ static int ab8500_codec_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)dev_err (dai->component->dev,"%s: ERROR: The device is either a master or a slave.\n" , __func__); +/* fall through */ default : dev_err(dai->component->dev, "%s: ERROR: Unsupporter master mask 0x%x\n",
Signature · 1 line
2.21.0
Mark Brown
maintainerApplied "ASoC: ab8500: Mark expected switch fall-through" to the asoc tree
The patch
ASoC: ab8500: Mark expected switch fall-through
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
102cefc8e879b707be0024fdc7bce1deeb359a5fMon Sep 17 00:00:00 2001
From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 1 Mar 2019 14:43:10 -0600
Subject: [PATCH] ASoC: ab8500: Mark expected switch fall-through
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
In file included from sound/soc/codecs/ab8500-codec.c:24:sound/soc/codecs/ab8500-codec.c: In function ‘ab8500_codec_set_dai_fmt’:./include/linux/device.h:1485:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~sound/soc/codecs/ab8500-codec.c:2129:3: note: in expansion of macro ‘dev_err’
dev_err(dai->component->dev,
^~~~~~~sound/soc/codecs/ab8500-codec.c:2132:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- sound/soc/codecs/ab8500-codec.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/codecs/ab8500-codec.c +1 -0
@@ -2129,6 +2129,7 @@ static int ab8500_codec_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)dev_err (dai->component->dev,"%s: ERROR: The device is either a master or a slave.\n" , __func__); +/* fall through */ default : dev_err(dai->component->dev, "%s: ERROR: Unsupporter master mask 0x%x\n",
Signature · 1 line
2.20.1