Skip to contentSkip to conversation

staging: mt7621-dma: SPDX license cleanups

PATCH Superseded Jules Irenge 3 participants 9 messages Mar 2, 2019 1 message not in the archive

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover staging: mt7621-dma: SPDX license cleanups

This patch series adds SPDX license identifier to fix missing and malformed warning generated by checkpatch.pl tool
then removes unnecessary license boilerplates.
Now that we have the spdx specified,
the license text is not necessary.

Jules Irenge (2):
staging: mt7621-dma: add SPDX GPL-2.0+ license identifier
staging: mt7621-dma: Remove license boilerplate text

 drivers/staging/mt7621-dma/mtk-hsdma.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/2 staging: mt7621-dma: add SPDX GPL-2.0+ license identifier

Add SPDX GPL-2.0+ to fix missing SPDX warning
reported by checkpatch.pl.

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
index d67a2504adb1..7d69586f23c0 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  *  Copyright (C) 2015, Michael Lee <[email protected]>
  *  MTK HSDMA support
Signature · 1 line
2.20.1
maintainer
#2 lore raw

Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0+ license identifier

Quoted 13 lines · Jules Irenge

Add SPDX GPL-2.0+ to fix missing SPDX warning
reported by checkpatch.pl.

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -0
index d67a2504adb1..7d69586f23c0 100644

drivers/staging/mt7621-dma/mtk-hsdma.c line 1

Quoted 1 line
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later

Are you sure you changed the identifer to match what said above in your changelog? :(

#3 lore raw

Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0+ license identifier

Quoted 17 lines · Greg KH

Review

Quoted 9 lines · Jules Irenge

Add SPDX GPL-2.0+ to fix missing SPDX warning
reported by checkpatch.pl.

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/staging/mt7621-dma/mtk-hsdma.c

Quoted 5 lines

index d67a2504adb1..7d69586f23c0 100644

drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
Quoted 4 lines
Quoted 2 lines

Are you sure you changed the identifer to match what said above in your changelog? :(

Apology,

I had two kernels git ; a back up and one that I work in . I mixed them. It will not happen again.
Kind regards

#4 lore raw

PATCH 2/2 staging: mt7621-dma: Remove license boilerplate text

In reply to Jules Irenge

Removes license boilerplate text

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -6
index 7d69586f23c0..e4a522f3b448 100644
@@ -2,12 +2,6 @@
 /*
  *  Copyright (C) 2015, Michael Lee <[email protected]>
  *  MTK HSDMA support
- *
- *  This program is free software; you can redistribute it and/or modify it
- *  under  the terms of the GNU General	 Public License as published by the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
- *
  */
 
 #include <linux/dmaengine.h>
Signature · 1 line
2.20.1
#5 lore raw

Re: [Outreachy kernel] [PATCH 2/2] staging: mt7621-dma: Remove license boilerplate text

Quoted 1 line · Jules Irenge

Removes license boilerplate text

The log message should be in the imperative. No "s" at the end of the verb.

Please put a period at the end of the sentence.

The log message should explain why you are removing it, ie it is redundant now that there is the SPDX identifier.

julia

Quoted 33 lines
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -7
index 7d69586f23c0..e4a522f3b448 100644
@@ -2,12 +2,6 @@
 /*
  *  Copyright (C) 2015, Michael Lee <[email protected]>
  *  MTK HSDMA support
- *
- *  This program is free software; you can redistribute it and/or modify it
- *  under  the terms of the GNU General	 Public License as published by the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
- *
  */
 
 #include <linux/dmaengine.h>
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-3-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#6 lore raw

Re: [Outreachy kernel] [PATCH 2/2] staging: mt7621-dma: Remove license boilerplate text

Quoted 48 lines · Julia Lawall
Quoted 1 line · Jules Irenge

Removes license boilerplate text

The log message should be in the imperative. No "s" at the end of the verb.

Please put a period at the end of the sentence.

The log message should explain why you are removing it, ie it is redundant now that there is the SPDX identifier.

julia

Review

Quoted 7 lines
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------
 1 file changed, 6 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/mt7621-dma/mtk-hsdma.c

drivers/staging/mt7621-dma/mtk-hsdma.c line 6

Quoted 9 lines

index 7d69586f23c0..e4a522f3b448 100644

drivers/staging/mt7621-dma/mtk-hsdma.c +0 -2
@@ -2,12 +2,6 @@
 /*
  *  Copyright (C) 2015, Michael Lee <[email protected]>
  *  MTK HSDMA support
- *
- *  This program is free software; you can redistribute it and/or

modify it

drivers/staging/mt7621-dma/mtk-hsdma.c line 7

Quoted 1 line
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -1
- *  under  the terms of the GNU General       Public License as

published by the

drivers/staging/mt7621-dma/mtk-hsdma.c line 8

Quoted 1 line
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -1
- *  Free Software Foundation;  either version 2 of the License, or (at

your

Quoted 10 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -3
- *  option) any later version.
- *
  */
 
 #include <linux/dmaengine.h>
--

2.20.1

--
You received this message because you are subscribed to the Google

Quoted 10 lines

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected].

Quoted 2 lines

To post to this group, send email to [email protected]. To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-3-jbi.octave%40gmail.com
.

Quoted 2 lines

For more options, visit https://groups.google.com/d/optout.

I will do so. Thanks.

A message that is not in the archive (sent off-list or not yet received): alpine.DEB.2.21.1903020906590.2572@hadrien

#8 lore raw

Re: [Outreachy kernel] [PATCH 2/2] staging: mt7621-dma: Remove license boilerplate text

Quoted 62 lines · Julia Lawall
Quoted 50 lines · Jules Octave

On Sat, 2 Mar 2019 at 06:32, Julia Lawall <[email protected]> wrote:

On Sat, 2 Mar 2019, Jules Irenge wrote:

> Removes license boilerplate text

The log message should be in the imperative. No "s" at the end of the
verb.

Please put a period at the end of the sentence.

The log message should explain why you are removing it, ie it is redundant
now that there is the SPDX identifier.

julia

>
> Signed-off-by: Jules Irenge <[email protected]> > ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ------ > 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 7d69586f23c0..e4a522f3b448 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -2,12 +2,6 @@
> /*
> * Copyright (C) 2015, Michael Lee <[email protected]>
> * MTK HSDMA support
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License
as published by the
> - * Free Software Foundation; either version 2 of the License, or (at your
> - * option) any later version.
> - *
> */
>
> #include <linux/dmaengine.h>
> --
> 2.20.1
>
> --

Quoted 8 lines

> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visithttps://

Quoted 14 lines

groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-3-j

Quoted 13 lines
      bi.octave%40gmail.com.
      > For more options, visit https://groups.google.com/d/optout.
      >

I will do so. Thanks.

This is not the ideal place for comments either. The response just be right under the text you are responding to. You aren't responding to

For more options, visit https://groups.google.com/d/optout.

julia

Thanks. I take good note.

#9 lore raw
In reply to Jules Irenge
Quoted 5 lines · Jules Irenge

This patch series adds SPDX license identifier to fix missing and malformed warning generated by checkpatch.pl tool
then removes unnecessary license boilerplates.
Now that we have the spdx specified,
the license text is not necessary.

This justification is fine, but it should be in the patch, not the cover letter. The cover letter is just for the recipients of the patch series. It will not be included in the git history.

julia

Quoted 18 lines

Jules Irenge (2):
staging: mt7621-dma: add SPDX GPL-2.0+ license identifier
staging: mt7621-dma: Remove license boilerplate text

 drivers/staging/mt7621-dma/mtk-hsdma.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

--
2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190302001115.20477-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.