ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
This board uses Micron N25Q256A SPI flash. Enable SPI_FLASH_BAR to allow us to access the whole chip.
---
configs/db-88f6820-amc_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/db-88f6820-amc_defconfig +1 -0
@@ -53,6 +53,7 @@ CONFIG_SYS_I2C_MVTWSI=y CONFIG_NAND=y CONFIG_NAND_PXA3XX=y CONFIG_SPI_FLASH=y +CONFIG_SPI_FLASH_BAR=y CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MARVELL=y
Signature · 1 line
2.21.0
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
Quoted 7 lines · Chris Packham
This board uses Micron N25Q256A SPI flash. Enable
SPI_FLASH_BARto allow us to access the whole chip.Signed-off-by Chris Packham <[email protected]>Cc Vignesh R <[email protected]>---
Could add imply SPI_FLASH_BAR to KIRKWOOD_SPI instead? So that we don't have to fix every defconfig that using kirkwood_spi.c.
Looks like kernel driver does support 3/4 byte addressing, but U-Boot version of the driver doesn't.
Quoted 16 lines
configs/db-88f6820-amc_defconfig | 1 + 1 file changed, 1 insertion(+)configs/db-88f6820-amc_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_SYS_I2C_MVTWSI=y CONFIG_NAND=y CONFIG_NAND_PXA3XX=y CONFIG_SPI_FLASH=y +CONFIG_SPI_FLASH_BAR=y CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_PHY_MARVELL=y
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
Hi Chris,
Hi Vignesh,
Quoted 6 lines · Vignesh Raghavendra
Quoted 3 lines · Chris Packham
This board uses Micron N25Q256A SPI flash. Enable
SPI_FLASH_BARto allow us to access the whole chip.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Chris Packham <[email protected]>Cc Vignesh R <[email protected]>---
Could add imply
SPI_FLASH_BARtoKIRKWOOD_SPIinstead? So that we don't have to fix every defconfig that usingkirkwood_spi.c.
Did you use BAR before the newly introduced SPI NOR restructuring? If not, then I would rather oppose to using it now, since option should only be used by those platforms that used it earlier as well. BAR mode is not supported by Linux and an U-Boot special.
Quoted 2 lines
Looks like kernel driver does support 3/4 byte addressing, but U-Boot version of the driver doesn't.
Could you please double check, if and how addressing of the whole 32MiB was done before? And perhaps its possible to enhance the SPI driver to support 3 and 4 byte addressing instead.
Thanks,
Stefan
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
Hi Stefan,
Quoted 15 lines · Stefan Roese
Hi Chris,
Hi Vignesh,Quoted 11 lines · Vignesh Raghavendra
Quoted 7 lines · Chris Packham
This board uses Micron N25Q256A SPI flash. Enable
SPI_FLASH_BARto allow us to access the whole chip.Signed-off-by Chris Packham <[email protected]>Cc Vignesh R <[email protected]>---
Quoted 6 lines
Quoted 2 lines
Could add imply
SPI_FLASH_BARtoKIRKWOOD_SPIinstead? So that we don't have to fix every defconfig that usingkirkwood_spi.c.Did you use BAR before the newly introduced SPI NOR restructuring? If not, then I would rather oppose to using it now, since option should only be used by those platforms that used it earlier as well.
configs/db-88f6820-amc_defconfig did use SPI_FLASH_BAR before SPI NOR re-work
Quoted 9 lines
BAR mode is not supported by Linux and an U-Boot special.
Quoted 2 lines
Looks like kernel driver does support 3/4 byte addressing, but U-Boot version of the driver doesn't.
Could you please double check, if and how addressing of the whole 32MiB was done before? And perhaps its possible to enhance the SPI driver to support 3 and 4 byte addressing instead.
It would be great if driver could be modified to support 3 and 4 byte addressing modes.
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
Hi Vignesh,
Quoted 21 lines · Vignesh Raghavendra
Hi Stefan,
Quoted 18 lines · Stefan Roese
Hi Chris,
Hi Vignesh,Quoted 13 lines · Vignesh Raghavendra
Quoted 7 lines · Chris Packham
This board uses Micron N25Q256A SPI flash. Enable
SPI_FLASH_BARto allow us to access the whole chip.Signed-off-by Chris Packham <[email protected]>Cc Vignesh R <[email protected]>---
Could add imply
SPI_FLASH_BARtoKIRKWOOD_SPIinstead? So that we don't have to fix every defconfig that usingkirkwood_spi.c.
Quoted 6 lines
Quoted 3 lines
Did you use BAR before the newly introduced SPI NOR restructuring? If not, then I would rather oppose to using it now, since option should only be used by those platforms that used it earlier as well.
configs/db-88f6820-amc_defconfig did use
SPI_FLASH_BARbefore SPI NOR re-work
I see. Thanks for checking.
Quoted 5 lines
Quoted 5 lines
BAR mode is not supported by Linux and an U-Boot special.
Quoted 2 lines
Looks like kernel driver does support 3/4 byte addressing, but U-Boot version of the driver doesn't.
Quoted 7 lines
Quoted 4 lines
Could you please double check, if and how addressing of the whole 32MiB was done before? And perhaps its possible to enhance the SPI driver to support 3 and 4 byte addressing instead.
It would be great if driver could be modified to support 3 and 4 byte addressing modes.
I fail to see, what really is needed to make the SPI driver support 3 and 4 byte addressing modes. I recently added the MT7688 SPI driver (mt7621_spi.c) which supports 3 and 4 byte mode and I remember no driver specials that I needed to implement for this feature. Its address mode agnostic AFAICT and just xfers a buffer of data to and from the SPI device.
Could you please let me know, what exactly is missing for this 4 byte mode?
Thanks,
Stefan
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
On 02-Mar-19 5:02 PM, Stefan Roese wrote:
[...]
Quoted 11 lines
Quoted 3 lines
It would be great if driver could be modified to support 3 and 4 byte addressing modes.
I fail to see, what really is needed to make the SPI driver support 3 and 4 byte addressing modes. I recently added the MT7688 SPI driver (
mt7621_spi.c) which supports 3 and 4 byte mode and I remember no driver specials that I needed to implement for this feature. Its address mode agnostic AFAICT and just xfers a buffer of data to and from the SPI device.
Certain SPI controllers have special HW support to support SPI flashes and therefore need knowledge of flash specific information such as opcode, no. of address bytes etc. More details in this blog[1] Such controllers should ideally use spi-mem interface like [2]
I see this line in kirkwood_spi.c[3] which seems to hard code address bytes to 3? Can't really be sure w/o looking at the datasheet of SPI controllers.
[1]
https://bootlin.com/blog/spi-mem-bringing-some-consistency-to-the-spi-memory-ecosystem/
[2] https://patchwork.ozlabs.org/patch/1039718/
[3]
https://elixir.bootlin.com/u-boot/latest/source/drivers/spi/kirkwood_spi.c#L132
Quoted 6 lines
Could you please let me know, what exactly is missing for this 4 byte mode?
Thanks,
Stefan
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
Quoted 16 lines · Vignesh Raghavendra
On 02-Mar-19 5:02 PM, Stefan Roese wrote:
[...]Quoted 11 lines
Quoted 3 lines
It would be great if driver could be modified to support 3 and 4 byte addressing modes.
I fail to see, what really is needed to make the SPI driver support 3 and 4 byte addressing modes. I recently added the MT7688 SPI driver (
mt7621_spi.c) which supports 3 and 4 byte mode and I remember no driver specials that I needed to implement for this feature. Its address mode agnostic AFAICT and just xfers a buffer of data to and from the SPI device.
Quoted 7 lines
Certain SPI controllers have special HW support to support SPI flashes and therefore need knowledge of flash specific information such as opcode, no. of address bytes etc. More details in this blog[1] Such controllers should ideally use spi-mem interface like [2]
I see this line in kirkwood_spi.c[3] which seems to hard code address bytes to 3? Can't really be sure w/o looking at the datasheet of SPI controllers.
I remember working on the Marvell SPI controller for Armada XP a few years ago. This 3BYTE mode is only for the special "direct mode", that is also supported by this controller. AFAIR, we don't use this direct mode in U-Boot at all. So setting this register to 3BYTE mode should be a "no-op" right now.
Quoted 12 lines
[1]
https://bootlin.com/blog/spi-mem-bringing-some-consistency-to-the-spi-memory-ecosystem/
[2] https://patchwork.ozlabs.org/patch/1039718/
[3]
https://elixir.bootlin.com/u-boot/latest/source/drivers/spi/kirkwood_spi.c#L132Quoted 6 lines
Could you please let me know, what exactly is missing for this 4 byte mode?
Thanks,
Stefan
Thanks,
Stefan
PATCH 1/1 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR
In reply to Chris PackhamQuoted 5 lines · Chris Packham
This board uses Micron N25Q256A SPI flash. Enable
SPI_FLASH_BARto allow us to access the whole chip.Signed-off-by Chris Packham <[email protected]>Cc Vignesh R <[email protected]>
Applied to u-boot-marvell/master.
Thanks,
Stefan