Skip to contentSkip to conversation

Staging: vt6655: Fix checkpatch.pl issues

PATCH Superseded Madhumitha Prabakaran 2 participants 10 messages Mar 2, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Staging: vt6655: Fix checkpatch.pl issues

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

 drivers/staging/vt6655/card.h       | 6 ++++--
 drivers/staging/vt6655/device.h     | 2 +-
 drivers/staging/vt6655/device_cfg.h | 2 +-
 drivers/staging/vt6655/dpc.h        | 2 +-
 drivers/staging/vt6655/key.h        | 2 +-
 drivers/staging/vt6655/mac.c        | 1 -
 drivers/staging/vt6655/mac.h        | 2 +-
 7 files changed, 9 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/8 Staging: vt6655: Fix line over 80 character

Fix the warning
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +2 -1
index d71022aa3f86..6bbbbe1314d5 100644
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/8 Staging: vt6655: Fix line over 80 characters

In reply to Madhumitha Prabakaran

Fix the warning
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +2 -1
index 6bbbbe1314d5..490cecf8fb9d 100644
@@ -62,6 +62,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv);
 bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type);
 bool CARDbUpdateTSF(struct vnt_private *priv, unsigned char byRxRate,
 		    u64 qwBSSTimestamp);
-bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval);
+bool CARDbSetBeaconPeriod(struct vnt_private *priv,
+			  unsigned short wBeaconInterval);
 
 #endif /* __CARD_H__ */
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifier based on License Identifier syntax for header type file.

---
 drivers/staging/vt6655/device_cfg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/device_cfg.h +1 -1
index 6b41c74f7c2a..04db6a8d3db3 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#4 lore raw

PATCH 4/8 Staging: vt6655: Fix comment style of SPDX License Identifer

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header type file based on License Identifier syntax.

---
 drivers/staging/vt6655/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/device.h +1 -1
index 2f9e9219e8c8..29f354ced563 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#5 lore raw

PATCH 5/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header file based on License Identifier syntax.

---
 drivers/staging/vt6655/dpc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/dpc.h +1 -1
index 93af4220605f..eac67794cc49 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#6 lore raw

PATCH 6/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifier for header file type based on License Identifer syntax.

---
 drivers/staging/vt6655/key.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/key.h +1 -1
index 0942d8703f98..9347776fa3a5 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#7 lore raw

PATCH 7/8 Staging: vt6655: Remove unnecessary blank line

In reply to Madhumitha Prabakaran

Remove unnecessary blank line before end of block brace so that it fix the check
CHECK: Blank lines aren't necessary before a close brace '}'

---
 drivers/staging/vt6655/mac.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vt6655/mac.c +0 -1
index 4750863c1bb7..40a8f1ce837c 100644
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
 	iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
 	if (org_dma_ctl & DMACTL_RUN)
 		iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
 }
 
 /*
Signature · 1 line
2.17.1
#8 lore raw

PATCH 8/8 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifer for header type file based on License Identifer syntax.

---
 drivers/staging/vt6655/mac.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/mac.h +1 -1
index b8ab09434773..8c8c26792343 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
maintainer
#9 lore raw
In reply to Madhumitha Prabakaran
Quoted 11 lines · Madhumitha Prabakaran

These patches fix warnings of line over 80 characters, comment style issues of SPDX License Identifier and remove unnecessary blank line.

Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: card.h: Fix line over 80 characters
Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
Staging: vt6655: mac.c: Remove unnecessary blank line
Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

These lines do not match up with the subject lines of your patches you sent out.

Please fix up and resend.

thansk,

greg k-h